refactor(profiling): extract SystemProfiler#2794
Closed
morrisonlevi wants to merge 9 commits intomasterfrom
Closed
refactor(profiling): extract SystemProfiler#2794morrisonlevi wants to merge 9 commits intomasterfrom
morrisonlevi wants to merge 9 commits intomasterfrom
Conversation
The global profiler (e.g. PROFILER) and the Profiler::* functions that worked on it were moved into a new struct SystemProfiler.
c72a00e to
48498a4
Compare
BenchmarksBenchmark execution time: 2024-08-15 16:25:56 Comparing candidate commit 48498a4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 27 metrics, 9 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## florian/remove-mutex #2794 +/- ##
=======================================================
Coverage 78.64% 78.64%
Complexity 2452 2452
=======================================================
Files 143 143
Lines 14276 14276
=======================================================
Hits 11228 11228
Misses 3048 3048
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
realFlowControl
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The global profiler (e.g. PROFILER) and the Profiler::* functions that worked on it were moved into a new struct SystemProfiler.
Motivation
The
profiling/src/profiling/mod.rsfile was getting big and there was a logical split for functions that worked on the global PROFILER vs those which worked on a profiler object.Reviewer checklist