Introduces testJvmConstraint Gradle extension to replace extra properties
#9892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion # Conflicts: # dd-java-agent/instrumentation/aerospike-4.0/build.gradle # dd-java-agent/instrumentation/armeria/armeria-jetty-1.24/build.gradle
… test jvm constraints
…includeJdk directive
bric3
requested review from
AlexeyKuznetsov-DD,
Mariovido,
manuel-alvarez-alvarez and
sarahchen6
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Refactor the mechanism that relied on extra properties like
minJavaVersionForTeststo a Gradle extension mechanism.Also,
minJavaVersionForTestswas serving two distinct purposeThis PR explicitly segregates these two concerns.
Motivation
The way the extra properties were programmed prevents to remove some
project.afterEvaluatecalls. And also prevents to migrate to convention plugins (these are ultimately pre-compiled script plugins).Additional Notes
At this time the logic remains very similar, and focuses on the refactoring from extra properties (
ext { }) to extensions to avoid too many change.However, in the future it might be interesting to revisit the way the JDK is specified, from
JavaVersionto something more toolchain aware viaorg.gradle.jvm.toolchain.JavaToolchainSpec.Some projects still rely on regular Gradle directives to set the sourceset. These will be migrate in a follow-up PR :
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]