Skip to content

check for empty env when setting cloud payload tagging #9887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check for empty env when setting cloud payload tagging #9887

wants to merge 2 commits into from
+57 −2

Conversation

@ojproductions
Copy link

@ojproductions ojproductions commented Oct 30, 2025 •
edited by atlassian bot
Loading

What Does This Do

Ensures if DD cloud trace payload tagging envs are present but empty (i.e the envs are set to empty string), the feature is turned off.

Motivation

Specifically in the lambda environment, users (or some instrumenation helpers such as datadog-cdk-constructs) may add the env without adding any value so that it defaults to disabled.
This is to make the feature visible for discovery purposes, but without forcing it as a default

read more here

APMSVLS-53

@datadog-official
Copy link

datadog-official bot commented Oct 30, 2025 •
edited by datadog-datadog-prod-us1 bot
Loading

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 60.15% (+0.45%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c46f528 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/fix-aws-payload-tagging
git_commit_date 1761835849 1761838729
git_commit_sha 9b91826 c46f528
release_version 1.55.0-SNAPSHOT~9b91826873 1.55.0-SNAPSHOT~c46f5287f1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1761840383 1761840383
ci_job_id 1207070607 1207070607
ci_pipeline_id 80762819 80762819
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-v0avl7uy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-v0avl7uy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.035 s) : 0, 1034753
Total [baseline] (4.301 s) : 0, 4301373
Agent [candidate] (1.048 s) : 0, 1048488
Total [candidate] (10.931 s) : 0, 10931269
section appsec
Agent [baseline] (1.223 s) : 0, 1222998
Total [baseline] (11.091 s) : 0, 11090658
Agent [candidate] (1.214 s) : 0, 1213662
Total [candidate] (11.078 s) : 0, 11077563
section iast
Agent [baseline] (1.172 s) : 0, 1171540
Total [baseline] (11.218 s) : 0, 11217645
Agent [candidate] (1.169 s) : 0, 1168582
Total [candidate] (11.189 s) : 0, 11188894
section profiling
Agent [baseline] (1.182 s) : 0, 1182164
Total [baseline] (10.991 s) : 0, 10990587
Agent [candidate] (1.18 s) : 0, 1179812
Total [candidate] (10.949 s) : 0, 10948565
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent appsec 1.223 s 188.245 ms (18.2%)
Agent iast 1.172 s 136.787 ms (13.2%)
Agent profiling 1.182 s 147.411 ms (14.2%)
Total tracing 4.301 s -
Total appsec 11.091 s 6.789 s (157.8%)
Total iast 11.218 s 6.916 s (160.8%)
Total profiling 10.991 s 6.689 s (155.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent appsec 1.214 s 165.174 ms (15.8%)
Agent iast 1.169 s 120.095 ms (11.5%)
Agent profiling 1.18 s 131.324 ms (12.5%)
Total tracing 10.931 s -
Total appsec 11.078 s 146.294 ms (1.3%)
Total iast 11.189 s 257.625 ms (2.4%)
Total profiling 10.949 s 17.296 ms (0.2%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.595 ms) : 0, 1595
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (706.84 ms) : 0, 706840
BytebuddyAgent [candidate] (716.068 ms) : 0, 716068
GlobalTracer [baseline] (245.114 ms) : 0, 245114
GlobalTracer [candidate] (248.172 ms) : 0, 248172
AppSec [baseline] (32.529 ms) : 0, 32529
AppSec [candidate] (32.784 ms) : 0, 32784
Debugger [baseline] (6.404 ms) : 0, 6404
Debugger [candidate] (6.54 ms) : 0, 6540
Remote Config [baseline] (698.79 µs) : 0, 699
Remote Config [candidate] (683.599 µs) : 0, 684
Telemetry [baseline] (16.049 ms) : 0, 16049
Telemetry [candidate] (14.576 ms) : 0, 14576
Flare Poller [baseline] (4.163 ms) : 0, 4163
Flare Poller [candidate] (6.577 ms) : 0, 6577
section appsec
crashtracking [baseline] (1.513 ms) : 0, 1513
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (736.646 ms) : 0, 736646
BytebuddyAgent [candidate] (732.862 ms) : 0, 732862
GlobalTracer [baseline] (240.819 ms) : 0, 240819
GlobalTracer [candidate] (238.474 ms) : 0, 238474
AppSec [baseline] (177.401 ms) : 0, 177401
AppSec [candidate] (175.066 ms) : 0, 175066
Debugger [baseline] (6.117 ms) : 0, 6117
Debugger [candidate] (5.991 ms) : 0, 5991
Remote Config [baseline] (657.953 µs) : 0, 658
Remote Config [candidate] (632.115 µs) : 0, 632
Telemetry [baseline] (8.781 ms) : 0, 8781
Telemetry [candidate] (8.526 ms) : 0, 8526
Flare Poller [baseline] (4.084 ms) : 0, 4084
Flare Poller [candidate] (4.014 ms) : 0, 4014
IAST [baseline] (25.544 ms) : 0, 25544
IAST [candidate] (25.269 ms) : 0, 25269
section iast
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (830.86 ms) : 0, 830860
BytebuddyAgent [candidate] (828.038 ms) : 0, 828038
GlobalTracer [baseline] (236.257 ms) : 0, 236257
GlobalTracer [candidate] (235.85 ms) : 0, 235850
AppSec [baseline] (29.708 ms) : 0, 29708
AppSec [candidate] (30.881 ms) : 0, 30881
Debugger [baseline] (6.185 ms) : 0, 6185
Debugger [candidate] (6.253 ms) : 0, 6253
Remote Config [baseline] (604.06 µs) : 0, 604
Remote Config [candidate] (671.611 µs) : 0, 672
Telemetry [baseline] (8.498 ms) : 0, 8498
Telemetry [candidate] (8.641 ms) : 0, 8641
Flare Poller [baseline] (4.226 ms) : 0, 4226
Flare Poller [candidate] (4.168 ms) : 0, 4168
IAST [baseline] (32.209 ms) : 0, 32209
IAST [candidate] (31.121 ms) : 0, 31121
section profiling
ProfilingAgent [baseline] (110.239 ms) : 0, 110239
ProfilingAgent [candidate] (110.076 ms) : 0, 110076
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (730.609 ms) : 0, 730609
BytebuddyAgent [candidate] (729.467 ms) : 0, 729467
GlobalTracer [baseline] (223.201 ms) : 0, 223201
GlobalTracer [candidate] (222.481 ms) : 0, 222481
AppSec [baseline] (32.566 ms) : 0, 32566
AppSec [candidate] (32.433 ms) : 0, 32433
Debugger [baseline] (9.954 ms) : 0, 9954
Debugger [candidate] (8.267 ms) : 0, 8267
Remote Config [baseline] (1.528 ms) : 0, 1528
Remote Config [candidate] (1.452 ms) : 0, 1452
Telemetry [baseline] (12.531 ms) : 0, 12531
Telemetry [candidate] (14.079 ms) : 0, 14079
Flare Poller [baseline] (4.1 ms) : 0, 4100
Flare Poller [candidate] (4.181 ms) : 0, 4181
Profiling [baseline] (110.945 ms) : 0, 110945
Profiling [candidate] (110.736 ms) : 0, 110736
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043416
Total [baseline] (8.727 s) : 0, 8727163
Agent [candidate] (1.032 s) : 0, 1031689
Total [candidate] (8.699 s) : 0, 8698962
section iast
Agent [baseline] (1.171 s) : 0, 1171050
Total [baseline] (9.395 s) : 0, 9395008
Agent [candidate] (1.167 s) : 0, 1166967
Total [candidate] (9.44 s) : 0, 9440154
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent iast 1.171 s 127.635 ms (12.2%)
Total tracing 8.727 s -
Total iast 9.395 s 667.846 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.032 s -
Agent iast 1.167 s 135.278 ms (13.1%)
Total tracing 8.699 s -
Total iast 9.44 s 741.192 ms (8.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (712.884 ms) : 0, 712884
BytebuddyAgent [candidate] (703.29 ms) : 0, 703290
GlobalTracer [baseline] (246.854 ms) : 0, 246854
GlobalTracer [candidate] (245.538 ms) : 0, 245538
AppSec [baseline] (32.605 ms) : 0, 32605
AppSec [candidate] (32.341 ms) : 0, 32341
Debugger [baseline] (6.44 ms) : 0, 6440
Debugger [candidate] (6.4 ms) : 0, 6400
Remote Config [baseline] (701.546 µs) : 0, 702
Remote Config [candidate] (683.027 µs) : 0, 683
Telemetry [baseline] (13.806 ms) : 0, 13806
Telemetry [candidate] (13.77 ms) : 0, 13770
Flare Poller [baseline] (7.22 ms) : 0, 7220
Flare Poller [candidate] (7.005 ms) : 0, 7005
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (831.171 ms) : 0, 831171
BytebuddyAgent [candidate] (827.98 ms) : 0, 827980
GlobalTracer [baseline] (235.408 ms) : 0, 235408
GlobalTracer [candidate] (235.363 ms) : 0, 235363
AppSec [baseline] (29.395 ms) : 0, 29395
AppSec [candidate] (28.867 ms) : 0, 28867
Debugger [baseline] (6.121 ms) : 0, 6121
Debugger [candidate] (6.157 ms) : 0, 6157
Remote Config [baseline] (602.151 µs) : 0, 602
Remote Config [candidate] (613.592 µs) : 0, 614
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.557 ms) : 0, 8557
Flare Poller [baseline] (4.175 ms) : 0, 4175
Flare Poller [candidate] (4.115 ms) : 0, 4115
IAST [baseline] (32.748 ms) : 0, 32748
IAST [candidate] (32.535 ms) : 0, 32535
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/fix-aws-payload-tagging
git_commit_date 1761835849 1761838729
git_commit_sha 9b91826 c46f528
release_version 1.55.0-SNAPSHOT~9b91826873 1.55.0-SNAPSHOT~c46f5287f1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1761840970 1761840970
ci_job_id 1207070608 1207070608
ci_pipeline_id 80762819 80762819
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-23emktlp 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-23emktlp 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 4 performance improvements and 3 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+174.919µs; +212.990µs] or [+8.993%; +10.950%]		 unstable
[-458.627op/s; +53.814op/s] or [-19.791%; +2.322%]		 2.139ms 2114.906op/s 1.945ms 2317.312op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-254.210µs; -144.860µs] or [-6.980%; -3.977%]		 unstable
[-59.383op/s; +202.820op/s] or [-4.715%; +16.104%]		 3.443ms 1331.156op/s 3.642ms 1259.438op/s
scenario:load:insecure-bank:iast:high_load better
[-286.595µs; -190.695µs] or [-8.421%; -5.603%]		 unstable
[-50.424op/s; +249.362op/s] or [-3.746%; +18.527%]		 3.165ms 1445.438op/s 3.403ms 1345.969op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-257.156µs; -132.647µs] or [-4.362%; -2.250%]		 unstable
[-51.211op/s; +104.086op/s] or [-6.528%; +13.268%]		 5.701ms 810.938op/s 5.895ms 784.500op/s
scenario:load:petclinic:iast:high_load better
[-1.417ms; -1.002ms] or [-7.174%; -5.072%]		 unstable
[-9.014op/s; +39.764op/s] or [-3.813%; +16.822%]		 18.542ms 251.750op/s 19.752ms 236.375op/s
scenario:load:petclinic:no_agent:high_load worse
[+559.132µs; +936.548µs] or [+3.249%; +5.442%]		 unstable
[-38.736op/s; +16.173op/s] or [-14.285%; +5.965%]		 17.958ms 259.875op/s 17.210ms 271.156op/s
scenario:load:petclinic:profiling:high_load worse
[+556.828µs; +989.668µs] or [+2.847%; +5.060%]		 unstable
[-32.468op/s; +14.468op/s] or [-13.603%; +6.062%]		 20.330ms 229.688op/s 19.557ms 238.688op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.21 ms) : 17038, 17383
.   : milestone, 17210,
appsec (20.368 ms) : 20160, 20577
.   : milestone, 20368,
code_origins (18.503 ms) : 18317, 18688
.   : milestone, 18503,
iast (19.752 ms) : 19550, 19953
.   : milestone, 19752,
profiling (19.557 ms) : 19356, 19758
.   : milestone, 19557,
tracing (18.447 ms) : 18264, 18630
.   : milestone, 18447,
section candidate
no_agent (17.958 ms) : 17780, 18136
.   : milestone, 17958,
appsec (20.797 ms) : 20588, 21006
.   : milestone, 20797,
code_origins (18.759 ms) : 18566, 18952
.   : milestone, 18759,
iast (18.542 ms) : 18358, 18726
.   : milestone, 18542,
profiling (20.33 ms) : 20129, 20531
.   : milestone, 20330,
tracing (18.431 ms) : 18245, 18616
.   : milestone, 18431,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.21 ms [17.038 ms, 17.383 ms] -
appsec 20.368 ms [20.16 ms, 20.577 ms] 3.158 ms (18.3%)
code_origins 18.503 ms [18.317 ms, 18.688 ms] 1.292 ms (7.5%)
iast 19.752 ms [19.55 ms, 19.953 ms] 2.541 ms (14.8%)
profiling 19.557 ms [19.356 ms, 19.758 ms] 2.347 ms (13.6%)
tracing 18.447 ms [18.264 ms, 18.63 ms] 1.237 ms (7.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.958 ms [17.78 ms, 18.136 ms] -
appsec 20.797 ms [20.588 ms, 21.006 ms] 2.839 ms (15.8%)
code_origins 18.759 ms [18.566 ms, 18.952 ms] 800.995 µs (4.5%)
iast 18.542 ms [18.358 ms, 18.726 ms] 583.91 µs (3.3%)
profiling 20.33 ms [20.129 ms, 20.531 ms] 2.372 ms (13.2%)
tracing 18.431 ms [18.245 ms, 18.616 ms] 472.657 µs (2.6%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.193 ms) : 1181, 1204
.   : milestone, 1193,
iast (3.403 ms) : 3356, 3450
.   : milestone, 3403,
iast_FULL (5.895 ms) : 5835, 5955
.   : milestone, 5895,
iast_GLOBAL (3.642 ms) : 3589, 3695
.   : milestone, 3642,
profiling (1.945 ms) : 1929, 1962
.   : milestone, 1945,
tracing (1.823 ms) : 1808, 1838
.   : milestone, 1823,
section candidate
no_agent (1.184 ms) : 1172, 1196
.   : milestone, 1184,
iast (3.165 ms) : 3123, 3207
.   : milestone, 3165,
iast_FULL (5.701 ms) : 5645, 5756
.   : milestone, 5701,
iast_GLOBAL (3.443 ms) : 3394, 3491
.   : milestone, 3443,
profiling (2.139 ms) : 2120, 2158
.   : milestone, 2139,
tracing (1.79 ms) : 1775, 1804
.   : milestone, 1790,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.193 ms [1.181 ms, 1.204 ms] -
iast 3.403 ms [3.356 ms, 3.45 ms] 2.211 ms (185.3%)
iast_FULL 5.895 ms [5.835 ms, 5.955 ms] 4.703 ms (394.3%)
iast_GLOBAL 3.642 ms [3.589 ms, 3.695 ms] 2.449 ms (205.4%)
profiling 1.945 ms [1.929 ms, 1.962 ms] 752.336 µs (63.1%)
tracing 1.823 ms [1.808 ms, 1.838 ms] 630.213 µs (52.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.184 ms [1.172 ms, 1.196 ms] -
iast 3.165 ms [3.123 ms, 3.207 ms] 1.981 ms (167.3%)
iast_FULL 5.701 ms [5.645 ms, 5.756 ms] 4.517 ms (381.5%)
iast_GLOBAL 3.443 ms [3.394 ms, 3.491 ms] 2.259 ms (190.8%)
profiling 2.139 ms [2.12 ms, 2.158 ms] 955.074 µs (80.7%)
tracing 1.79 ms [1.775 ms, 1.804 ms] 605.943 µs (51.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/fix-aws-payload-tagging
git_commit_date 1761835849 1761838729
git_commit_sha 9b91826 c46f528
release_version 1.55.0-SNAPSHOT~9b91826873 1.55.0-SNAPSHOT~c46f5287f1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1761840676 1761840676
ci_job_id 1207070609 1207070609
ci_pipeline_id 80762819 80762819
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-6wk6ikhp 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-6wk6ikhp 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (3.65 ms) : 3437, 3863
.   : milestone, 3650,
iast (2.212 ms) : 2147, 2276
.   : milestone, 2212,
iast_GLOBAL (2.25 ms) : 2186, 2315
.   : milestone, 2250,
profiling (2.503 ms) : 2332, 2674
.   : milestone, 2503,
tracing (2.038 ms) : 1988, 2089
.   : milestone, 2038,
section candidate
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.712 ms) : 3494, 3930
.   : milestone, 3712,
iast (2.221 ms) : 2156, 2285
.   : milestone, 2221,
iast_GLOBAL (2.256 ms) : 2191, 2321
.   : milestone, 2256,
profiling (2.079 ms) : 2025, 2132
.   : milestone, 2079,
tracing (2.037 ms) : 1987, 2087
.   : milestone, 2037,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 3.65 ms [3.437 ms, 3.863 ms] 2.178 ms (148.0%)
iast 2.212 ms [2.147 ms, 2.276 ms] 740.028 µs (50.3%)
iast_GLOBAL 2.25 ms [2.186 ms, 2.315 ms] 778.771 µs (52.9%)
profiling 2.503 ms [2.332 ms, 2.674 ms] 1.032 ms (70.1%)
tracing 2.038 ms [1.988 ms, 2.089 ms] 566.773 µs (38.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 3.712 ms [3.494 ms, 3.93 ms] 2.237 ms (151.7%)
iast 2.221 ms [2.156 ms, 2.285 ms] 745.784 µs (50.6%)
iast_GLOBAL 2.256 ms [2.191 ms, 2.321 ms] 781.235 µs (53.0%)
profiling 2.079 ms [2.025 ms, 2.132 ms] 603.918 µs (41.0%)
tracing 2.037 ms [1.987 ms, 2.087 ms] 562.387 µs (38.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~c46f5287f1, baseline=1.55.0-SNAPSHOT~9b91826873
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.085 s) : 15085000, 15085000
.   : milestone, 15085000,
appsec (14.781 s) : 14781000, 14781000
.   : milestone, 14781000,
iast (18.538 s) : 18538000, 18538000
.   : milestone, 18538000,
iast_GLOBAL (18.348 s) : 18348000, 18348000
.   : milestone, 18348000,
profiling (15.347 s) : 15347000, 15347000
.   : milestone, 15347000,
tracing (15.268 s) : 15268000, 15268000
.   : milestone, 15268000,
section candidate
no_agent (15.375 s) : 15375000, 15375000
.   : milestone, 15375000,
appsec (14.711 s) : 14711000, 14711000
.   : milestone, 14711000,
iast (18.673 s) : 18673000, 18673000
.   : milestone, 18673000,
iast_GLOBAL (18.251 s) : 18251000, 18251000
.   : milestone, 18251000,
profiling (15.55 s) : 15550000, 15550000
.   : milestone, 15550000,
tracing (15.456 s) : 15456000, 15456000
.   : milestone, 15456000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.085 s [15.085 s, 15.085 s] -
appsec 14.781 s [14.781 s, 14.781 s] -304.0 ms (-2.0%)
iast 18.538 s [18.538 s, 18.538 s] 3.453 s (22.9%)
iast_GLOBAL 18.348 s [18.348 s, 18.348 s] 3.263 s (21.6%)
profiling 15.347 s [15.347 s, 15.347 s] 262.0 ms (1.7%)
tracing 15.268 s [15.268 s, 15.268 s] 183.0 ms (1.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.375 s [15.375 s, 15.375 s] -
appsec 14.711 s [14.711 s, 14.711 s] -664.0 ms (-4.3%)
iast 18.673 s [18.673 s, 18.673 s] 3.298 s (21.5%)
iast_GLOBAL 18.251 s [18.251 s, 18.251 s] 2.876 s (18.7%)
profiling 15.55 s [15.55 s, 15.55 s] 175.0 ms (1.1%)
tracing 15.456 s [15.456 s, 15.456 s] 81.0 ms (0.5%)

@ojproductions ojproductions requested a review from mhlidd October 30, 2025 20:31
@ojproductions ojproductions marked this pull request as ready for review October 30, 2025 20:31
@ojproductions ojproductions requested a review from a team as a code owner October 30, 2025 20:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mhlidd
mhlidd reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@mhlidd mhlidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General Question: If the config is set to a non-JSON-path value, or not "all", should the feature be turned off in the Config class?

@ojproductions ojproductions added type: enhancement Enhancements and improvements comp: config labels Oct 31, 2025
@ojproductions
Copy link
Author

ojproductions commented Oct 31, 2025 •
edited
Loading

@mhlidd, if we are to take the official documentation literally, the only time payload tagging is disabled is when the variables are empty or omitted. I do see how this could be misleading though because you can effectively turn on payload tagging by adding any value even if it is not "all". How I see it though, the paths are subtractive rather than additive. Meaning, default is to show every field, and for every valid path added, we show 1 less field. If the path is invalid its ignored

@mhlidd
Copy link
Contributor

mhlidd commented Oct 31, 2025

I do see how this could be misleading though because you can effectively turn on payload tagging by adding any value even if it is not "all".

Just want to make sure that this is aligned with the spec. From the spec, I see the following:

Therefore, in an ideal case, the feature should only be turned on when the value in the envs is “all” or a comma-separated list of JSONPath queries. Meaning, we can just set the envs to false or empty to turn off the feature.

This seems a little contradictory to the behavior we see in the tracer. While the redaction behavior would not be turned on unless the JSON paths passed in are valid, the configs are still when adding AWS span tags at some point. ❓ Does the RFC spec mean that we want the span tag behavior to also be disabled when non-valid JSON paths are set for the environment variables. If so, we may need to modify the logic of verifying the logic of handling the Environment Variable values.

@ojproductions
Copy link
Author

ojproductions commented Oct 31, 2025 •
edited
Loading

I think this comes down to which source of truth we want to honor – the spec or the public documentation on datadog website. I believe @joeyzhao2018 (author of the spec) also decided to follow the public doc (but correct me if I'm wrong Joey. Either way we should update the spec accordingly)
Another consideration would be feature-parity across languages. I wouldn't want to introduce functionality thats different from say Python or Javascript. Currently I'm assuming they follow the public doc but I'll confirm on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhlidd mhlidd mhlidd left review comments

@joeyzhao2018 joeyzhao2018 Awaiting requested review from joeyzhao2018

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

comp: config type: enhancement Enhancements and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ojproductions @mhlidd