Skip to content

Do not allocate a tracing context when not fully extracted #9693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not allocate a tracing context when not fully extracted #9693

wants to merge 2 commits into from
+11 −2

Conversation

amarziali
Copy link
Contributor

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Oct 8, 2025 •
edited by datadog-official bot
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.66% (-0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1c997f9 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 8, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/context-otel
git_commit_date 1759910850 1759916448
git_commit_sha 60a3b9d 1c997f9
release_version 1.55.0-SNAPSHOT~60a3b9d880 1.55.0-SNAPSHOT~1c997f9322
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759918378 1759918378
ci_job_id 1168954955 1168954955
ci_pipeline_id 78698665 78698665
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-2jj233hx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-2jj233hx 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018352
Total [baseline] (8.66 s) : 0, 8659958
Agent [candidate] (1.016 s) : 0, 1016428
Total [candidate] (8.685 s) : 0, 8684767
section iast
Agent [baseline] (1.152 s) : 0, 1152198
Total [baseline] (9.287 s) : 0, 9286997
Agent [candidate] (1.162 s) : 0, 1161772
Total [candidate] (9.328 s) : 0, 9327588
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent iast 1.152 s 133.846 ms (13.1%)
Total tracing 8.66 s -
Total iast 9.287 s 627.038 ms (7.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.016 s -
Agent iast 1.162 s 145.344 ms (14.3%)
Total tracing 8.685 s -
Total iast 9.328 s 642.821 ms (7.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (694.637 ms) : 0, 694637
BytebuddyAgent [candidate] (692.185 ms) : 0, 692185
GlobalTracer [baseline] (242.167 ms) : 0, 242167
GlobalTracer [candidate] (241.635 ms) : 0, 241635
AppSec [baseline] (33.006 ms) : 0, 33006
AppSec [candidate] (32.645 ms) : 0, 32645
Debugger [baseline] (6.42 ms) : 0, 6420
Debugger [candidate] (6.47 ms) : 0, 6470
Remote Config [baseline] (710.621 µs) : 0, 711
Remote Config [candidate] (698.803 µs) : 0, 699
Telemetry [baseline] (9.198 ms) : 0, 9198
Telemetry [candidate] (9.183 ms) : 0, 9183
Flare Poller [baseline] (9.575 ms) : 0, 9575
Flare Poller [candidate] (10.988 ms) : 0, 10988
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (815.933 ms) : 0, 815933
BytebuddyAgent [candidate] (822.55 ms) : 0, 822550
GlobalTracer [baseline] (231.804 ms) : 0, 231804
GlobalTracer [candidate] (233.433 ms) : 0, 233433
AppSec [baseline] (35.838 ms) : 0, 35838
AppSec [candidate] (36.119 ms) : 0, 36119
Debugger [baseline] (6.088 ms) : 0, 6088
Debugger [candidate] (6.195 ms) : 0, 6195
Remote Config [baseline] (602.792 µs) : 0, 603
Remote Config [candidate] (622.034 µs) : 0, 622
Telemetry [baseline] (8.514 ms) : 0, 8514
Telemetry [candidate] (8.786 ms) : 0, 8786
Flare Poller [baseline] (4.204 ms) : 0, 4204
Flare Poller [candidate] (4.29 ms) : 0, 4290
IAST [baseline] (26.402 ms) : 0, 26402
IAST [candidate] (26.834 ms) : 0, 26834
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019859
Total [baseline] (10.792 s) : 0, 10791903
Agent [candidate] (1.028 s) : 0, 1028217
Total [candidate] (10.767 s) : 0, 10767301
section appsec
Agent [baseline] (1.196 s) : 0, 1195794
Total [baseline] (11.108 s) : 0, 11107660
Agent [candidate] (1.203 s) : 0, 1203337
Total [candidate] (11.095 s) : 0, 11095115
section iast
Agent [baseline] (1.153 s) : 0, 1152753
Total [baseline] (11.003 s) : 0, 11002693
Agent [candidate] (1.156 s) : 0, 1156124
Total [candidate] (11.009 s) : 0, 11009439
section profiling
Agent [baseline] (1.166 s) : 0, 1165795
Total [baseline] (11.079 s) : 0, 11078888
Agent [candidate] (1.164 s) : 0, 1163994
Total [candidate] (11.062 s) : 0, 11061700
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.196 s 175.935 ms (17.3%)
Agent iast 1.153 s 132.893 ms (13.0%)
Agent profiling 1.166 s 145.935 ms (14.3%)
Total tracing 10.792 s -
Total appsec 11.108 s 315.757 ms (2.9%)
Total iast 11.003 s 210.79 ms (2.0%)
Total profiling 11.079 s 286.986 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent appsec 1.203 s 175.12 ms (17.0%)
Agent iast 1.156 s 127.907 ms (12.4%)
Agent profiling 1.164 s 135.776 ms (13.2%)
Total tracing 10.767 s -
Total appsec 11.095 s 327.814 ms (3.0%)
Total iast 11.009 s 242.138 ms (2.2%)
Total profiling 11.062 s 294.4 ms (2.7%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (694.594 ms) : 0, 694594
BytebuddyAgent [candidate] (701.219 ms) : 0, 701219
GlobalTracer [baseline] (242.242 ms) : 0, 242242
GlobalTracer [candidate] (244.188 ms) : 0, 244188
AppSec [baseline] (32.897 ms) : 0, 32897
AppSec [candidate] (33.241 ms) : 0, 33241
Debugger [baseline] (6.413 ms) : 0, 6413
Debugger [candidate] (6.487 ms) : 0, 6487
Remote Config [baseline] (699.96 µs) : 0, 700
Remote Config [candidate] (698.515 µs) : 0, 699
Telemetry [baseline] (9.336 ms) : 0, 9336
Telemetry [candidate] (9.227 ms) : 0, 9227
Flare Poller [baseline] (10.923 ms) : 0, 10923
Flare Poller [candidate] (10.263 ms) : 0, 10263
section appsec
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (718.584 ms) : 0, 718584
BytebuddyAgent [candidate] (723.05 ms) : 0, 723050
GlobalTracer [baseline] (234.477 ms) : 0, 234477
GlobalTracer [candidate] (236.113 ms) : 0, 236113
AppSec [baseline] (176.085 ms) : 0, 176085
AppSec [candidate] (177.098 ms) : 0, 177098
Debugger [baseline] (6.2 ms) : 0, 6200
Debugger [candidate] (6.134 ms) : 0, 6134
Remote Config [baseline] (652.132 µs) : 0, 652
Remote Config [candidate] (658.816 µs) : 0, 659
Telemetry [baseline] (8.524 ms) : 0, 8524
Telemetry [candidate] (8.486 ms) : 0, 8486
Flare Poller [baseline] (4.016 ms) : 0, 4016
Flare Poller [candidate] (3.959 ms) : 0, 3959
IAST [baseline] (24.725 ms) : 0, 24725
IAST [candidate] (25.075 ms) : 0, 25075
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (816.696 ms) : 0, 816696
BytebuddyAgent [candidate] (817.614 ms) : 0, 817614
GlobalTracer [baseline] (231.858 ms) : 0, 231858
GlobalTracer [candidate] (233.392 ms) : 0, 233392
AppSec [baseline] (35.477 ms) : 0, 35477
AppSec [candidate] (35.801 ms) : 0, 35801
Debugger [baseline] (6.123 ms) : 0, 6123
Debugger [candidate] (6.158 ms) : 0, 6158
Remote Config [baseline] (601.509 µs) : 0, 602
Remote Config [candidate] (611.796 µs) : 0, 612
Telemetry [baseline] (8.582 ms) : 0, 8582
Telemetry [candidate] (8.612 ms) : 0, 8612
Flare Poller [baseline] (4.26 ms) : 0, 4260
Flare Poller [candidate] (4.187 ms) : 0, 4187
IAST [baseline] (26.286 ms) : 0, 26286
IAST [candidate] (26.847 ms) : 0, 26847
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (722.954 ms) : 0, 722954
BytebuddyAgent [candidate] (722.7 ms) : 0, 722700
GlobalTracer [baseline] (218.245 ms) : 0, 218245
GlobalTracer [candidate] (217.71 ms) : 0, 217710
AppSec [baseline] (33.258 ms) : 0, 33258
AppSec [candidate] (33.053 ms) : 0, 33053
Debugger [baseline] (7.274 ms) : 0, 7274
Debugger [candidate] (6.466 ms) : 0, 6466
Remote Config [baseline] (710.461 µs) : 0, 710
Remote Config [candidate] (706.752 µs) : 0, 707
Telemetry [baseline] (15.802 ms) : 0, 15802
Telemetry [candidate] (16.516 ms) : 0, 16516
Flare Poller [baseline] (4.334 ms) : 0, 4334
Flare Poller [candidate] (4.239 ms) : 0, 4239
ProfilingAgent [baseline] (108.355 ms) : 0, 108355
ProfilingAgent [candidate] (107.521 ms) : 0, 107521
Profiling [baseline] (109.76 ms) : 0, 109760
Profiling [candidate] (109.326 ms) : 0, 109326
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/context-otel
git_commit_date 1759910850 1759916448
git_commit_sha 60a3b9d 1c997f9
release_version 1.55.0-SNAPSHOT~60a3b9d880 1.55.0-SNAPSHOT~1c997f9322
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1759918042 1759918042
ci_job_id 1168954957 1168954957
ci_pipeline_id 78698665 78698665
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-5vjxmrvo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-5vjxmrvo 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-264.056µs; -143.614µs] or [-5.853%; -3.183%]		 unstable
[-68.944op/s; +163.069op/s] or [-6.773%; +16.020%]		 4.307ms 1065.000op/s 4.511ms 1017.938op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-1.613ms; -0.968ms] or [-10.302%; -6.187%]		 unstable
[-8.090op/s; +61.152op/s] or [-2.715%; +20.525%]		 14.362ms 324.469op/s 15.653ms 297.938op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.577 ms) : 37264, 37890
.   : milestone, 37577,
appsec (47.59 ms) : 47166, 48014
.   : milestone, 47590,
code_origins (45.006 ms) : 44629, 45384
.   : milestone, 45006,
iast (44.464 ms) : 44082, 44845
.   : milestone, 44464,
profiling (47.078 ms) : 46645, 47511
.   : milestone, 47078,
tracing (44.131 ms) : 43755, 44508
.   : milestone, 44131,
section candidate
no_agent (36.505 ms) : 36208, 36802
.   : milestone, 36505,
appsec (48.969 ms) : 48541, 49397
.   : milestone, 48969,
code_origins (44.148 ms) : 43754, 44542
.   : milestone, 44148,
iast (44.039 ms) : 43670, 44407
.   : milestone, 44039,
profiling (46.707 ms) : 46292, 47121
.   : milestone, 46707,
tracing (45.234 ms) : 44842, 45626
.   : milestone, 45234,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.577 ms [37.264 ms, 37.89 ms] -
appsec 47.59 ms [47.166 ms, 48.014 ms] 10.013 ms (26.6%)
code_origins 45.006 ms [44.629 ms, 45.384 ms] 7.429 ms (19.8%)
iast 44.464 ms [44.082 ms, 44.845 ms] 6.886 ms (18.3%)
profiling 47.078 ms [46.645 ms, 47.511 ms] 9.501 ms (25.3%)
tracing 44.131 ms [43.755 ms, 44.508 ms] 6.554 ms (17.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.505 ms [36.208 ms, 36.802 ms] -
appsec 48.969 ms [48.541 ms, 49.397 ms] 12.464 ms (34.1%)
code_origins 44.148 ms [43.754 ms, 44.542 ms] 7.643 ms (20.9%)
iast 44.039 ms [43.67 ms, 44.407 ms] 7.534 ms (20.6%)
profiling 46.707 ms [46.292 ms, 47.121 ms] 10.202 ms (27.9%)
tracing 45.234 ms [44.842 ms, 45.626 ms] 8.729 ms (23.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.511 ms) : 4454, 4569
.   : milestone, 4511,
iast (9.507 ms) : 9344, 9671
.   : milestone, 9507,
iast_FULL (15.653 ms) : 15338, 15968
.   : milestone, 15653,
iast_GLOBAL (10.845 ms) : 10653, 11036
.   : milestone, 10845,
profiling (9.005 ms) : 8856, 9155
.   : milestone, 9005,
tracing (7.913 ms) : 7798, 8027
.   : milestone, 7913,
section candidate
no_agent (4.307 ms) : 4253, 4362
.   : milestone, 4307,
iast (9.303 ms) : 9152, 9454
.   : milestone, 9303,
iast_FULL (14.362 ms) : 14080, 14645
.   : milestone, 14362,
iast_GLOBAL (11.254 ms) : 11051, 11457
.   : milestone, 11254,
profiling (9.094 ms) : 8952, 9235
.   : milestone, 9094,
tracing (7.689 ms) : 7568, 7810
.   : milestone, 7689,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.511 ms [4.454 ms, 4.569 ms] -
iast 9.507 ms [9.344 ms, 9.671 ms] 4.996 ms (110.7%)
iast_FULL 15.653 ms [15.338 ms, 15.968 ms] 11.142 ms (247.0%)
iast_GLOBAL 10.845 ms [10.653 ms, 11.036 ms] 6.333 ms (140.4%)
profiling 9.005 ms [8.856 ms, 9.155 ms] 4.494 ms (99.6%)
tracing 7.913 ms [7.798 ms, 8.027 ms] 3.401 ms (75.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.307 ms [4.253 ms, 4.362 ms] -
iast 9.303 ms [9.152 ms, 9.454 ms] 4.995 ms (116.0%)
iast_FULL 14.362 ms [14.08 ms, 14.645 ms] 10.055 ms (233.4%)
iast_GLOBAL 11.254 ms [11.051 ms, 11.457 ms] 6.947 ms (161.3%)
profiling 9.094 ms [8.952 ms, 9.235 ms] 4.786 ms (111.1%)
tracing 7.689 ms [7.568 ms, 7.81 ms] 3.382 ms (78.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/context-otel
git_commit_date 1759910850 1759916448
git_commit_sha 60a3b9d 1c997f9
release_version 1.55.0-SNAPSHOT~60a3b9d880 1.55.0-SNAPSHOT~1c997f9322
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1759918470 1759918470
ci_job_id 1168954959 1168954959
ci_pipeline_id 78698665 78698665
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-dl9o7wmr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-dl9o7wmr 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (3.68 ms) : 3464, 3897
.   : milestone, 3680,
iast (2.207 ms) : 2144, 2270
.   : milestone, 2207,
iast_GLOBAL (2.25 ms) : 2186, 2314
.   : milestone, 2250,
profiling (2.05 ms) : 1998, 2101
.   : milestone, 2050,
tracing (2.022 ms) : 1973, 2072
.   : milestone, 2022,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (3.751 ms) : 3534, 3969
.   : milestone, 3751,
iast (2.204 ms) : 2140, 2267
.   : milestone, 2204,
iast_GLOBAL (2.249 ms) : 2186, 2313
.   : milestone, 2249,
profiling (2.044 ms) : 1993, 2095
.   : milestone, 2044,
tracing (2.027 ms) : 1977, 2077
.   : milestone, 2027,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 3.68 ms [3.464 ms, 3.897 ms] 2.207 ms (149.7%)
iast 2.207 ms [2.144 ms, 2.27 ms] 733.317 µs (49.8%)
iast_GLOBAL 2.25 ms [2.186 ms, 2.314 ms] 776.47 µs (52.7%)
profiling 2.05 ms [1.998 ms, 2.101 ms] 575.985 µs (39.1%)
tracing 2.022 ms [1.973 ms, 2.072 ms] 548.701 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 3.751 ms [3.534 ms, 3.969 ms] 2.278 ms (154.7%)
iast 2.204 ms [2.14 ms, 2.267 ms] 731.109 µs (49.6%)
iast_GLOBAL 2.249 ms [2.186 ms, 2.313 ms] 776.528 µs (52.7%)
profiling 2.044 ms [1.993 ms, 2.095 ms] 571.406 µs (38.8%)
tracing 2.027 ms [1.977 ms, 2.077 ms] 554.749 µs (37.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~1c997f9322, baseline=1.55.0-SNAPSHOT~60a3b9d880
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.419 s) : 15419000, 15419000
.   : milestone, 15419000,
appsec (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
iast (18.537 s) : 18537000, 18537000
.   : milestone, 18537000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
.   : milestone, 18053000,
profiling (14.885 s) : 14885000, 14885000
.   : milestone, 14885000,
tracing (15.062 s) : 15062000, 15062000
.   : milestone, 15062000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
.   : milestone, 14975000,
appsec (15.059 s) : 15059000, 15059000
.   : milestone, 15059000,
iast (18.468 s) : 18468000, 18468000
.   : milestone, 18468000,
iast_GLOBAL (17.633 s) : 17633000, 17633000
.   : milestone, 17633000,
profiling (15.739 s) : 15739000, 15739000
.   : milestone, 15739000,
tracing (14.865 s) : 14865000, 14865000
.   : milestone, 14865000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.419 s [15.419 s, 15.419 s] -
appsec 15.089 s [15.089 s, 15.089 s] -330.0 ms (-2.1%)
iast 18.537 s [18.537 s, 18.537 s] 3.118 s (20.2%)
iast_GLOBAL 18.053 s [18.053 s, 18.053 s] 2.634 s (17.1%)
profiling 14.885 s [14.885 s, 14.885 s] -534.0 ms (-3.5%)
tracing 15.062 s [15.062 s, 15.062 s] -357.0 ms (-2.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.975 s [14.975 s, 14.975 s] -
appsec 15.059 s [15.059 s, 15.059 s] 84.0 ms (0.6%)
iast 18.468 s [18.468 s, 18.468 s] 3.493 s (23.3%)
iast_GLOBAL 17.633 s [17.633 s, 17.633 s] 2.658 s (17.7%)
profiling 15.739 s [15.739 s, 15.739 s] 764.0 ms (5.1%)
tracing 14.865 s [14.865 s, 14.865 s] -110.0 ms (-0.7%)

@amarziali amarziali force-pushed the andrea.marziali/context-otel branch from 3245121 to 9c634ef Compare October 8, 2025 08:35
mcculls
mcculls reviewed Oct 8, 2025
View reviewed changes
...agent/agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/context/OtelContext.java Outdated
// fall-through and check for non-datadog span data
} else if (OTEL_CONTEXT_ROOT_SPAN_KEY.equals(key.toString())) {
AgentSpan span = AgentSpan.fromContext(delegate);
if (span != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the same span.isValid() check here for consistency?

Copy link
Contributor Author

@amarziali amarziali Oct 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure about this one but I'm happy that you reacted on this one. Perhaps yes if we want to have the caller method to be consistent about the returned value in all cases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 1c997f9

@amarziali amarziali marked this pull request as ready for review October 8, 2025 09:41
@amarziali amarziali requested review from a team as code owners October 8, 2025 09:41
@amarziali amarziali requested review from cecile75 and removed request for a team October 8, 2025 09:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@amarziali amarziali added type: enhancement Enhancements and improvements inst: opentelemetry OpenTelemetry instrumentation labels Oct 8, 2025
@amarziali amarziali requested a review from mcculls October 8, 2025 11:58
mcculls
mcculls approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@cecile75 cecile75 Awaiting requested review from cecile75 cecile75 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

Assignees
No one assigned
Labels
inst: opentelemetry OpenTelemetry instrumentation type: enhancement Enhancements and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @mcculls