-
Notifications
You must be signed in to change notification settings - Fork 313
DSMON-886: add Sqs spring messaging context propagation support #9662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🎯 Code Coverage 🔗 Commit SHA: d9114a8 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018490
Total [baseline] (10.639 s) : 0, 10639385
Agent [candidate] (1.019 s) : 0, 1018688
Total [candidate] (10.752 s) : 0, 10751793
section appsec
Agent [baseline] (1.196 s) : 0, 1196201
Total [baseline] (11.102 s) : 0, 11101960
Agent [candidate] (1.193 s) : 0, 1192774
Total [candidate] (11.061 s) : 0, 11061228
section iast
Agent [baseline] (1.163 s) : 0, 1162970
Total [baseline] (11.21 s) : 0, 11210213
Agent [candidate] (1.16 s) : 0, 1159684
Total [candidate] (10.995 s) : 0, 10994531
section profiling
Agent [baseline] (1.164 s) : 0, 1164494
Total [baseline] (11.064 s) : 0, 11064424
Agent [candidate] (1.168 s) : 0, 1168161
Total [candidate] (11.077 s) : 0, 11077030
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.492 ms) : 0, 1492
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (693.768 ms) : 0, 693768
BytebuddyAgent [candidate] (694.259 ms) : 0, 694259
GlobalTracer [baseline] (242.251 ms) : 0, 242251
GlobalTracer [candidate] (242.104 ms) : 0, 242104
AppSec [baseline] (32.449 ms) : 0, 32449
AppSec [candidate] (32.429 ms) : 0, 32429
Debugger [baseline] (6.424 ms) : 0, 6424
Debugger [candidate] (6.389 ms) : 0, 6389
Remote Config [baseline] (705.644 µs) : 0, 706
Remote Config [candidate] (704.357 µs) : 0, 704
Telemetry [baseline] (9.354 ms) : 0, 9354
Telemetry [candidate] (9.474 ms) : 0, 9474
Flare Poller [baseline] (10.929 ms) : 0, 10929
Flare Poller [candidate] (10.713 ms) : 0, 10713
section appsec
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (719.232 ms) : 0, 719232
BytebuddyAgent [candidate] (716.883 ms) : 0, 716883
GlobalTracer [baseline] (234.65 ms) : 0, 234650
GlobalTracer [candidate] (233.629 ms) : 0, 233629
IAST [baseline] (24.968 ms) : 0, 24968
IAST [candidate] (24.867 ms) : 0, 24867
AppSec [baseline] (175.348 ms) : 0, 175348
AppSec [candidate] (175.756 ms) : 0, 175756
Debugger [baseline] (6.162 ms) : 0, 6162
Debugger [candidate] (6.137 ms) : 0, 6137
Remote Config [baseline] (634.408 µs) : 0, 634
Remote Config [candidate] (645.481 µs) : 0, 645
Telemetry [baseline] (8.527 ms) : 0, 8527
Telemetry [candidate] (8.45 ms) : 0, 8450
Flare Poller [baseline] (4.0 ms) : 0, 4000
Flare Poller [candidate] (3.948 ms) : 0, 3948
section iast
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (823.839 ms) : 0, 823839
BytebuddyAgent [candidate] (820.926 ms) : 0, 820926
GlobalTracer [baseline] (233.966 ms) : 0, 233966
GlobalTracer [candidate] (233.694 ms) : 0, 233694
IAST [baseline] (27.197 ms) : 0, 27197
IAST [candidate] (27.324 ms) : 0, 27324
AppSec [baseline] (35.171 ms) : 0, 35171
AppSec [candidate] (35.086 ms) : 0, 35086
Debugger [baseline] (6.25 ms) : 0, 6250
Debugger [candidate] (6.151 ms) : 0, 6151
Remote Config [baseline] (624.936 µs) : 0, 625
Remote Config [candidate] (601.624 µs) : 0, 602
Telemetry [baseline] (8.705 ms) : 0, 8705
Telemetry [candidate] (8.676 ms) : 0, 8676
Flare Poller [baseline] (4.231 ms) : 0, 4231
Flare Poller [candidate] (4.242 ms) : 0, 4242
section profiling
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (723.426 ms) : 0, 723426
BytebuddyAgent [candidate] (724.292 ms) : 0, 724292
GlobalTracer [baseline] (218.49 ms) : 0, 218490
GlobalTracer [candidate] (218.81 ms) : 0, 218810
AppSec [baseline] (32.67 ms) : 0, 32670
AppSec [candidate] (32.645 ms) : 0, 32645
Debugger [baseline] (7.265 ms) : 0, 7265
Debugger [candidate] (6.481 ms) : 0, 6481
Remote Config [baseline] (708.612 µs) : 0, 709
Remote Config [candidate] (688.966 µs) : 0, 689
Telemetry [baseline] (15.924 ms) : 0, 15924
Telemetry [candidate] (16.822 ms) : 0, 16822
Flare Poller [baseline] (4.27 ms) : 0, 4270
Flare Poller [candidate] (4.231 ms) : 0, 4231
ProfilingAgent [baseline] (107.559 ms) : 0, 107559
ProfilingAgent [candidate] (108.963 ms) : 0, 108963
Profiling [baseline] (108.268 ms) : 0, 108268
Profiling [candidate] (110.654 ms) : 0, 110654
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024355
Total [baseline] (8.702 s) : 0, 8701829
Agent [candidate] (1.025 s) : 0, 1024676
Total [candidate] (8.654 s) : 0, 8653975
section iast
Agent [baseline] (1.152 s) : 0, 1152401
Total [baseline] (9.3 s) : 0, 9299549
Agent [candidate] (1.151 s) : 0, 1150901
Total [candidate] (9.294 s) : 0, 9293942
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (700.488 ms) : 0, 700488
BytebuddyAgent [candidate] (699.268 ms) : 0, 699268
GlobalTracer [baseline] (242.092 ms) : 0, 242092
GlobalTracer [candidate] (243.438 ms) : 0, 243438
AppSec [baseline] (32.425 ms) : 0, 32425
AppSec [candidate] (32.618 ms) : 0, 32618
Debugger [baseline] (6.427 ms) : 0, 6427
Debugger [candidate] (6.472 ms) : 0, 6472
Remote Config [baseline] (692.037 µs) : 0, 692
Remote Config [candidate] (689.065 µs) : 0, 689
Telemetry [baseline] (9.237 ms) : 0, 9237
Telemetry [candidate] (9.378 ms) : 0, 9378
Flare Poller [baseline] (10.208 ms) : 0, 10208
Flare Poller [candidate] (10.102 ms) : 0, 10102
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (815.943 ms) : 0, 815943
BytebuddyAgent [candidate] (815.244 ms) : 0, 815244
GlobalTracer [baseline] (232.154 ms) : 0, 232154
GlobalTracer [candidate] (232.077 ms) : 0, 232077
IAST [baseline] (26.731 ms) : 0, 26731
IAST [candidate] (26.528 ms) : 0, 26528
AppSec [baseline] (35.084 ms) : 0, 35084
AppSec [candidate] (34.888 ms) : 0, 34888
Debugger [baseline] (6.166 ms) : 0, 6166
Debugger [candidate] (6.061 ms) : 0, 6061
Remote Config [baseline] (613.216 µs) : 0, 613
Remote Config [candidate] (597.225 µs) : 0, 597
Telemetry [baseline] (8.641 ms) : 0, 8641
Telemetry [candidate] (8.547 ms) : 0, 8547
Flare Poller [baseline] (4.251 ms) : 0, 4251
Flare Poller [candidate] (4.173 ms) : 0, 4173
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (37.428 ms) : 37128, 37728
. : milestone, 37428,
appsec (49.047 ms) : 48619, 49476
. : milestone, 49047,
code_origins (43.298 ms) : 42938, 43658
. : milestone, 43298,
iast (44.142 ms) : 43773, 44512
. : milestone, 44142,
profiling (47.444 ms) : 46998, 47891
. : milestone, 47444,
tracing (45.105 ms) : 44729, 45481
. : milestone, 45105,
section candidate
no_agent (36.617 ms) : 36319, 36915
. : milestone, 36617,
appsec (49.148 ms) : 48709, 49588
. : milestone, 49148,
code_origins (45.189 ms) : 44805, 45572
. : milestone, 45189,
iast (45.72 ms) : 45326, 46113
. : milestone, 45720,
profiling (49.169 ms) : 48730, 49608
. : milestone, 49169,
tracing (44.371 ms) : 43985, 44757
. : milestone, 44371,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (4.357 ms) : 4308, 4406
. : milestone, 4357,
iast (9.207 ms) : 9057, 9357
. : milestone, 9207,
iast_FULL (14.156 ms) : 13869, 14443
. : milestone, 14156,
iast_GLOBAL (10.601 ms) : 10416, 10786
. : milestone, 10601,
profiling (9.421 ms) : 9263, 9580
. : milestone, 9421,
tracing (8.103 ms) : 7979, 8227
. : milestone, 8103,
section candidate
no_agent (4.293 ms) : 4244, 4341
. : milestone, 4293,
iast (9.725 ms) : 9563, 9887
. : milestone, 9725,
iast_FULL (14.187 ms) : 13901, 14473
. : milestone, 14187,
iast_GLOBAL (11.114 ms) : 10915, 11312
. : milestone, 11114,
profiling (8.716 ms) : 8574, 8858
. : milestone, 8716,
tracing (7.601 ms) : 7489, 7713
. : milestone, 7601,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.695 ms) : 3475, 3915
. : milestone, 3695,
iast (2.217 ms) : 2153, 2280
. : milestone, 2217,
iast_GLOBAL (2.249 ms) : 2185, 2312
. : milestone, 2249,
profiling (2.494 ms) : 2323, 2665
. : milestone, 2494,
tracing (2.033 ms) : 1984, 2083
. : milestone, 2033,
section candidate
no_agent (1.48 ms) : 1468, 1492
. : milestone, 1480,
appsec (3.647 ms) : 3433, 3861
. : milestone, 3647,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.271 ms) : 2206, 2336
. : milestone, 2271,
profiling (2.518 ms) : 2344, 2691
. : milestone, 2518,
tracing (2.044 ms) : 1994, 2095
. : milestone, 2044,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d9114a85a5, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (15.575 s) : 15575000, 15575000
. : milestone, 15575000,
appsec (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
iast (18.781 s) : 18781000, 18781000
. : milestone, 18781000,
iast_GLOBAL (17.975 s) : 17975000, 17975000
. : milestone, 17975000,
profiling (15.478 s) : 15478000, 15478000
. : milestone, 15478000,
tracing (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
section candidate
no_agent (15.546 s) : 15546000, 15546000
. : milestone, 15546000,
appsec (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
iast (18.537 s) : 18537000, 18537000
. : milestone, 18537000,
iast_GLOBAL (18.108 s) : 18108000, 18108000
. : milestone, 18108000,
profiling (15.39 s) : 15390000, 15390000
. : milestone, 15390000,
tracing (15.218 s) : 15218000, 15218000
. : milestone, 15218000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review as we discussed it internally already
...e/instrumentation/springsqs/AbstractMessagingMessageConverterToMessagingInstrumentation.java
Outdated
Show resolved
Hide resolved
dd-java-agent/instrumentation/spring/spring-sqs-3.0/build.gradle
Outdated
Show resolved
Hide resolved
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Adds support for context propagation when using SQS v2 with spring messaging.
Motivation
Support ticket opened by customer with context propagation being broken for Data Streams monitoring.
Additional Notes
Trace context was working thanks to this PR
However, for Data Streams, it's important for the downstream checkpoint to be the direct child of the upstream checkpoint.
This PR fixes that with a continuation on an SQS message, which is then continued on a spring message.
This is very similar to the spring-rabbitmq fix.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]