-
Notifications
You must be signed in to change notification settings - Fork 312
Inferred Routes and Resource Renaming: new APM trace metrics tag #9553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi! 👋 Looks like you updated a Git Submodule.
|
746bf88
to
b3676e3
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
🎯 Code Coverage 🔗 Commit SHA: 97ee9c3 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1018347
Total [baseline] (8.674 s) : 0, 8673598
Agent [candidate] (1.018 s) : 0, 1017668
Total [candidate] (8.673 s) : 0, 8673078
section iast
Agent [baseline] (1.151 s) : 0, 1150572
Total [baseline] (9.317 s) : 0, 9317113
Agent [candidate] (1.15 s) : 0, 1149985
Total [candidate] (9.307 s) : 0, 9306787
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (694.156 ms) : 0, 694156
BytebuddyAgent [candidate] (693.044 ms) : 0, 693044
GlobalTracer [baseline] (241.895 ms) : 0, 241895
GlobalTracer [candidate] (241.687 ms) : 0, 241687
AppSec [baseline] (32.271 ms) : 0, 32271
AppSec [candidate] (32.213 ms) : 0, 32213
Debugger [baseline] (6.424 ms) : 0, 6424
Debugger [candidate] (6.406 ms) : 0, 6406
Remote Config [baseline] (714.434 µs) : 0, 714
Remote Config [candidate] (703.372 µs) : 0, 703
Telemetry [baseline] (9.339 ms) : 0, 9339
Telemetry [candidate] (9.38 ms) : 0, 9380
Flare Poller [baseline] (10.783 ms) : 0, 10783
Flare Poller [candidate] (11.642 ms) : 0, 11642
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (815.18 ms) : 0, 815180
BytebuddyAgent [candidate] (814.524 ms) : 0, 814524
GlobalTracer [baseline] (231.635 ms) : 0, 231635
GlobalTracer [candidate] (231.718 ms) : 0, 231718
AppSec [baseline] (35.09 ms) : 0, 35090
AppSec [candidate] (34.886 ms) : 0, 34886
Debugger [baseline] (6.108 ms) : 0, 6108
Debugger [candidate] (6.164 ms) : 0, 6164
Remote Config [baseline] (615.035 µs) : 0, 615
Remote Config [candidate] (607.959 µs) : 0, 608
Telemetry [baseline] (8.591 ms) : 0, 8591
Telemetry [candidate] (8.622 ms) : 0, 8622
Flare Poller [baseline] (4.233 ms) : 0, 4233
Flare Poller [candidate] (4.281 ms) : 0, 4281
IAST [baseline] (26.393 ms) : 0, 26393
IAST [candidate] (26.479 ms) : 0, 26479
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017505
Total [baseline] (10.724 s) : 0, 10724433
Agent [candidate] (1.018 s) : 0, 1017644
Total [candidate] (10.787 s) : 0, 10786761
section appsec
Agent [baseline] (1.195 s) : 0, 1194994
Total [baseline] (11.005 s) : 0, 11004594
Agent [candidate] (1.195 s) : 0, 1194592
Total [candidate] (11.047 s) : 0, 11047381
section iast
Agent [baseline] (1.154 s) : 0, 1154366
Total [baseline] (10.979 s) : 0, 10979303
Agent [candidate] (1.162 s) : 0, 1162154
Total [candidate] (11.055 s) : 0, 11054872
section profiling
Agent [baseline] (1.161 s) : 0, 1161389
Total [baseline] (10.986 s) : 0, 10986058
Agent [candidate] (1.164 s) : 0, 1163647
Total [candidate] (11.083 s) : 0, 11082602
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (694.219 ms) : 0, 694219
BytebuddyAgent [candidate] (694.153 ms) : 0, 694153
GlobalTracer [baseline] (242.071 ms) : 0, 242071
GlobalTracer [candidate] (242.068 ms) : 0, 242068
AppSec [baseline] (32.395 ms) : 0, 32395
AppSec [candidate] (32.266 ms) : 0, 32266
Debugger [baseline] (6.39 ms) : 0, 6390
Debugger [candidate] (6.408 ms) : 0, 6408
Remote Config [baseline] (694.594 µs) : 0, 695
Remote Config [candidate] (700.133 µs) : 0, 700
Telemetry [baseline] (9.307 ms) : 0, 9307
Telemetry [candidate] (9.297 ms) : 0, 9297
Flare Poller [baseline] (9.633 ms) : 0, 9633
Flare Poller [candidate] (10.099 ms) : 0, 10099
section appsec
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (718.885 ms) : 0, 718885
BytebuddyAgent [candidate] (717.847 ms) : 0, 717847
GlobalTracer [baseline] (234.509 ms) : 0, 234509
GlobalTracer [candidate] (234.965 ms) : 0, 234965
IAST [baseline] (24.725 ms) : 0, 24725
IAST [candidate] (24.694 ms) : 0, 24694
AppSec [baseline] (175.122 ms) : 0, 175122
AppSec [candidate] (175.243 ms) : 0, 175243
Debugger [baseline] (6.093 ms) : 0, 6093
Debugger [candidate] (6.145 ms) : 0, 6145
Remote Config [baseline] (636.192 µs) : 0, 636
Remote Config [candidate] (644.769 µs) : 0, 645
Telemetry [baseline] (8.433 ms) : 0, 8433
Telemetry [candidate] (8.489 ms) : 0, 8489
Flare Poller [baseline] (3.96 ms) : 0, 3960
Flare Poller [candidate] (3.949 ms) : 0, 3949
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (818.172 ms) : 0, 818172
BytebuddyAgent [candidate] (822.89 ms) : 0, 822890
GlobalTracer [baseline] (231.851 ms) : 0, 231851
GlobalTracer [candidate] (233.836 ms) : 0, 233836
IAST [baseline] (26.483 ms) : 0, 26483
IAST [candidate] (26.676 ms) : 0, 26676
AppSec [baseline] (35.379 ms) : 0, 35379
AppSec [candidate] (35.774 ms) : 0, 35774
Debugger [baseline] (6.145 ms) : 0, 6145
Debugger [candidate] (6.252 ms) : 0, 6252
Remote Config [baseline] (610.6 µs) : 0, 611
Remote Config [candidate] (628.19 µs) : 0, 628
Telemetry [baseline] (8.565 ms) : 0, 8565
Telemetry [candidate] (8.815 ms) : 0, 8815
Flare Poller [baseline] (4.257 ms) : 0, 4257
Flare Poller [candidate] (4.255 ms) : 0, 4255
section profiling
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (721.027 ms) : 0, 721027
BytebuddyAgent [candidate] (721.227 ms) : 0, 721227
GlobalTracer [baseline] (217.754 ms) : 0, 217754
GlobalTracer [candidate] (218.521 ms) : 0, 218521
AppSec [baseline] (32.775 ms) : 0, 32775
AppSec [candidate] (32.735 ms) : 0, 32735
Debugger [baseline] (6.466 ms) : 0, 6466
Debugger [candidate] (6.489 ms) : 0, 6489
Remote Config [baseline] (1.519 ms) : 0, 1519
Remote Config [candidate] (692.008 µs) : 0, 692
Telemetry [baseline] (15.355 ms) : 0, 15355
Telemetry [candidate] (16.709 ms) : 0, 16709
Flare Poller [baseline] (4.919 ms) : 0, 4919
Flare Poller [candidate] (4.169 ms) : 0, 4169
ProfilingAgent [baseline] (107.333 ms) : 0, 107333
ProfilingAgent [candidate] (109.12 ms) : 0, 109120
Profiling [baseline] (108.177 ms) : 0, 108177
Profiling [candidate] (109.702 ms) : 0, 109702
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (37.29 ms) : 36981, 37599
. : milestone, 37290,
appsec (46.72 ms) : 46322, 47119
. : milestone, 46720,
code_origins (43.393 ms) : 43029, 43757
. : milestone, 43393,
iast (46.313 ms) : 45905, 46721
. : milestone, 46313,
profiling (50.638 ms) : 50157, 51119
. : milestone, 50638,
tracing (44.675 ms) : 44302, 45049
. : milestone, 44675,
section candidate
no_agent (37.307 ms) : 36997, 37617
. : milestone, 37307,
appsec (47.955 ms) : 47524, 48386
. : milestone, 47955,
code_origins (43.56 ms) : 43192, 43928
. : milestone, 43560,
iast (44.697 ms) : 44301, 45094
. : milestone, 44697,
profiling (48.717 ms) : 48261, 49172
. : milestone, 48717,
tracing (42.995 ms) : 42616, 43374
. : milestone, 42995,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (4.489 ms) : 4438, 4541
. : milestone, 4489,
iast (10.109 ms) : 9935, 10283
. : milestone, 10109,
iast_FULL (14.339 ms) : 14050, 14629
. : milestone, 14339,
iast_GLOBAL (10.889 ms) : 10681, 11097
. : milestone, 10889,
profiling (8.37 ms) : 8233, 8507
. : milestone, 8370,
tracing (7.806 ms) : 7695, 7917
. : milestone, 7806,
section candidate
no_agent (4.283 ms) : 4235, 4332
. : milestone, 4283,
iast (10.104 ms) : 9930, 10278
. : milestone, 10104,
iast_FULL (14.1 ms) : 13817, 14383
. : milestone, 14100,
iast_GLOBAL (10.613 ms) : 10425, 10800
. : milestone, 10613,
profiling (8.682 ms) : 8525, 8840
. : milestone, 8682,
tracing (7.915 ms) : 7792, 8039
. : milestone, 7915,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.639 ms) : 3427, 3851
. : milestone, 3639,
iast (2.215 ms) : 2151, 2279
. : milestone, 2215,
iast_GLOBAL (2.263 ms) : 2198, 2327
. : milestone, 2263,
profiling (2.078 ms) : 2025, 2132
. : milestone, 2078,
tracing (2.04 ms) : 1990, 2090
. : milestone, 2040,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.661 ms) : 3445, 3876
. : milestone, 3661,
iast (2.222 ms) : 2158, 2286
. : milestone, 2222,
iast_GLOBAL (2.255 ms) : 2191, 2319
. : milestone, 2255,
profiling (2.09 ms) : 2037, 2144
. : milestone, 2090,
tracing (2.03 ms) : 1981, 2080
. : milestone, 2030,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~97ee9c3e1e, baseline=1.55.0-SNAPSHOT~295f7bf5b4
dateFormat X
axisFormat %s
section baseline
no_agent (15.507 s) : 15507000, 15507000
. : milestone, 15507000,
appsec (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
iast (18.501 s) : 18501000, 18501000
. : milestone, 18501000,
iast_GLOBAL (18.127 s) : 18127000, 18127000
. : milestone, 18127000,
profiling (15.448 s) : 15448000, 15448000
. : milestone, 15448000,
tracing (15.344 s) : 15344000, 15344000
. : milestone, 15344000,
section candidate
no_agent (15.564 s) : 15564000, 15564000
. : milestone, 15564000,
appsec (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
iast (18.475 s) : 18475000, 18475000
. : milestone, 18475000,
iast_GLOBAL (18.099 s) : 18099000, 18099000
. : milestone, 18099000,
profiling (15.297 s) : 15297000, 15297000
. : milestone, 15297000,
tracing (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
|
b3676e3
to
7b7ad49
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
7b7ad49
to
f0b3d92
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
1 similar comment
Hi! 👋 Looks like you updated a Git Submodule.
|
7506773
to
c4dcdb5
Compare
Hi! 👋 Looks like you updated a Git Submodule.
|
Signed-off-by: sezen.leblay <[email protected]>
c4dcdb5
to
5ff30b6
Compare
Signed-off-by: sezen.leblay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a first pass. There are some comments to address especially the one concerning the design. In particular, the tagging engine should be moved away from the metrics since concerning mostly the span (tracing). Moving to tagPostProcessor is a first step.
I will do another pass once the first set of comments are resolved
dd-trace-core/src/main/java/datadog/trace/common/metrics/MetricKey.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/core/tagprocessor/HttpEndpointTagging.java
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/common/metrics/HttpEndpointTagging.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/core/tagprocessor/HttpEndpointTagging.java
Show resolved
Hide resolved
dd-trace-core/src/test/groovy/datadog/trace/core/tagprocessor/HttpEndpointTaggingTest.groovy
Show resolved
Hide resolved
dd-trace-core/src/test/java/datadog/trace/common/metrics/MetricKeyTest.java
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/common/metrics/HttpEndpointTagging.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/common/metrics/HttpEndpointTagging.java
Outdated
Show resolved
Hide resolved
dd-trace-core/src/main/java/datadog/trace/common/metrics/HttpEndpointTagging.java
Outdated
Show resolved
Hide resolved
eb38ab8
to
b3ffd63
Compare
Signed-off-by: sezen.leblay <[email protected]>
b3ffd63
to
3f778ee
Compare
Signed-off-by: sezen.leblay <[email protected]>
Signed-off-by: sezen.leblay <[email protected]>
Is it possible to increase this coverage with more tests? :) |
What Does This Do
Adds the new http.endpoint tag and modifies the cases where http.route is utilized accordingly
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58611