Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` #8296

mhlidd · 2025-01-28T19:10:32Z

What Does This Do

Creates a new parser to parse DD_TAGS by prioritizing comma separated K/V pairs, and falling back to space separated K/V pairs. See this reference doc for how it is already implemented in dd-trace-go.

Additionally, if both DD_SERVICE and the service key in DD_TAGS are set, this PR prioritizes DD_SERVICE as the service name. This effectively is the same as not setting service in DD_TAGS. However, if a customer still wanted to manually override the service name with setTag, the service name would still be updated by the TagInterceptor.

Motivation

Our goal is to make the implementation of configuration variables consistent for all languages as part of the config consistency effort listed in the following RFC.

Additional Notes

Tested with additional and existing unit tests, as well as parametric and weblog tests.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMAPI-1039

pr-commenter · 2025-01-28T19:53:26Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/dd_tags
git_commit_date	1738260668	1738262341
git_commit_sha	`2b2be1e`	`798b8d8`
release_version	1.46.0-SNAPSHOT~2b2be1ef8d	1.46.0-SNAPSHOT~798b8d8c16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738264730	1738264730
ci_job_id	788083552	788083552
ci_pipeline_id	54495557	54495557
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-k9ef9rs-project-304-concurrent-2-0091tnz2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-k9ef9rs-project-304-concurrent-2-0091tnz2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048363
Total [baseline] (10.434 s) : 0, 10434237
Agent [candidate] (1.042 s) : 0, 1041925
Total [candidate] (10.538 s) : 0, 10538479
section appsec
Agent [baseline] (1.181 s) : 0, 1180815
Total [baseline] (10.783 s) : 0, 10782710
Agent [candidate] (1.183 s) : 0, 1182869
Total [candidate] (10.82 s) : 0, 10820370
section iast
Agent [baseline] (1.166 s) : 0, 1166215
Total [baseline] (10.977 s) : 0, 10977399
Agent [candidate] (1.166 s) : 0, 1166496
Total [candidate] (10.945 s) : 0, 10944880
section profiling
Agent [baseline] (1.258 s) : 0, 1258199
Total [baseline] (10.929 s) : 0, 10929110
Agent [candidate] (1.259 s) : 0, 1258636
Total [candidate] (10.852 s) : 0, 10851522

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.048 s	-
Agent	appsec	1.181 s	132.452 ms (12.6%)
Agent	iast	1.166 s	117.852 ms (11.2%)
Agent	profiling	1.258 s	209.836 ms (20.0%)
Total	tracing	10.434 s	-
Total	appsec	10.783 s	348.473 ms (3.3%)
Total	iast	10.977 s	543.163 ms (5.2%)
Total	profiling	10.929 s	494.873 ms (4.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.183 s	140.944 ms (13.5%)
Agent	iast	1.166 s	124.571 ms (12.0%)
Agent	profiling	1.259 s	216.711 ms (20.8%)
Total	tracing	10.538 s	-
Total	appsec	10.82 s	281.891 ms (2.7%)
Total	iast	10.945 s	406.402 ms (3.9%)
Total	profiling	10.852 s	313.043 ms (3.0%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.061 ms) : 0, 720061
BytebuddyAgent [candidate] (716.329 ms) : 0, 716329
GlobalTracer [baseline] (242.381 ms) : 0, 242381
GlobalTracer [candidate] (240.462 ms) : 0, 240462
AppSec [baseline] (55.993 ms) : 0, 55993
AppSec [candidate] (55.526 ms) : 0, 55526
Remote Config [baseline] (719.024 µs) : 0, 719
Remote Config [candidate] (714.05 µs) : 0, 714
Telemetry [baseline] (13.742 ms) : 0, 13742
Telemetry [candidate] (13.633 ms) : 0, 13633
section appsec
BytebuddyAgent [baseline] (732.978 ms) : 0, 732978
BytebuddyAgent [candidate] (733.659 ms) : 0, 733659
GlobalTracer [baseline] (237.524 ms) : 0, 237524
GlobalTracer [candidate] (237.974 ms) : 0, 237974
IAST [baseline] (21.562 ms) : 0, 21562
IAST [candidate] (21.607 ms) : 0, 21607
AppSec [baseline] (175.233 ms) : 0, 175233
AppSec [candidate] (176.292 ms) : 0, 176292
Remote Config [baseline] (663.051 µs) : 0, 663
Remote Config [candidate] (654.411 µs) : 0, 654
Telemetry [baseline] (8.35 ms) : 0, 8350
Telemetry [candidate] (8.292 ms) : 0, 8292
section iast
BytebuddyAgent [baseline] (831.533 ms) : 0, 831533
BytebuddyAgent [candidate] (832.502 ms) : 0, 832502
GlobalTracer [baseline] (230.519 ms) : 0, 230519
GlobalTracer [candidate] (230.411 ms) : 0, 230411
IAST [baseline] (23.881 ms) : 0, 23881
IAST [candidate] (26.128 ms) : 0, 26128
AppSec [baseline] (55.596 ms) : 0, 55596
AppSec [candidate] (52.842 ms) : 0, 52842
Remote Config [baseline] (612.745 µs) : 0, 613
Remote Config [candidate] (613.746 µs) : 0, 614
Telemetry [baseline] (8.783 ms) : 0, 8783
Telemetry [candidate] (8.713 ms) : 0, 8713
section profiling
BytebuddyAgent [baseline] (704.012 ms) : 0, 704012
BytebuddyAgent [candidate] (706.331 ms) : 0, 706331
GlobalTracer [baseline] (351.08 ms) : 0, 351080
GlobalTracer [candidate] (351.172 ms) : 0, 351172
AppSec [baseline] (55.194 ms) : 0, 55194
AppSec [candidate] (54.032 ms) : 0, 54032
Remote Config [baseline] (702.52 µs) : 0, 703
Remote Config [candidate] (696.43 µs) : 0, 696
Telemetry [baseline] (8.95 ms) : 0, 8950
Telemetry [candidate] (8.851 ms) : 0, 8851
ProfilingAgent [baseline] (96.122 ms) : 0, 96122
ProfilingAgent [candidate] (95.222 ms) : 0, 95222
Profiling [baseline] (96.146 ms) : 0, 96146
Profiling [candidate] (95.246 ms) : 0, 95246

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039543
Total [baseline] (8.66 s) : 0, 8659959
Agent [candidate] (1.036 s) : 0, 1036253
Total [candidate] (8.607 s) : 0, 8607001
section iast
Agent [baseline] (1.176 s) : 0, 1175913
Total [baseline] (9.246 s) : 0, 9245598
Agent [candidate] (1.165 s) : 0, 1165069
Total [candidate] (9.197 s) : 0, 9197057
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.167 s) : 0, 1167144
Total [baseline] (9.218 s) : 0, 9218056
Agent [candidate] (1.178 s) : 0, 1177903
Total [candidate] (9.196 s) : 0, 9196278
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1162683
Total [baseline] (9.236 s) : 0, 9235699
Agent [candidate] (1.162 s) : 0, 1162220
Total [candidate] (9.227 s) : 0, 9227493

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.04 s	-
Agent	iast	1.176 s	136.371 ms (13.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.167 s	127.601 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.163 s	123.141 ms (11.8%)
Total	tracing	8.66 s	-
Total	iast	9.246 s	585.638 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.218 s	558.097 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.236 s	575.74 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.036 s	-
Agent	iast	1.165 s	128.816 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.178 s	141.65 ms (13.7%)
Agent	iast_TELEMETRY_OFF	1.162 s	125.967 ms (12.2%)
Total	tracing	8.607 s	-
Total	iast	9.197 s	590.056 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.196 s	589.277 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.227 s	620.492 ms (7.2%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.106 ms) : 0, 717106
BytebuddyAgent [candidate] (712.205 ms) : 0, 712205
GlobalTracer [baseline] (240.59 ms) : 0, 240590
GlobalTracer [candidate] (239.329 ms) : 0, 239329
AppSec [baseline] (55.626 ms) : 0, 55626
AppSec [candidate] (55.941 ms) : 0, 55941
Remote Config [baseline] (711.46 µs) : 0, 711
Remote Config [candidate] (708.334 µs) : 0, 708
Telemetry [baseline] (10.11 ms) : 0, 10110
Telemetry [candidate] (12.873 ms) : 0, 12873
section iast
BytebuddyAgent [baseline] (838.812 ms) : 0, 838812
BytebuddyAgent [candidate] (830.851 ms) : 0, 830851
GlobalTracer [baseline] (232.225 ms) : 0, 232225
GlobalTracer [candidate] (229.912 ms) : 0, 229912
IAST [baseline] (26.577 ms) : 0, 26577
IAST [candidate] (24.069 ms) : 0, 24069
AppSec [baseline] (53.467 ms) : 0, 53467
AppSec [candidate] (55.588 ms) : 0, 55588
Remote Config [baseline] (618.323 µs) : 0, 618
Remote Config [candidate] (621.937 µs) : 0, 622
Telemetry [baseline] (8.81 ms) : 0, 8810
Telemetry [candidate] (8.762 ms) : 0, 8762
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.151 ms) : 0, 832151
BytebuddyAgent [candidate] (840.594 ms) : 0, 840594
GlobalTracer [baseline] (230.294 ms) : 0, 230294
GlobalTracer [candidate] (232.038 ms) : 0, 232038
IAST [baseline] (26.472 ms) : 0, 26472
IAST [candidate] (25.297 ms) : 0, 25297
AppSec [baseline] (53.457 ms) : 0, 53457
AppSec [candidate] (55.176 ms) : 0, 55176
Remote Config [baseline] (629.029 µs) : 0, 629
Remote Config [candidate] (623.911 µs) : 0, 624
Telemetry [baseline] (8.845 ms) : 0, 8845
Telemetry [candidate] (8.797 ms) : 0, 8797
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (828.55 ms) : 0, 828550
BytebuddyAgent [candidate] (828.999 ms) : 0, 828999
GlobalTracer [baseline] (230.682 ms) : 0, 230682
GlobalTracer [candidate] (229.462 ms) : 0, 229462
IAST [baseline] (24.407 ms) : 0, 24407
IAST [candidate] (24.28 ms) : 0, 24280
AppSec [baseline] (54.558 ms) : 0, 54558
AppSec [candidate] (55.044 ms) : 0, 55044
Remote Config [baseline] (613.002 µs) : 0, 613
Remote Config [candidate] (616.696 µs) : 0, 617
Telemetry [baseline] (8.578 ms) : 0, 8578
Telemetry [candidate] (8.599 ms) : 0, 8599

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-30T18:48:47	2025-01-30T18:55:54
git_branch	master	mhlidd/dd_tags
git_commit_date	1738260668	1738262341
git_commit_sha	`2b2be1e`	`798b8d8`
release_version	1.46.0-SNAPSHOT~2b2be1ef8d	1.46.0-SNAPSHOT~798b8d8c16
start_time	2025-01-30T18:48:33	2025-01-30T18:55:40

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738263715	1738263715
ci_job_id	788083553	788083553
ci_pipeline_id	54495557	54495557
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-vsoh-ty-project-304-concurrent-0-zfw3qtxu 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-vsoh-ty-project-304-concurrent-0-zfw3qtxu 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.369 ms) : 1350, 1389
.   : milestone, 1369,
appsec (1.755 ms) : 1732, 1778
.   : milestone, 1755,
appsec_no_iast (1.798 ms) : 1775, 1821
.   : milestone, 1798,
iast (1.535 ms) : 1509, 1561
.   : milestone, 1535,
profiling (1.518 ms) : 1494, 1542
.   : milestone, 1518,
tracing (1.501 ms) : 1477, 1526
.   : milestone, 1501,
section candidate
no_agent (1.36 ms) : 1341, 1380
.   : milestone, 1360,
appsec (1.777 ms) : 1752, 1802
.   : milestone, 1777,
appsec_no_iast (1.768 ms) : 1745, 1791
.   : milestone, 1768,
iast (1.519 ms) : 1495, 1543
.   : milestone, 1519,
profiling (1.57 ms) : 1546, 1594
.   : milestone, 1570,
tracing (1.49 ms) : 1465, 1515
.   : milestone, 1490,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.369 ms [1.35 ms, 1.389 ms]	-
appsec	1.755 ms [1.732 ms, 1.778 ms]	385.621 µs (28.2%)
appsec_no_iast	1.798 ms [1.775 ms, 1.821 ms]	428.789 µs (31.3%)
iast	1.535 ms [1.509 ms, 1.561 ms]	165.773 µs (12.1%)
profiling	1.518 ms [1.494 ms, 1.542 ms]	148.601 µs (10.9%)
tracing	1.501 ms [1.477 ms, 1.526 ms]	131.704 µs (9.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.36 ms [1.341 ms, 1.38 ms]	-
appsec	1.777 ms [1.752 ms, 1.802 ms]	416.892 µs (30.6%)
appsec_no_iast	1.768 ms [1.745 ms, 1.791 ms]	407.865 µs (30.0%)
iast	1.519 ms [1.495 ms, 1.543 ms]	158.648 µs (11.7%)
profiling	1.57 ms [1.546 ms, 1.594 ms]	209.458 µs (15.4%)
tracing	1.49 ms [1.465 ms, 1.515 ms]	129.754 µs (9.5%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
    dateFormat X
    axisFormat %s
section baseline
no_agent (379.394 µs) : 360, 399
.   : milestone, 379,
iast (513.741 µs) : 491, 537
.   : milestone, 514,
iast_FULL (751.767 µs) : 730, 774
.   : milestone, 752,
iast_GLOBAL (555.065 µs) : 534, 577
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (515.058 µs) : 492, 538
.   : milestone, 515,
iast_INACTIVE (467.86 µs) : 446, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (507.872 µs) : 485, 531
.   : milestone, 508,
tracing (462.273 µs) : 441, 483
.   : milestone, 462,
section candidate
no_agent (381.206 µs) : 360, 402
.   : milestone, 381,
iast (520.681 µs) : 497, 544
.   : milestone, 521,
iast_FULL (750.495 µs) : 728, 773
.   : milestone, 750,
iast_GLOBAL (565.618 µs) : 544, 588
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (521.297 µs) : 498, 544
.   : milestone, 521,
iast_INACTIVE (473.355 µs) : 452, 495
.   : milestone, 473,
iast_TELEMETRY_OFF (503.263 µs) : 480, 527
.   : milestone, 503,
tracing (454.503 µs) : 434, 475
.   : milestone, 455,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	379.394 µs [359.742 µs, 399.046 µs]	-
iast	513.741 µs [490.674 µs, 536.807 µs]	134.347 µs (35.4%)
iast_FULL	751.767 µs [729.816 µs, 773.719 µs]	372.374 µs (98.1%)
iast_GLOBAL	555.065 µs [533.538 µs, 576.592 µs]	175.671 µs (46.3%)
iast_HARDCODED_SECRET_DISABLED	515.058 µs [492.425 µs, 537.691 µs]	135.664 µs (35.8%)
iast_INACTIVE	467.86 µs [445.923 µs, 489.796 µs]	88.466 µs (23.3%)
iast_TELEMETRY_OFF	507.872 µs [484.636 µs, 531.109 µs]	128.479 µs (33.9%)
tracing	462.273 µs [441.354 µs, 483.192 µs]	82.879 µs (21.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.206 µs [360.239 µs, 402.174 µs]	-
iast	520.681 µs [497.177 µs, 544.185 µs]	139.475 µs (36.6%)
iast_FULL	750.495 µs [727.822 µs, 773.167 µs]	369.289 µs (96.9%)
iast_GLOBAL	565.618 µs [543.521 µs, 587.715 µs]	184.412 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED	521.297 µs [498.143 µs, 544.452 µs]	140.091 µs (36.7%)
iast_INACTIVE	473.355 µs [451.531 µs, 495.18 µs]	92.149 µs (24.2%)
iast_TELEMETRY_OFF	503.263 µs [479.99 µs, 526.536 µs]	122.057 µs (32.0%)
tracing	454.503 µs [433.952 µs, 475.055 µs]	73.297 µs (19.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/dd_tags
git_commit_date	1738260668	1738262341
git_commit_sha	`2b2be1e`	`798b8d8`
release_version	1.46.0-SNAPSHOT~2b2be1ef8d	1.46.0-SNAPSHOT~798b8d8c16

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738264249	1738264249
ci_job_id	788083554	788083554
ci_pipeline_id	54495557	54495557
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-k9ef9rs-project-304-concurrent-3-sx49ob9y 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-k9ef9rs-project-304-concurrent-3-sx49ob9y 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.438 s) : 15438000, 15438000
.   : milestone, 15438000,
appsec (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
iast (18.473 s) : 18473000, 18473000
.   : milestone, 18473000,
iast_GLOBAL (18.068 s) : 18068000, 18068000
.   : milestone, 18068000,
profiling (15.747 s) : 15747000, 15747000
.   : milestone, 15747000,
tracing (14.827 s) : 14827000, 14827000
.   : milestone, 14827000,
section candidate
no_agent (14.918 s) : 14918000, 14918000
.   : milestone, 14918000,
appsec (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
iast (19.004 s) : 19004000, 19004000
.   : milestone, 19004000,
iast_GLOBAL (18.201 s) : 18201000, 18201000
.   : milestone, 18201000,
profiling (15.187 s) : 15187000, 15187000
.   : milestone, 15187000,
tracing (14.716 s) : 14716000, 14716000
.   : milestone, 14716000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.438 s [15.438 s, 15.438 s]	-
appsec	15.036 s [15.036 s, 15.036 s]	-402.0 ms (-2.6%)
iast	18.473 s [18.473 s, 18.473 s]	3.035 s (19.7%)
iast_GLOBAL	18.068 s [18.068 s, 18.068 s]	2.63 s (17.0%)
profiling	15.747 s [15.747 s, 15.747 s]	309.0 ms (2.0%)
tracing	14.827 s [14.827 s, 14.827 s]	-611.0 ms (-4.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.918 s [14.918 s, 14.918 s]	-
appsec	15.027 s [15.027 s, 15.027 s]	109.0 ms (0.7%)
iast	19.004 s [19.004 s, 19.004 s]	4.086 s (27.4%)
iast_GLOBAL	18.201 s [18.201 s, 18.201 s]	3.283 s (22.0%)
profiling	15.187 s [15.187 s, 15.187 s]	269.0 ms (1.8%)
tracing	14.716 s [14.716 s, 14.716 s]	-202.0 ms (-1.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~798b8d8c16, baseline=1.46.0-SNAPSHOT~2b2be1ef8d
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
.   : milestone, 1471,
appsec (2.349 ms) : 2305, 2392
.   : milestone, 2349,
iast (2.109 ms) : 2054, 2164
.   : milestone, 2109,
iast_GLOBAL (2.143 ms) : 2088, 2198
.   : milestone, 2143,
profiling (1.958 ms) : 1915, 2002
.   : milestone, 1958,
tracing (1.942 ms) : 1900, 1985
.   : milestone, 1942,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.349 ms) : 2306, 2392
.   : milestone, 2349,
iast (2.096 ms) : 2042, 2151
.   : milestone, 2096,
iast_GLOBAL (2.14 ms) : 2085, 2195
.   : milestone, 2140,
profiling (1.943 ms) : 1900, 1985
.   : milestone, 1943,
tracing (1.946 ms) : 1904, 1988
.   : milestone, 1946,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.46 ms, 1.483 ms]	-
appsec	2.349 ms [2.305 ms, 2.392 ms]	877.379 µs (59.6%)
iast	2.109 ms [2.054 ms, 2.164 ms]	637.812 µs (43.3%)
iast_GLOBAL	2.143 ms [2.088 ms, 2.198 ms]	671.812 µs (45.7%)
profiling	1.958 ms [1.915 ms, 2.002 ms]	486.868 µs (33.1%)
tracing	1.942 ms [1.9 ms, 1.985 ms]	470.733 µs (32.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.456 ms, 1.479 ms]	-
appsec	2.349 ms [2.306 ms, 2.392 ms]	881.622 µs (60.1%)
iast	2.096 ms [2.042 ms, 2.151 ms]	628.843 µs (42.8%)
iast_GLOBAL	2.14 ms [2.085 ms, 2.195 ms]	672.758 µs (45.8%)
profiling	1.943 ms [1.9 ms, 1.985 ms]	474.944 µs (32.4%)
tracing	1.946 ms [1.904 ms, 1.988 ms]	478.244 µs (32.6%)

mhlidd changed the title ~~Mhlidd/dd tags~~ Add new parser for DD_TAGS and prioritizing DD_SERVICE Jan 28, 2025

mhlidd added type: enhancement comp: core Tracer core labels Jan 28, 2025

mhlidd added 11 commits January 29, 2025 16:15

testing

04cc577

cleanup

5cbca2c

first iteration on parser

96be6c8

initial working parsing for DD_TAGS

79e12ea

cleanup part 1

8c6cbaa

cleanup pt 2

f31e8e8

adding traceTagsParser as separate parser due to different rule

61d1d4d

dd_service override

dee14ce

reverting irrelevant changes

bf49e20

cleanup

8bef8d0

reverting irrelevant changes

5dbe976

mhlidd force-pushed the mhlidd/dd_tags branch from 50cad0a to 5dbe976 Compare January 29, 2025 21:25

cleanup again

798b8d8

mhlidd marked this pull request as ready for review January 31, 2025 14:40

mhlidd requested a review from a team as a code owner January 31, 2025 14:40

mhlidd requested review from dougqh and amarziali January 31, 2025 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` #8296

Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` #8296

mhlidd commented Jan 28, 2025 •

edited

Loading

pr-commenter bot commented Jan 28, 2025 •

edited

Loading

Add new parser for DD_TAGS and prioritizing DD_SERVICE #8296

Are you sure you want to change the base?

Add new parser for DD_TAGS and prioritizing DD_SERVICE #8296

Conversation

mhlidd commented Jan 28, 2025 • edited Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Jan 28, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` #8296

Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` #8296

mhlidd commented Jan 28, 2025 •

edited

Loading

pr-commenter bot commented Jan 28, 2025 •

edited

Loading