Skip to content

Upgrade build to gradle 8.3 #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2023
Merged

Upgrade build to gradle 8.3 #5768

merged 1 commit into from
Aug 24, 2023

Conversation

bantonsson
Copy link
Contributor

What Does This Do

Motivation

Additional Notes

@bantonsson bantonsson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Aug 23, 2023
@pr-commenter
Copy link

pr-commenter bot commented Aug 23, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~6d21c3ecf6 1.20.0-SNAPSHOT~f30cf7ce0b
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 cases.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.20.0-SNAPSHOT~f30cf7ce0b, baseline=1.20.0-SNAPSHOT~6d21c3ecf6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (988.802 ms) : 0, 988802
Total [baseline] (9.191 s) : 0, 9191227
Agent [candidate] (994.602 ms) : 0, 994602
Total [candidate] (9.212 s) : 0, 9211815
section appsec
Agent [baseline] (1.072 s) : 0, 1072256
Total [baseline] (9.256 s) : 0, 9255519
Agent [candidate] (1.078 s) : 0, 1078067
Total [candidate] (9.301 s) : 0, 9301140
section iast
Agent [baseline] (1.092 s) : 0, 1091568
Total [baseline] (9.405 s) : 0, 9404908
Agent [candidate] (1.092 s) : 0, 1092307
Total [candidate] (9.423 s) : 0, 9423024
section profiling
Agent [baseline] (1.163 s) : 0, 1163069
Total [baseline] (9.455 s) : 0, 9455199
Agent [candidate] (1.155 s) : 0, 1155335
Total [candidate] (9.437 s) : 0, 9436907
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 988.802 ms -
Agent appsec 1.072 s 83.455 ms (8.4%)
Agent iast 1.092 s 102.766 ms (10.4%)
Agent profiling 1.163 s 174.268 ms (17.6%)
Total tracing 9.191 s -
Total appsec 9.256 s 64.292 ms (0.7%)
Total iast 9.405 s 213.681 ms (2.3%)
Total profiling 9.455 s 263.972 ms (2.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 994.602 ms -
Agent appsec 1.078 s 83.465 ms (8.4%)
Agent iast 1.092 s 97.705 ms (9.8%)
Agent profiling 1.155 s 160.733 ms (16.2%)
Total tracing 9.212 s -
Total appsec 9.301 s 89.325 ms (1.0%)
Total iast 9.423 s 211.209 ms (2.3%)
Total profiling 9.437 s 225.093 ms (2.4%) 
gantt
    title petclinic - break down per module: candidate=1.20.0-SNAPSHOT~f30cf7ce0b, baseline=1.20.0-SNAPSHOT~6d21c3ecf6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (612.736 ms) : 0, 612736
BytebuddyAgent [candidate] (616.827 ms) : 0, 616827
GlobalTracer [baseline] (284.918 ms) : 0, 284918
GlobalTracer [candidate] (286.76 ms) : 0, 286760
AppSec [baseline] (50.093 ms) : 0, 50093
AppSec [candidate] (49.827 ms) : 0, 49827
Remote Config [baseline] (665.489 µs) : 0, 665
Remote Config [candidate] (666.481 µs) : 0, 666
Telemetry [baseline] (6.046 ms) : 0, 6046
Telemetry [candidate] (5.996 ms) : 0, 5996
section appsec
BytebuddyAgent [baseline] (612.106 ms) : 0, 612106
BytebuddyAgent [candidate] (615.915 ms) : 0, 615915
GlobalTracer [baseline] (284.039 ms) : 0, 284039
GlobalTracer [candidate] (286.111 ms) : 0, 286111
AppSec [baseline] (135.24 ms) : 0, 135240
AppSec [candidate] (135.088 ms) : 0, 135088
Remote Config [baseline] (749.992 µs) : 0, 750
Remote Config [candidate] (735.32 µs) : 0, 735
Telemetry [baseline] (5.744 ms) : 0, 5744
Telemetry [candidate] (5.806 ms) : 0, 5806
section iast
BytebuddyAgent [baseline] (718.197 ms) : 0, 718197
BytebuddyAgent [candidate] (719.489 ms) : 0, 719489
GlobalTracer [baseline] (271.305 ms) : 0, 271305
GlobalTracer [candidate] (271.094 ms) : 0, 271094
AppSec [baseline] (47.399 ms) : 0, 47399
AppSec [candidate] (47.286 ms) : 0, 47286
IAST [baseline] (13.924 ms) : 0, 13924
IAST [candidate] (13.87 ms) : 0, 13870
Remote Config [baseline] (567.406 µs) : 0, 567
Remote Config [candidate] (552.906 µs) : 0, 553
Telemetry [baseline] (5.771 ms) : 0, 5771
Telemetry [candidate] (5.715 ms) : 0, 5715
section profiling
BytebuddyAgent [baseline] (628.445 ms) : 0, 628445
BytebuddyAgent [candidate] (623.481 ms) : 0, 623481
GlobalTracer [baseline] (347.803 ms) : 0, 347803
GlobalTracer [candidate] (345.518 ms) : 0, 345518
AppSec [baseline] (49.337 ms) : 0, 49337
AppSec [candidate] (48.998 ms) : 0, 48998
Remote Config [baseline] (656.972 µs) : 0, 657
Remote Config [candidate] (648.288 µs) : 0, 648
Telemetry [baseline] (6.031 ms) : 0, 6031
Telemetry [candidate] (5.955 ms) : 0, 5955
ProfilingAgent [baseline] (77.583 ms) : 0, 77583
ProfilingAgent [candidate] (78.054 ms) : 0, 78054
Profiling [baseline] (77.607 ms) : 0, 77607
Profiling [candidate] (78.079 ms) : 0, 78079
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.20.0-SNAPSHOT~f30cf7ce0b, baseline=1.20.0-SNAPSHOT~6d21c3ecf6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (986.314 ms) : 0, 986314
Total [baseline] (8.645 s) : 0, 8645468
Agent [candidate] (996.932 ms) : 0, 996932
Total [candidate] (8.698 s) : 0, 8697805
section appsec
Agent [baseline] (1.073 s) : 0, 1073464
Total [baseline] (8.733 s) : 0, 8733029
Agent [candidate] (1.081 s) : 0, 1081343
Total [candidate] (8.743 s) : 0, 8743319
section iast
Agent [baseline] (1.096 s) : 0, 1096388
Total [baseline] (9.178 s) : 0, 9177665
Agent [candidate] (1.092 s) : 0, 1091531
Total [candidate] (9.181 s) : 0, 9181413
section profiling
Agent [baseline] (1.159 s) : 0, 1158581
Total [baseline] (8.887 s) : 0, 8887274
Agent [candidate] (1.159 s) : 0, 1158615
Total [candidate] (8.877 s) : 0, 8877043
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 986.314 ms -
Agent appsec 1.073 s 87.15 ms (8.8%)
Agent iast 1.096 s 110.074 ms (11.2%)
Agent profiling 1.159 s 172.267 ms (17.5%)
Total tracing 8.645 s -
Total appsec 8.733 s 87.562 ms (1.0%)
Total iast 9.178 s 532.197 ms (6.2%)
Total profiling 8.887 s 241.806 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 996.932 ms -
Agent appsec 1.081 s 84.41 ms (8.5%)
Agent iast 1.092 s 94.598 ms (9.5%)
Agent profiling 1.159 s 161.683 ms (16.2%)
Total tracing 8.698 s -
Total appsec 8.743 s 45.515 ms (0.5%)
Total iast 9.181 s 483.609 ms (5.6%)
Total profiling 8.877 s 179.238 ms (2.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.20.0-SNAPSHOT~f30cf7ce0b, baseline=1.20.0-SNAPSHOT~6d21c3ecf6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (611.936 ms) : 0, 611936
BytebuddyAgent [candidate] (616.941 ms) : 0, 616941
GlobalTracer [baseline] (283.497 ms) : 0, 283497
GlobalTracer [candidate] (288.213 ms) : 0, 288213
AppSec [baseline] (50.007 ms) : 0, 50007
AppSec [candidate] (50.472 ms) : 0, 50472
Remote Config [baseline] (667.689 µs) : 0, 668
Remote Config [candidate] (681.646 µs) : 0, 682
Telemetry [baseline] (5.962 ms) : 0, 5962
Telemetry [candidate] (6.066 ms) : 0, 6066
section appsec
BytebuddyAgent [baseline] (613.218 ms) : 0, 613218
BytebuddyAgent [candidate] (617.739 ms) : 0, 617739
GlobalTracer [baseline] (283.947 ms) : 0, 283947
GlobalTracer [candidate] (286.444 ms) : 0, 286444
AppSec [baseline] (135.511 ms) : 0, 135511
AppSec [candidate] (136.086 ms) : 0, 136086
Remote Config [baseline] (724.613 µs) : 0, 725
Remote Config [candidate] (740.937 µs) : 0, 741
Telemetry [baseline] (5.755 ms) : 0, 5755
Telemetry [candidate] (5.788 ms) : 0, 5788
section iast
BytebuddyAgent [baseline] (721.894 ms) : 0, 721894
BytebuddyAgent [candidate] (719.114 ms) : 0, 719114
GlobalTracer [baseline] (272.283 ms) : 0, 272283
GlobalTracer [candidate] (271.032 ms) : 0, 271032
AppSec [baseline] (47.53 ms) : 0, 47530
AppSec [candidate] (47.306 ms) : 0, 47306
IAST [baseline] (13.87 ms) : 0, 13870
IAST [candidate] (13.686 ms) : 0, 13686
Remote Config [baseline] (555.945 µs) : 0, 556
Remote Config [candidate] (547.019 µs) : 0, 547
Telemetry [baseline] (5.715 ms) : 0, 5715
Telemetry [candidate] (5.633 ms) : 0, 5633
section profiling
BytebuddyAgent [baseline] (627.482 ms) : 0, 627482
BytebuddyAgent [candidate] (625.306 ms) : 0, 625306
GlobalTracer [baseline] (345.078 ms) : 0, 345078
GlobalTracer [candidate] (346.469 ms) : 0, 346469
AppSec [baseline] (49.073 ms) : 0, 49073
AppSec [candidate] (49.368 ms) : 0, 49368
Remote Config [baseline] (650.436 µs) : 0, 650
Remote Config [candidate] (648.833 µs) : 0, 649
Telemetry [baseline] (6.027 ms) : 0, 6027
Telemetry [candidate] (6.006 ms) : 0, 6006
ProfilingAgent [baseline] (77.142 ms) : 0, 77142
ProfilingAgent [candidate] (78.024 ms) : 0, 78024
Profiling [baseline] (77.166 ms) : 0, 77166
Profiling [candidate] (78.048 ms) : 0, 78048
Loading

Load

Parameters

Baseline Candidate
commit 1.20.0-SNAPSHOT~6d21c3ecf6 1.20.0-SNAPSHOT~f30cf7ce0b
config baseline candidate
end_time 2023-08-23T17:01:20 2023-08-23T17:19:26
start_time 2023-08-23T17:01:03 2023-08-23T17:19:08
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~f30cf7ce0b, baseline=1.20.0-SNAPSHOT~6d21c3ecf6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.322 ms) : 1303, 1341
.   : milestone, 1322,
appsec (1.672 ms) : 1648, 1697
.   : milestone, 1672,
iast (1.452 ms) : 1428, 1476
.   : milestone, 1452,
profiling (1.468 ms) : 1443, 1493
.   : milestone, 1468,
tracing (1.46 ms) : 1436, 1484
.   : milestone, 1460,
section candidate
no_agent (1.341 ms) : 1322, 1361
.   : milestone, 1341,
appsec (1.696 ms) : 1671, 1720
.   : milestone, 1696,
iast (1.478 ms) : 1454, 1503
.   : milestone, 1478,
profiling (1.518 ms) : 1492, 1544
.   : milestone, 1518,
tracing (1.462 ms) : 1438, 1487
.   : milestone, 1462,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.322 ms [1.303 ms, 1.341 ms] -
appsec 1.672 ms [1.648 ms, 1.697 ms] 350.28 µs (26.5%)
iast 1.452 ms [1.428 ms, 1.476 ms] 129.846 µs (9.8%)
profiling 1.468 ms [1.443 ms, 1.493 ms] 146.127 µs (11.1%)
tracing 1.46 ms [1.436 ms, 1.484 ms] 138.169 µs (10.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.341 ms [1.322 ms, 1.361 ms] -
appsec 1.696 ms [1.671 ms, 1.72 ms] 354.298 µs (26.4%)
iast 1.478 ms [1.454 ms, 1.503 ms] 136.909 µs (10.2%)
profiling 1.518 ms [1.492 ms, 1.544 ms] 176.507 µs (13.2%)
tracing 1.462 ms [1.438 ms, 1.487 ms] 121.198 µs (9.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.20.0-SNAPSHOT~f30cf7ce0b, baseline=1.20.0-SNAPSHOT~6d21c3ecf6
    dateFormat X
    axisFormat %s
section baseline
no_agent (359.727 µs) : 339, 380
.   : milestone, 360,
appsec (667.863 µs) : 647, 689
.   : milestone, 668,
iast (456.756 µs) : 436, 478
.   : milestone, 457,
iast_FULL (516.598 µs) : 496, 537
.   : milestone, 517,
iast_INACTIVE (437.714 µs) : 417, 458
.   : milestone, 438,
profiling (433.501 µs) : 412, 455
.   : milestone, 434,
tracing (427.101 µs) : 407, 447
.   : milestone, 427,
section candidate
no_agent (366.597 µs) : 347, 387
.   : milestone, 367,
appsec (665.051 µs) : 645, 685
.   : milestone, 665,
iast (458.209 µs) : 437, 479
.   : milestone, 458,
iast_FULL (516.928 µs) : 496, 538
.   : milestone, 517,
iast_INACTIVE (434.963 µs) : 414, 456
.   : milestone, 435,
profiling (433.496 µs) : 412, 455
.   : milestone, 433,
tracing (430.876 µs) : 410, 451
.   : milestone, 431,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.727 µs [339.476 µs, 379.977 µs] -
appsec 667.863 µs [647.004 µs, 688.723 µs] 308.137 µs (85.7%)
iast 456.756 µs [435.624 µs, 477.888 µs] 97.029 µs (27.0%)
iast_FULL 516.598 µs [495.842 µs, 537.353 µs] 156.871 µs (43.6%)
iast_INACTIVE 437.714 µs [416.954 µs, 458.474 µs] 77.987 µs (21.7%)
profiling 433.501 µs [412.473 µs, 454.53 µs] 73.775 µs (20.5%)
tracing 427.101 µs [406.723 µs, 447.479 µs] 67.375 µs (18.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.597 µs [346.538 µs, 386.656 µs] -
appsec 665.051 µs [644.711 µs, 685.391 µs] 298.454 µs (81.4%)
iast 458.209 µs [437.329 µs, 479.088 µs] 91.612 µs (25.0%)
iast_FULL 516.928 µs [496.077 µs, 537.778 µs] 150.331 µs (41.0%)
iast_INACTIVE 434.963 µs [414.105 µs, 455.82 µs] 68.366 µs (18.6%)
profiling 433.496 µs [412.13 µs, 454.861 µs] 66.899 µs (18.2%)
tracing 430.876 µs [410.318 µs, 451.435 µs] 64.279 µs (17.5%)

@bantonsson bantonsson marked this pull request as ready for review August 23, 2023 15:48
@bantonsson bantonsson requested a review from a team as a code owner August 23, 2023 15:48
@bantonsson bantonsson requested a review from am312 August 23, 2023 15:48
@bantonsson bantonsson added the run-tests: all Run all tests label Aug 23, 2023
@bantonsson bantonsson merged commit 7afd491 into master Aug 24, 2023
@bantonsson bantonsson deleted the ban/gradle-8.3 branch August 24, 2023 05:26
@github-actions github-actions bot added this to the 1.20.0 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@am312 am312 Awaiting requested review from am312 am312 is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: tooling Build & Tooling run-tests: all Run all tests tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bantonsson @smola @PerfectSlayer