Jetty leaking out of `:dd-java-agent:testing` #10218

bric3 · 2025-12-15T21:14:39Z

What Does This Do

:dd-java-agent:testing is using jetty for it's embedded server. However, it leaks through other projects, in particular jetty instrumentation projects, but others too. This forces these projects to exclude that dependency.

Also, make some dependencies explicit, e.g. in spring webflux tests: :dd-java-agent:testing.

Motivation

Build correctness.

Additional Notes

This was introduced as part of

Support jetty client 10 and 11 #6590

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

…version of jetty

dd-java-agent/testing/build.gradle

pr-commenter · 2025-12-15T22:18:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/fix-jetty-leaking-out-of-testing
git_commit_date	1765826150	1765916383
git_commit_sha	`3101a85`	`9f78da2`
release_version	1.57.0-SNAPSHOT~3101a85cf1	1.57.0-SNAPSHOT~9f78da25d1

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765918270	1765918270
ci_job_id	1300550074	1300550074
ci_pipeline_id	87157453	87157453
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-zhxlr5ma 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-zhxlr5ma 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081378
Total [baseline] (8.772 s) : 0, 8772008
Agent [candidate] (1.08 s) : 0, 1079672
Total [candidate] (8.771 s) : 0, 8770799
section iast
Agent [baseline] (1.22 s) : 0, 1219690
Total [baseline] (9.386 s) : 0, 9385899
Agent [candidate] (1.221 s) : 0, 1221327
Total [candidate] (9.448 s) : 0, 9447938

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.081 s	-
Agent	iast	1.22 s	138.312 ms (12.8%)
Total	tracing	8.772 s	-
Total	iast	9.386 s	613.891 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.08 s	-
Agent	iast	1.221 s	141.655 ms (13.1%)
Total	tracing	8.771 s	-
Total	iast	9.448 s	677.139 ms (7.7%)

gantt
    title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (649.238 ms) : 0, 649238
BytebuddyAgent [candidate] (647.893 ms) : 0, 647893
GlobalTracer [baseline] (282.494 ms) : 0, 282494
GlobalTracer [candidate] (282.616 ms) : 0, 282616
AppSec [baseline] (32.256 ms) : 0, 32256
AppSec [candidate] (32.236 ms) : 0, 32236
Debugger [baseline] (67.314 ms) : 0, 67314
Debugger [candidate] (66.797 ms) : 0, 66797
Remote Config [baseline] (613.64 µs) : 0, 614
Remote Config [candidate] (629.777 µs) : 0, 630
Telemetry [baseline] (9.058 ms) : 0, 9058
Telemetry [candidate] (9.1 ms) : 0, 9100
Flare Poller [baseline] (3.747 ms) : 0, 3747
Flare Poller [candidate] (3.769 ms) : 0, 3769
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (788.694 ms) : 0, 788694
BytebuddyAgent [candidate] (789.963 ms) : 0, 789963
GlobalTracer [baseline] (255.894 ms) : 0, 255894
GlobalTracer [candidate] (255.915 ms) : 0, 255915
IAST [baseline] (27.789 ms) : 0, 27789
IAST [candidate] (26.885 ms) : 0, 26885
AppSec [baseline] (32.513 ms) : 0, 32513
AppSec [candidate] (32.518 ms) : 0, 32518
Debugger [baseline] (65.925 ms) : 0, 65925
Debugger [candidate] (67.037 ms) : 0, 67037
Remote Config [baseline] (596.925 µs) : 0, 597
Remote Config [candidate] (570.222 µs) : 0, 570
Telemetry [baseline] (8.348 ms) : 0, 8348
Telemetry [candidate] (8.411 ms) : 0, 8411
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.545 ms) : 0, 3545

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088991
Total [baseline] (10.995 s) : 0, 10995313
Agent [candidate] (1.079 s) : 0, 1078981
Total [candidate] (10.81 s) : 0, 10810453
section appsec
Agent [baseline] (1.262 s) : 0, 1262268
Total [baseline] (10.974 s) : 0, 10973920
Agent [candidate] (1.263 s) : 0, 1262810
Total [candidate] (11.185 s) : 0, 11184874
section iast
Agent [baseline] (1.229 s) : 0, 1229381
Total [baseline] (11.274 s) : 0, 11273578
Agent [candidate] (1.223 s) : 0, 1222591
Total [candidate] (11.136 s) : 0, 11135947
section profiling
Agent [baseline] (1.204 s) : 0, 1203513
Total [baseline] (10.942 s) : 0, 10941847
Agent [candidate] (1.212 s) : 0, 1211667
Total [candidate] (10.957 s) : 0, 10956887

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	appsec	1.262 s	173.277 ms (15.9%)
Agent	iast	1.229 s	140.39 ms (12.9%)
Agent	profiling	1.204 s	114.522 ms (10.5%)
Total	tracing	10.995 s	-
Total	appsec	10.974 s	-21.393 ms (-0.2%)
Total	iast	11.274 s	278.265 ms (2.5%)
Total	profiling	10.942 s	-53.466 ms (-0.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.079 s	-
Agent	appsec	1.263 s	183.829 ms (17.0%)
Agent	iast	1.223 s	143.611 ms (13.3%)
Agent	profiling	1.212 s	132.686 ms (12.3%)
Total	tracing	10.81 s	-
Total	appsec	11.185 s	374.421 ms (3.5%)
Total	iast	11.136 s	325.494 ms (3.0%)
Total	profiling	10.957 s	146.434 ms (1.4%)

gantt
    title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (653.938 ms) : 0, 653938
BytebuddyAgent [candidate] (647.192 ms) : 0, 647192
GlobalTracer [baseline] (284.38 ms) : 0, 284380
GlobalTracer [candidate] (281.81 ms) : 0, 281810
AppSec [baseline] (32.659 ms) : 0, 32659
AppSec [candidate] (32.237 ms) : 0, 32237
Debugger [baseline] (66.86 ms) : 0, 66860
Debugger [candidate] (67.012 ms) : 0, 67012
Remote Config [baseline] (635.019 µs) : 0, 635
Remote Config [candidate] (629.053 µs) : 0, 629
Telemetry [baseline] (9.014 ms) : 0, 9014
Telemetry [candidate] (9.077 ms) : 0, 9077
Flare Poller [baseline] (4.637 ms) : 0, 4637
Flare Poller [candidate] (4.455 ms) : 0, 4455
section appsec
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (687.425 ms) : 0, 687425
BytebuddyAgent [candidate] (689.847 ms) : 0, 689847
GlobalTracer [baseline] (258.364 ms) : 0, 258364
GlobalTracer [candidate] (258.665 ms) : 0, 258665
AppSec [baseline] (173.14 ms) : 0, 173140
AppSec [candidate] (171.418 ms) : 0, 171418
Debugger [baseline] (68.624 ms) : 0, 68624
Debugger [candidate] (67.669 ms) : 0, 67669
Remote Config [baseline] (713.093 µs) : 0, 713
Remote Config [candidate] (702.515 µs) : 0, 703
Telemetry [baseline] (9.01 ms) : 0, 9010
Telemetry [candidate] (9.0 ms) : 0, 9000
Flare Poller [baseline] (3.885 ms) : 0, 3885
Flare Poller [candidate] (3.938 ms) : 0, 3938
IAST [baseline] (24.491 ms) : 0, 24491
IAST [candidate] (24.657 ms) : 0, 24657
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (794.586 ms) : 0, 794586
BytebuddyAgent [candidate] (790.258 ms) : 0, 790258
GlobalTracer [baseline] (257.483 ms) : 0, 257483
GlobalTracer [candidate] (255.781 ms) : 0, 255781
AppSec [baseline] (33.792 ms) : 0, 33792
AppSec [candidate] (33.68 ms) : 0, 33680
Debugger [baseline] (67.051 ms) : 0, 67051
Debugger [candidate] (66.663 ms) : 0, 66663
Remote Config [baseline] (588.086 µs) : 0, 588
Remote Config [candidate] (590.038 µs) : 0, 590
Telemetry [baseline] (8.403 ms) : 0, 8403
Telemetry [candidate] (8.382 ms) : 0, 8382
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.5 ms) : 0, 3500
IAST [baseline] (27.305 ms) : 0, 27305
IAST [candidate] (27.074 ms) : 0, 27074
section profiling
ProfilingAgent [baseline] (97.485 ms) : 0, 97485
ProfilingAgent [candidate] (97.041 ms) : 0, 97041
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.222 ms) : 0, 1222
BytebuddyAgent [baseline] (700.549 ms) : 0, 700549
BytebuddyAgent [candidate] (706.59 ms) : 0, 706590
GlobalTracer [baseline] (220.703 ms) : 0, 220703
GlobalTracer [candidate] (222.04 ms) : 0, 222040
AppSec [baseline] (32.127 ms) : 0, 32127
AppSec [candidate] (32.438 ms) : 0, 32438
Debugger [baseline] (68.291 ms) : 0, 68291
Debugger [candidate] (68.698 ms) : 0, 68698
Remote Config [baseline] (625.219 µs) : 0, 625
Remote Config [candidate] (660.906 µs) : 0, 661
Telemetry [baseline] (9.02 ms) : 0, 9020
Telemetry [candidate] (9.159 ms) : 0, 9159
Flare Poller [baseline] (3.775 ms) : 0, 3775
Flare Poller [candidate] (3.85 ms) : 0, 3850
Profiling [baseline] (98.081 ms) : 0, 98081
Profiling [candidate] (97.62 ms) : 0, 97620

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/fix-jetty-leaking-out-of-testing
git_commit_date	1765826150	1765916383
git_commit_sha	`3101a85`	`9f78da2`
release_version	1.57.0-SNAPSHOT~3101a85cf1	1.57.0-SNAPSHOT~9f78da25d1

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1765918758	1765918758
ci_job_id	1300550075	1300550075
ci_pipeline_id	87157453	87157453
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-q91ydkbq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-q91ydkbq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+74.513µs; +194.762µs] or [+2.786%; +7.282%]	unsure [+60.063µs; +447.772µs] or [+0.782%; +5.828%]	unstable [-196.742op/s; +75.429op/s] or [-14.645%; +5.615%]	2.809ms	7.937ms	1282.781op/s	2.674ms	7.683ms	1343.438op/s
scenario:load:petclinic:appsec:high_load	worse [+0.932ms; +1.848ms] or [+5.144%; +10.202%]	worse [+1.051ms; +2.411ms] or [+3.547%; +8.137%]	unstable [-41.445op/s; +11.195op/s] or [-16.432%; +4.439%]	19.503ms	31.354ms	237.094op/s	18.113ms	29.623ms	252.219op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.769 ms) : 18578, 18960
.   : milestone, 18769,
appsec (18.505 ms) : 18318, 18692
.   : milestone, 18505,
code_origins (17.871 ms) : 17693, 18049
.   : milestone, 17871,
iast (17.717 ms) : 17540, 17895
.   : milestone, 17717,
profiling (18.745 ms) : 18555, 18934
.   : milestone, 18745,
tracing (17.665 ms) : 17494, 17837
.   : milestone, 17665,
section candidate
no_agent (19.137 ms) : 18934, 19339
.   : milestone, 19137,
appsec (19.692 ms) : 19488, 19896
.   : milestone, 19692,
code_origins (17.491 ms) : 17318, 17664
.   : milestone, 17491,
iast (17.599 ms) : 17423, 17775
.   : milestone, 17599,
profiling (18.456 ms) : 18272, 18641
.   : milestone, 18456,
tracing (17.591 ms) : 17416, 17766
.   : milestone, 17591,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	18.769 ms [18.578 ms, 18.96 ms]	-
appsec	18.505 ms [18.318 ms, 18.692 ms]	-264.035 µs (-1.4%)
code_origins	17.871 ms [17.693 ms, 18.049 ms]	-897.84 µs (-4.8%)
iast	17.717 ms [17.54 ms, 17.895 ms]	-1.051 ms (-5.6%)
profiling	18.745 ms [18.555 ms, 18.934 ms]	-23.994 µs (-0.1%)
tracing	17.665 ms [17.494 ms, 17.837 ms]	-1.103 ms (-5.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.137 ms [18.934 ms, 19.339 ms]	-
appsec	19.692 ms [19.488 ms, 19.896 ms]	555.076 µs (2.9%)
code_origins	17.491 ms [17.318 ms, 17.664 ms]	-1.646 ms (-8.6%)
iast	17.599 ms [17.423 ms, 17.775 ms]	-1.538 ms (-8.0%)
profiling	18.456 ms [18.272 ms, 18.641 ms]	-680.294 µs (-3.6%)
tracing	17.591 ms [17.416 ms, 17.766 ms]	-1.546 ms (-8.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1196
.   : milestone, 1185,
iast (3.248 ms) : 3206, 3290
.   : milestone, 3248,
iast_FULL (5.771 ms) : 5714, 5829
.   : milestone, 5771,
iast_GLOBAL (3.41 ms) : 3365, 3456
.   : milestone, 3410,
profiling (2.01 ms) : 1993, 2028
.   : milestone, 2010,
tracing (1.821 ms) : 1806, 1835
.   : milestone, 1821,
section candidate
no_agent (1.19 ms) : 1178, 1202
.   : milestone, 1190,
iast (3.197 ms) : 3158, 3237
.   : milestone, 3197,
iast_FULL (5.73 ms) : 5671, 5788
.   : milestone, 5730,
iast_GLOBAL (3.574 ms) : 3520, 3628
.   : milestone, 3574,
profiling (2.039 ms) : 2021, 2057
.   : milestone, 2039,
tracing (1.809 ms) : 1794, 1824
.   : milestone, 1809,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.185 ms [1.173 ms, 1.196 ms]	-
iast	3.248 ms [3.206 ms, 3.29 ms]	2.064 ms (174.2%)
iast_FULL	5.771 ms [5.714 ms, 5.829 ms]	4.586 ms (387.1%)
iast_GLOBAL	3.41 ms [3.365 ms, 3.456 ms]	2.226 ms (187.9%)
profiling	2.01 ms [1.993 ms, 2.028 ms]	825.548 µs (69.7%)
tracing	1.821 ms [1.806 ms, 1.835 ms]	635.939 µs (53.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.19 ms [1.178 ms, 1.202 ms]	-
iast	3.197 ms [3.158 ms, 3.237 ms]	2.007 ms (168.7%)
iast_FULL	5.73 ms [5.671 ms, 5.788 ms]	4.54 ms (381.6%)
iast_GLOBAL	3.574 ms [3.52 ms, 3.628 ms]	2.384 ms (200.4%)
profiling	2.039 ms [2.021 ms, 2.057 ms]	849.142 µs (71.4%)
tracing	1.809 ms [1.794 ms, 1.824 ms]	619.111 µs (52.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	bdu/fix-jetty-leaking-out-of-testing
git_commit_date	1765826150	1765916383
git_commit_sha	`3101a85`	`9f78da2`
release_version	1.57.0-SNAPSHOT~3101a85cf1	1.57.0-SNAPSHOT~9f78da25d1

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1765918409	1765918409
ci_job_id	1300550076	1300550076
ci_pipeline_id	87157453	87157453
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-nmjezc5b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-nmjezc5b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.986 s) : 14986000, 14986000
.   : milestone, 14986000,
appsec (14.585 s) : 14585000, 14585000
.   : milestone, 14585000,
iast (18.078 s) : 18078000, 18078000
.   : milestone, 18078000,
iast_GLOBAL (17.733 s) : 17733000, 17733000
.   : milestone, 17733000,
profiling (14.854 s) : 14854000, 14854000
.   : milestone, 14854000,
tracing (14.78 s) : 14780000, 14780000
.   : milestone, 14780000,
section candidate
no_agent (15.399 s) : 15399000, 15399000
.   : milestone, 15399000,
appsec (14.76 s) : 14760000, 14760000
.   : milestone, 14760000,
iast (18.351 s) : 18351000, 18351000
.   : milestone, 18351000,
iast_GLOBAL (17.688 s) : 17688000, 17688000
.   : milestone, 17688000,
profiling (14.618 s) : 14618000, 14618000
.   : milestone, 14618000,
tracing (14.663 s) : 14663000, 14663000
.   : milestone, 14663000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.986 s [14.986 s, 14.986 s]	-
appsec	14.585 s [14.585 s, 14.585 s]	-401.0 ms (-2.7%)
iast	18.078 s [18.078 s, 18.078 s]	3.092 s (20.6%)
iast_GLOBAL	17.733 s [17.733 s, 17.733 s]	2.747 s (18.3%)
profiling	14.854 s [14.854 s, 14.854 s]	-132.0 ms (-0.9%)
tracing	14.78 s [14.78 s, 14.78 s]	-206.0 ms (-1.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.399 s [15.399 s, 15.399 s]	-
appsec	14.76 s [14.76 s, 14.76 s]	-639.0 ms (-4.1%)
iast	18.351 s [18.351 s, 18.351 s]	2.952 s (19.2%)
iast_GLOBAL	17.688 s [17.688 s, 17.688 s]	2.289 s (14.9%)
profiling	14.618 s [14.618 s, 14.618 s]	-781.0 ms (-5.1%)
tracing	14.663 s [14.663 s, 14.663 s]	-736.0 ms (-4.8%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~9f78da25d1, baseline=1.57.0-SNAPSHOT~3101a85cf1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
.   : milestone, 1475,
appsec (3.642 ms) : 3428, 3857
.   : milestone, 3642,
iast (2.212 ms) : 2148, 2277
.   : milestone, 2212,
iast_GLOBAL (2.248 ms) : 2183, 2313
.   : milestone, 2248,
profiling (2.075 ms) : 2022, 2127
.   : milestone, 2075,
tracing (2.046 ms) : 1995, 2097
.   : milestone, 2046,
section candidate
no_agent (1.482 ms) : 1470, 1494
.   : milestone, 1482,
appsec (3.707 ms) : 3487, 3927
.   : milestone, 3707,
iast (2.209 ms) : 2145, 2274
.   : milestone, 2209,
iast_GLOBAL (2.256 ms) : 2191, 2321
.   : milestone, 2256,
profiling (2.489 ms) : 2277, 2700
.   : milestone, 2489,
tracing (2.043 ms) : 1992, 2093
.   : milestone, 2043,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	3.642 ms [3.428 ms, 3.857 ms]	2.167 ms (146.9%)
iast	2.212 ms [2.148 ms, 2.277 ms]	737.044 µs (50.0%)
iast_GLOBAL	2.248 ms [2.183 ms, 2.313 ms]	772.913 µs (52.4%)
profiling	2.075 ms [2.022 ms, 2.127 ms]	599.055 µs (40.6%)
tracing	2.046 ms [1.995 ms, 2.097 ms]	570.75 µs (38.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.482 ms [1.47 ms, 1.494 ms]	-
appsec	3.707 ms [3.487 ms, 3.927 ms]	2.225 ms (150.1%)
iast	2.209 ms [2.145 ms, 2.274 ms]	727.379 µs (49.1%)
iast_GLOBAL	2.256 ms [2.191 ms, 2.321 ms]	774.132 µs (52.2%)
profiling	2.489 ms [2.277 ms, 2.7 ms]	1.007 ms (67.9%)
tracing	2.043 ms [1.992 ms, 2.093 ms]	560.688 µs (37.8%)

This was lost when jetty server got shadowed.

AlexeyKuznetsov-DD · 2025-12-16T00:59:58Z

dd-java-agent/testing/build.gradle

+  compileOnly group: 'org.eclipse.jetty', name: 'jetty-server', version: '9.4.56.v20240826'
+  runtimeOnly group: 'org.eclipse.jetty', name: 'jetty-server', version: '9.4.56.v20240826'
+  // Since jetty-server is shadowed, it is needed to exports the servlet api as well.


Just curious if it make sense to use 9.4.58.v20250814 ?
see: https://jetty.org/download.html

Some tests still run on Java 8.

Maybe my comment was not clear, but 9.4.58.v20250814 is the latest Java 8 compatible version with all security fixes. A link was to jetty site for more information.

Ah, maybe this can be bumped. Sorry I misunderstood.

…instrumentation Now that :dd-java-agent:testing shadows jetty, the jetty instrumentation was not applied.

bric3 added 4 commits December 15, 2025 21:53

fix: Workaround for :dd-java-agent:testing coming with a more recent …

8680447

…version of jetty

fix: Proper shadowing of jetty in agent-testing

be26899

chore: lockfiles

9deb715

fix: jsp instrumentation needlessly requiring jetty http status

73e0938

bric3 added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Dec 15, 2025

bric3 temporarily deployed to ci-build December 15, 2025 21:14 — with GitHub Actions Inactive

bric3 temporarily deployed to ci-build December 15, 2025 21:47 — with GitHub Actions Inactive

AlexeyKuznetsov-DD reviewed Dec 15, 2025

View reviewed changes

dd-java-agent/testing/build.gradle Outdated Show resolved Hide resolved

bric3 marked this pull request as ready for review December 15, 2025 22:58

bric3 requested review from a team as code owners December 15, 2025 22:58

bric3 requested a review from mcculls December 15, 2025 22:58

bric3 mentioned this pull request Dec 15, 2025

Remove instrumentation afterEvaluate #9752

Draft

bric3 marked this pull request as draft December 15, 2025 23:25

bric3 added 2 commits December 16, 2025 00:57

fix: Exports servlet request api

0f91d4f

This was lost when jetty server got shadowed.

fix: Use config lazy API

2b6b84d

bric3 force-pushed the bdu/fix-jetty-leaking-out-of-testing branch from efaf8a0 to 2b6b84d Compare December 16, 2025 00:09

bric3 temporarily deployed to ci-build December 16, 2025 00:09 — with GitHub Actions Inactive

AlexeyKuznetsov-DD reviewed Dec 16, 2025

View reviewed changes

chore: Make spotless happy

612bea1

bric3 temporarily deployed to ci-build December 16, 2025 06:53 — with GitHub Actions Inactive

fix: Replaces testing http client by raw jetty in Apache Http Client …

681b9df

…instrumentation Now that :dd-java-agent:testing shadows jetty, the jetty instrumentation was not applied.

bric3 temporarily deployed to ci-build December 16, 2025 17:48 — with GitHub Actions Inactive

chore: Make spotless happy

9f78da2

bric3 temporarily deployed to ci-build December 16, 2025 20:19 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Jetty leaking out of `:dd-java-agent:testing` #10218

Jetty leaking out of `:dd-java-agent:testing` #10218

bric3 commented Dec 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

pr-commenter bot commented Dec 15, 2025 •

edited

Loading

Uh oh!

AlexeyKuznetsov-DD Dec 16, 2025

Uh oh!

bric3 Dec 16, 2025

Uh oh!

AlexeyKuznetsov-DD Dec 16, 2025

Uh oh!

bric3 Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jetty leaking out of :dd-java-agent:testing #10218

Are you sure you want to change the base?

Jetty leaking out of :dd-java-agent:testing #10218

Conversation

bric3 commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

Uh oh!

pr-commenter bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

AlexeyKuznetsov-DD Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Jetty leaking out of `:dd-java-agent:testing` #10218

Jetty leaking out of `:dd-java-agent:testing` #10218

bric3 commented Dec 15, 2025 •

edited

Loading

pr-commenter bot commented Dec 15, 2025 •

edited

Loading