Skip to content

ducktype collecting #7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ducktype collecting #7683

wants to merge 1 commit into from
+340 −0

Conversation

@tonyredondo
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 21, 2025 •
edited
Loading

⚠️ Tests

⚠️ Warnings

🧪 165 Tests failed

GraphQL2SchemaV0Tests.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog) 

      Name: aspnet_c,ority_v1: 1.0,00000/graphql,0,,ry=query%7Bhero%7Bname+appearsIn%7D%7D,
GraphQL2SchemaV0Tests.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog) 

      Name: aspnet_c,ority_v1: 1.0,00000/graphql,0,,ry=query%7Bhero%7Bname+appearsIn%7D%7D,
GraphQL3SchemaV0Tests.SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests (Datadog) 

      TraceId: Id_13iority_v1: 1.0GraphQL3plementedSub{throwNotImplementedException{name}},tributes":{"message":"Argument \"id\" has invalid value 1.\nExpected type \"String\", found 1.","code":"ARGUMENTS_OF_CORRECT_TYPE","locations":["1:24"]}},{"name":"dd.graphql.query.error","time_unix_nano":<DateTimeOffset.Now>,"attributes":{"message":"Cannot query field \"apearsIn\" on type \"Human\". Did you mean 'appearsIn'?","code":"FIELDS_ON_CORRECT_TYPE","locations":["1:35"]}}],
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f7e913d | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7683 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.148
  • 5 benchmarks have fewer allocations
  • 2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7683

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.13 KB 6.07 KB -54 B -0.88%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.8μs 55.6ns 261ns 0 0 0 5.5 KB
master StartStopWithChild netcoreapp3.1 13.7μs 69.3ns 310ns 0 0 0 5.73 KB
master StartStopWithChild net472 22μs 115ns 551ns 0.873 0.218 0 6.13 KB
#7683 StartStopWithChild net6.0 10.6μs 59.8ns 383ns 0 0 0 5.51 KB
#7683 StartStopWithChild netcoreapp3.1 13.5μs 73.1ns 387ns 0 0 0 5.74 KB
#7683 StartStopWithChild net472 22.4μs 118ns 637ns 0.909 0.227 0 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 948μs 285ns 1.07μs 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 34.1ns 118ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.19ms 816ns 3.16μs 0 0 0 3.31 KB
#7683 WriteAndFlushEnrichedTraces net6.0 957μs 127ns 440ns 0 0 0 2.7 KB
#7683 WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 71.8ns 269ns 0 0 0 2.7 KB
#7683 WriteAndFlushEnrichedTraces net472 1.2ms 1.48μs 5.53μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 353μs 1.61μs 6.01μs 0 0 0 179.56 KB
master AllCycleSimpleBody netcoreapp3.1 532μs 1.41μs 5.45μs 0 0 0 185.32 KB
master AllCycleSimpleBody net472 469μs 146ns 545ns 32.4 0 0 205.41 KB
master AllCycleMoreComplexBody net6.0 359μs 1.68μs 6.71μs 0 0 0 183.09 KB
master AllCycleMoreComplexBody netcoreapp3.1 508μs 2.43μs 11.1μs 0 0 0 188.75 KB
master AllCycleMoreComplexBody net472 478μs 165ns 594ns 32.4 0 0 208.94 KB
master ObjectExtractorSimpleBody net6.0 317ns 1.77ns 11.3ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 399ns 2.13ns 10.4ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 299ns 0.0826ns 0.309ns 0.0436 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.23μs 1.66ns 6.21ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.79μs 39.8ns 191ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.68μs 5.75ns 22.3ns 0.598 0 0 3.8 KB
#7683 AllCycleSimpleBody net6.0 356μs 1.52μs 5.88μs 0 0 0 179.56 KB
#7683 AllCycleSimpleBody netcoreapp3.1 527μs 606ns 2.35μs 0 0 0 185.32 KB
#7683 AllCycleSimpleBody net472 467μs 99.4ns 385ns 32.4 0 0 205.41 KB
#7683 AllCycleMoreComplexBody net6.0 362μs 1.02μs 3.8μs 0 0 0 183.1 KB
#7683 AllCycleMoreComplexBody netcoreapp3.1 515μs 696ns 2.7μs 0 0 0 188.75 KB
#7683 AllCycleMoreComplexBody net472 477μs 112ns 417ns 32.4 0 0 208.94 KB
#7683 ObjectExtractorSimpleBody net6.0 315ns 1.73ns 10.7ns 0 0 0 280 B
#7683 ObjectExtractorSimpleBody netcoreapp3.1 396ns 2.17ns 12.1ns 0 0 0 272 B
#7683 ObjectExtractorSimpleBody net472 296ns 0.0204ns 0.0764ns 0.0446 0 0 281 B
#7683 ObjectExtractorMoreComplexBody net6.0 6.27μs 28.8ns 112ns 0 0 0 3.78 KB
#7683 ObjectExtractorMoreComplexBody netcoreapp3.1 7.91μs 37ns 148ns 0 0 0 3.69 KB
#7683 ObjectExtractorMoreComplexBody net472 6.64μs 3ns 11.6ns 0.597 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.8μs 234ns 906ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97μs 154ns 596ns 0 0 0 32.4 KB
master EncodeArgs net472 110μs 17.5ns 67.7ns 4.95 0 0 32.51 KB
master EncodeLegacyArgs net6.0 146μs 168ns 652ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 194μs 147ns 570ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 25.4ns 98.5ns 0 0 0 2.16 KB
#7683 EncodeArgs net6.0 75.9μs 354ns 1.37μs 0 0 0 32.4 KB
#7683 EncodeArgs netcoreapp3.1 96.7μs 173ns 672ns 0 0 0 32.4 KB
#7683 EncodeArgs net472 109μs 41.7ns 162ns 4.9 0 0 32.51 KB
#7683 EncodeLegacyArgs net6.0 145μs 48.2ns 174ns 0 0 0 2.15 KB
#7683 EncodeLegacyArgs netcoreapp3.1 200μs 482ns 1.87μs 0 0 0 2.14 KB
#7683 EncodeLegacyArgs net472 262μs 19.3ns 72.2ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 392μs 59.7ns 231ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 411μs 51.8ns 180ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 427μs 26.7ns 96.3ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 285μs 27.5ns 103ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 717μs 3.06μs 13.3μs 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 308μs 27.9ns 108ns 0 0 0 2.29 KB
#7683 RunWafRealisticBenchmark net6.0 395μs 107ns 387ns 0 0 0 4.55 KB
#7683 RunWafRealisticBenchmark netcoreapp3.1 409μs 194ns 699ns 0 0 0 4.48 KB
#7683 RunWafRealisticBenchmark net472 427μs 50.8ns 197ns 0 0 0 4.66 KB
#7683 RunWafRealisticBenchmarkWithAttack net6.0 286μs 49.8ns 193ns 0 0 0 2.24 KB
#7683 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 671μs 12.9μs 129μs 0 0 0 2.22 KB
#7683 RunWafRealisticBenchmarkWithAttack net472 309μs 52.1ns 202ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.4μs 52.5ns 203ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.1μs 118ns 441ns 0 0 0 17.42 KB
master SendRequest net472 0.00234ns 0.00128ns 0.00497ns 0 0 0 0 b
#7683 SendRequest net6.0 62.2μs 32ns 124ns 0 0 0 14.52 KB
#7683 SendRequest netcoreapp3.1 72μs 119ns 446ns 0 0 0 17.42 KB
#7683 SendRequest net472 0.00352ns 0.00185ns 0.00715ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7683

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 51 B 47 B -4 B -7.84%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.85ms 5.6μs 21.7μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 2.14ms 3.86μs 15μs 0 0 0 640 KB
master OriginalCharSlice net472 2.61ms 556ns 2.08μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.49ms 225ns 873ns 0 0 0 7 B
master OptimizedCharSlice netcoreapp3.1 1.67ms 377ns 1.46μs 0 0 0 1 B
master OptimizedCharSlice net472 1.9ms 322ns 1.25μs 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 844μs 17.4ns 65.3ns 0 0 0 1 B
master OptimizedCharSliceWithPool netcoreapp3.1 828μs 98.9ns 383ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.17ms 118ns 457ns 0 0 0 51 B
#7683 OriginalCharSlice net6.0 2.04ms 400ns 1.55μs 0 0 0 640.01 KB
#7683 OriginalCharSlice netcoreapp3.1 2.11ms 3.97μs 14.9μs 0 0 0 640 KB
#7683 OriginalCharSlice net472 2.67ms 1.5μs 5.41μs 100 0 0 641.95 KB
#7683 OptimizedCharSlice net6.0 1.53ms 163ns 633ns 0 0 0 7 B
#7683 OptimizedCharSlice netcoreapp3.1 1.71ms 387ns 1.5μs 0 0 0 1 B
#7683 OptimizedCharSlice net472 1.99ms 323ns 1.25μs 0 0 0 73 B
#7683 OptimizedCharSliceWithPool net6.0 798μs 44.1ns 165ns 0 0 0 1 B
#7683 OptimizedCharSliceWithPool netcoreapp3.1 865μs 27.4ns 103ns 0 0 0 1 B
#7683 OptimizedCharSliceWithPool net472 1.15ms 185ns 718ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7683

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.172 666,119.95 780,943.53

More allocations ⚠️ in #7683

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 42.06 KB 42.35 KB 294 B 0.70%

Fewer allocations 🎉 in #7683

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.62 KB 41.54 KB -1.08 KB -2.53%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 757μs 2.57μs 9.94μs 0 0 0 42.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 3.27μs 13.5μs 0 0 0 42.06 KB
master WriteAndFlushEnrichedTraces net472 1.01ms 4.68μs 17.5μs 8.33 0 0 56.32 KB
#7683 WriteAndFlushEnrichedTraces net6.0 683μs 770ns 2.77μs 0 0 0 41.54 KB
#7683 WriteAndFlushEnrichedTraces netcoreapp3.1 762μs 4.39μs 36.7μs 0 0 0 42.35 KB
#7683 WriteAndFlushEnrichedTraces net472 1.01ms 4.44μs 17.2μs 8.33 0 0 56.46 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.96μs 4.59ns 17.2ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.58μs 3.88ns 15ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.85μs 13.8ns 60.3ns 0.155 0.0141 0 987 B
#7683 ExecuteNonQuery net6.0 1.9μs 1.3ns 4.86ns 0 0 0 1.02 KB
#7683 ExecuteNonQuery netcoreapp3.1 2.73μs 2.55ns 9.89ns 0 0 0 1.02 KB
#7683 ExecuteNonQuery net472 2.81μs 7.79ns 30.2ns 0.154 0.014 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.82μs 7.92ns 29.6ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.32μs 7.45ns 28.8ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.51μs 1.27ns 4.75ns 0.158 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.9μs 9.47ns 40.2ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.43μs 11.5ns 42.9ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.7μs 5.37ns 20.8ns 0.167 0 0 1.1 KB
#7683 CallElasticsearch net6.0 1.76μs 2.43ns 9.1ns 0 0 0 1.03 KB
#7683 CallElasticsearch netcoreapp3.1 2.33μs 10.7ns 41.3ns 0 0 0 1.03 KB
#7683 CallElasticsearch net472 3.72μs 6ns 23.2ns 0.165 0 0 1.04 KB
#7683 CallElasticsearchAsync net6.0 1.87μs 1.88ns 7.3ns 0 0 0 1.01 KB
#7683 CallElasticsearchAsync netcoreapp3.1 2.49μs 11.3ns 45.3ns 0 0 0 1.08 KB
#7683 CallElasticsearchAsync net472 3.86μs 5.79ns 21.7ns 0.155 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.88μs 1.22ns 4.73ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.38μs 9.39ns 36.4ns 0 0 0 952 B
master ExecuteAsync net472 2.57μs 1.2ns 4.65ns 0.142 0 0 915 B
#7683 ExecuteAsync net6.0 1.8μs 5.58ns 21.6ns 0 0 0 952 B
#7683 ExecuteAsync netcoreapp3.1 2.34μs 2.75ns 10.7ns 0 0 0 952 B
#7683 ExecuteAsync net472 2.65μs 2.56ns 9.24ns 0.133 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.9μs 18.5ns 71.7ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.76μs 8.07ns 31.2ns 0 0 0 2.9 KB
master SendAsync net472 12.4μs 9.57ns 37.1ns 0.5 0 0 3.18 KB
#7683 SendAsync net6.0 6.8μs 26ns 101ns 0 0 0 2.36 KB
#7683 SendAsync netcoreapp3.1 8.68μs 24ns 93ns 0 0 0 2.9 KB
#7683 SendAsync net472 12.2μs 15ns 58ns 0.486 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7683

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.124 461,500.00 518,800.00

More allocations ⚠️ in #7683

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.94 KB 87.84 KB 44.9 KB 104.55%

Fewer allocations 🎉 in #7683

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.78 KB 43.1 KB -672 B -1.54%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 275.62 KB 261.7 KB -13.93 KB -5.05%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 43.7μs 193ns 722ns 0 0 0 43.78 KB
master StringConcatBenchmark netcoreapp3.1 50.5μs 318ns 3.07μs 0 0 0 42.94 KB
master StringConcatBenchmark net472 57.6μs 166ns 597ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 461μs 2.05μs 7.4μs 0 0 0 275.62 KB
master StringConcatAspectBenchmark netcoreapp3.1 546μs 2.07μs 7.46μs 0 0 0 275.26 KB
master StringConcatAspectBenchmark net472 401μs 2.2μs 13.4μs 0 0 0 278.53 KB
#7683 StringConcatBenchmark net6.0 42.4μs 177ns 638ns 0 0 0 43.1 KB
#7683 StringConcatBenchmark netcoreapp3.1 50.3μs 293ns 2.56μs 0 0 0 87.84 KB
#7683 StringConcatBenchmark net472 56.4μs 280ns 1.19μs 0 0 0 57.34 KB
#7683 StringConcatAspectBenchmark net6.0 520μs 2.65μs 11.6μs 0 0 0 261.7 KB
#7683 StringConcatAspectBenchmark netcoreapp3.1 526μs 2.22μs 7.99μs 0 0 0 274.98 KB
#7683 StringConcatAspectBenchmark net472 405μs 2.14μs 11.7μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.62μs 12.3ns 50.7ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.69μs 17.9ns 75.9ns 0 0 0 1.7 KB
master EnrichedLog net472 3.79μs 4.7ns 18.2ns 0.245 0 0 1.64 KB
#7683 EnrichedLog net6.0 2.53μs 13.8ns 75.7ns 0 0 0 1.7 KB
#7683 EnrichedLog netcoreapp3.1 3.53μs 17.2ns 76.8ns 0 0 0 1.7 KB
#7683 EnrichedLog net472 3.81μs 5.43ns 21ns 0.247 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 125μs 556ns 2.08μs 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 128μs 82.3ns 297ns 0 0 0 4.31 KB
master EnrichedLog net472 167μs 105ns 378ns 0 0 0 4.52 KB
#7683 EnrichedLog net6.0 123μs 47.2ns 170ns 0 0 0 4.31 KB
#7683 EnrichedLog netcoreapp3.1 127μs 416ns 1.61μs 0 0 0 4.31 KB
#7683 EnrichedLog net472 167μs 183ns 709ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5μs 7.6ns 28.4ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.78μs 13.2ns 51.3ns 0 0 0 2.26 KB
master EnrichedLog net472 7.83μs 5.89ns 22.8ns 0.309 0 0 2.08 KB
#7683 EnrichedLog net6.0 4.85μs 3.4ns 12.7ns 0 0 0 2.26 KB
#7683 EnrichedLog netcoreapp3.1 6.74μs 23ns 89.3ns 0 0 0 2.26 KB
#7683 EnrichedLog net472 7.64μs 7.85ns 28.3ns 0.306 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.99μs 9.43ns 38.9ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.62μs 12.2ns 47.2ns 0 0 0 1.2 KB
master SendReceive net472 3.22μs 7.71ns 29.8ns 0.19 0 0 1.2 KB
#7683 SendReceive net6.0 2.02μs 9.63ns 39.7ns 0 0 0 1.2 KB
#7683 SendReceive netcoreapp3.1 2.6μs 6.08ns 23.5ns 0 0 0 1.2 KB
#7683 SendReceive net472 3.16μs 1.99ns 7.7ns 0.189 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.24μs 4.78ns 17.2ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.63μs 1.92ns 6.91ns 0 0 0 1.63 KB
master EnrichedLog net472 6.76μs 5.57ns 21.6ns 0.301 0 0 2.03 KB
#7683 EnrichedLog net6.0 4.4μs 10.7ns 41.4ns 0 0 0 1.58 KB
#7683 EnrichedLog netcoreapp3.1 5.52μs 20ns 77.5ns 0 0 0 1.63 KB
#7683 EnrichedLog net472 6.78μs 19ns 73.7ns 0.305 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 764ns 4.14ns 23ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 942ns 5.18ns 27.4ns 0 0 0 576 B
master StartFinishSpan net472 940ns 0.128ns 0.478ns 0.0893 0 0 578 B
master StartFinishScope net6.0 883ns 4.91ns 29ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.16μs 5.83ns 26.1ns 0 0 0 696 B
master StartFinishScope net472 1.12μs 0.0994ns 0.385ns 0.101 0 0 658 B
#7683 StartFinishSpan net6.0 761ns 4.16ns 25ns 0 0 0 576 B
#7683 StartFinishSpan netcoreapp3.1 960ns 4.94ns 22.1ns 0 0 0 576 B
#7683 StartFinishSpan net472 920ns 0.574ns 2.15ns 0.0877 0 0 578 B
#7683 StartFinishScope net6.0 929ns 5.01ns 26ns 0 0 0 696 B
#7683 StartFinishScope netcoreapp3.1 1.16μs 6.25ns 31.9ns 0 0 0 697 B
#7683 StartFinishScope net472 1.08μs 0.481ns 1.86ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.08μs 1.44ns 5.6ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.48μs 6.46ns 25ns 0 0 0 696 B
master RunOnMethodBegin net472 1.41μs 0.715ns 2.68ns 0.0983 0 0 658 B
#7683 RunOnMethodBegin net6.0 1.1μs 2.83ns 10.9ns 0 0 0 696 B
#7683 RunOnMethodBegin netcoreapp3.1 1.43μs 6.97ns 29.6ns 0 0 0 696 B
#7683 RunOnMethodBegin net472 1.44μs 0.871ns 3.37ns 0.102 0 0 658 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tonyredondo