Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] DEBUG-3298 Handle symbols without names #6578

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Dynamic Instrumentation] DEBUG-3298 Handle symbols without names #6578

wants to merge 2 commits into from
+238 −129

Conversation

dudikeleti
Copy link
Contributor

Summary of changes

We don't want to upload symbols that don't have name because it's useless for the customer

@dudikeleti dudikeleti requested a review from a team as a code owner January 21, 2025 08:55
@dudikeleti dudikeleti requested a review from shurivich January 21, 2025 08:56
@andrewlock
Copy link
Member

andrewlock commented Jan 21, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6578) - mean (69ms)  : 66, 72
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6578) - mean (981ms)  : 963, 999
     .   : milestone, 981,
    master - mean (985ms)  : 961, 1010
     .   : milestone, 985,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6578) - mean (108ms)  : 105, 110
     .   : milestone, 108,
    master - mean (109ms)  : 106, 111
     .   : milestone, 109,

    section CallTarget+Inlining+NGEN
    This PR (6578) - mean (684ms)  : 669, 698
     .   : milestone, 684,
    master - mean (684ms)  : 667, 701
     .   : milestone, 684,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6578) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (92ms)  : 90, 93
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6578) - mean (637ms)  : 619, 655
     .   : milestone, 637,
    master - mean (635ms)  : 619, 650
     .   : milestone, 635,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6578) - mean (189ms)  : 185, 194
     .   : milestone, 189,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6578) - mean (1,083ms)  : 1053, 1114
     .   : milestone, 1083,
    master - mean (1,087ms)  : 1062, 1113
     .   : milestone, 1087,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6578) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (275ms)  : 271, 280
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6578) - mean (873ms)  : 842, 904
     .   : milestone, 873,
    master - mean (874ms)  : 845, 903
     .   : milestone, 874,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6578) - mean (264ms)  : 259, 269
     .   : milestone, 264,
    master - mean (265ms)  : 262, 268
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6578) - mean (849ms)  : 817, 882
     .   : milestone, 849,
    master - mean (854ms)  : 823, 884
     .   : milestone, 854,
Loading

@andrewlock
Copy link
Member

andrewlock commented Jan 21, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6578 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.124
  • 1 benchmarks are slower, with geometric mean 1.248
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.93μs 34.4ns 150ns 0.0159 0.00396 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.1μs 46.5ns 180ns 0.0147 0.00491 0 5.81 KB
master StartStopWithChild net472 16.4μs 47.6ns 184ns 1.04 0.296 0.0986 6.21 KB
#6578 StartStopWithChild net6.0 8.05μs 43.7ns 262ns 0.0205 0.00821 0 5.61 KB
#6578 StartStopWithChild netcoreapp3.1 9.89μs 54.7ns 333ns 0.014 0.00468 0 5.81 KB
#6578 StartStopWithChild net472 16.2μs 46ns 172ns 1.05 0.33 0.0966 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 465μs 317ns 1.23μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 670μs 293ns 1.13μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 861μs 342ns 1.28μs 0.428 0 0 3.3 KB
#6578 WriteAndFlushEnrichedTraces net6.0 486μs 517ns 1.94μs 0 0 0 2.7 KB
#6578 WriteAndFlushEnrichedTraces netcoreapp3.1 658μs 317ns 1.19μs 0 0 0 2.7 KB
#6578 WriteAndFlushEnrichedTraces net472 842μs 397ns 1.48μs 0.422 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 130μs 446ns 1.73μs 0.132 0 0 14.47 KB
master SendRequest netcoreapp3.1 146μs 453ns 1.75μs 0.219 0 0 17.27 KB
master SendRequest net472 0.0127ns 0.00368ns 0.0143ns 0 0 0 0 b
#6578 SendRequest net6.0 128μs 321ns 1.24μs 0.193 0 0 14.47 KB
#6578 SendRequest netcoreapp3.1 149μs 250ns 969ns 0.223 0 0 17.27 KB
#6578 SendRequest net472 0.017ns 0.00337ns 0.0126ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 586μs 3.04μs 14.6μs 0.573 0 0 41.69 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 711μs 3.94μs 24μs 0.351 0 0 41.49 KB
master WriteAndFlushEnrichedTraces net472 869μs 4.42μs 19.3μs 8.19 2.59 0.431 53.31 KB
#6578 WriteAndFlushEnrichedTraces net6.0 563μs 1.97μs 7.37μs 0.539 0 0 41.68 KB
#6578 WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 3.57μs 20.2μs 0.342 0 0 41.6 KB
#6578 WriteAndFlushEnrichedTraces net472 844μs 3.97μs 15.4μs 8.19 2.59 0.431 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.26μs 1.17ns 4.51ns 0.0145 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.79μs 2.25ns 8.73ns 0.0134 0 0 1.02 KB
master ExecuteNonQuery net472 1.95μs 2.3ns 8.9ns 0.156 0.000976 0 987 B
#6578 ExecuteNonQuery net6.0 1.23μs 1.26ns 4.71ns 0.0141 0 0 1.02 KB
#6578 ExecuteNonQuery netcoreapp3.1 1.85μs 2.11ns 7.59ns 0.0137 0 0 1.02 KB
#6578 ExecuteNonQuery net472 2.1μs 2.34ns 9.06ns 0.156 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.3μs 0.645ns 2.41ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 1.2ns 4.63ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.53μs 1.93ns 7.46ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.33μs 0.594ns 2.22ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.6μs 0.998ns 3.73ns 0.0135 0 0 1.02 KB
master CallElasticsearchAsync net472 2.69μs 1.18ns 4.27ns 0.166 0 0 1.05 KB
#6578 CallElasticsearch net6.0 1.19μs 2.3ns 8.9ns 0.0136 0 0 976 B
#6578 CallElasticsearch netcoreapp3.1 1.54μs 0.725ns 2.71ns 0.013 0 0 976 B
#6578 CallElasticsearch net472 2.57μs 1.57ns 5.86ns 0.158 0 0 995 B
#6578 CallElasticsearchAsync net6.0 1.33μs 0.358ns 1.38ns 0.0133 0 0 952 B
#6578 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.87ns 3.25ns 0.0141 0 0 1.02 KB
#6578 CallElasticsearchAsync net472 2.68μs 1.64ns 6.34ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.34μs 0.474ns 1.77ns 0.0135 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.58μs 1.62ns 6.07ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.86μs 0.532ns 2.06ns 0.145 0 0 915 B
#6578 ExecuteAsync net6.0 1.22μs 0.697ns 2.7ns 0.0135 0 0 952 B
#6578 ExecuteAsync netcoreapp3.1 1.59μs 1.24ns 4.8ns 0.0128 0 0 952 B
#6578 ExecuteAsync net472 1.81μs 0.704ns 2.63ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.35μs 2.24ns 8.39ns 0.0329 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.33μs 2.03ns 7.85ns 0.0373 0 0 2.85 KB
master SendAsync net472 7.34μs 1.84ns 7.11ns 0.495 0 0 3.12 KB
#6578 SendAsync net6.0 4.39μs 1.73ns 6.46ns 0.031 0 0 2.31 KB
#6578 SendAsync netcoreapp3.1 5.22μs 2.44ns 9.47ns 0.0368 0 0 2.85 KB
#6578 SendAsync net472 7.53μs 1.35ns 5.05ns 0.493 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.43μs 1.14ns 4.25ns 0.0229 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.23μs 0.685ns 2.47ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.54μs 1.49ns 5.77ns 0.25 0 0 1.57 KB
#6578 EnrichedLog net6.0 1.52μs 0.569ns 2.13ns 0.0226 0 0 1.64 KB
#6578 EnrichedLog netcoreapp3.1 2.16μs 1.34ns 5.18ns 0.0217 0 0 1.64 KB
#6578 EnrichedLog net472 2.58μs 0.593ns 2.14ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 112ns 433ns 0.0579 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 254ns 951ns 0 0 0 4.28 KB
master EnrichedLog net472 151μs 142ns 549ns 0.684 0.228 0 4.46 KB
#6578 EnrichedLog net6.0 116μs 99.7ns 386ns 0.058 0 0 4.28 KB
#6578 EnrichedLog netcoreapp3.1 120μs 113ns 436ns 0.06 0 0 4.28 KB
#6578 EnrichedLog net472 151μs 93ns 348ns 0.679 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.98μs 1.02ns 3.94ns 0.0309 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.13μs 2.63ns 10.2ns 0.0289 0 0 2.2 KB
master EnrichedLog net472 4.98μs 1.33ns 5.13ns 0.32 0 0 2.02 KB
#6578 EnrichedLog net6.0 3.08μs 0.872ns 3.38ns 0.0308 0 0 2.2 KB
#6578 EnrichedLog netcoreapp3.1 4.13μs 3.09ns 12ns 0.0287 0 0 2.2 KB
#6578 EnrichedLog net472 4.89μs 0.774ns 2.79ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.32μs 0.755ns 2.92ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.81μs 0.395ns 1.42ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.22μs 1.12ns 4.33ns 0.183 0 0 1.16 KB
#6578 SendReceive net6.0 1.31μs 0.592ns 2.29ns 0.0159 0 0 1.14 KB
#6578 SendReceive netcoreapp3.1 1.75μs 1.38ns 5.17ns 0.0157 0 0 1.14 KB
#6578 SendReceive net472 2.24μs 0.801ns 2.78ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.82μs 1.18ns 4.57ns 0.0226 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.81μs 1.45ns 5.63ns 0.021 0 0 1.65 KB
master EnrichedLog net472 4.31μs 6.23ns 24.1ns 0.322 0 0 2.04 KB
#6578 EnrichedLog net6.0 2.95μs 0.917ns 3.55ns 0.0225 0 0 1.6 KB
#6578 EnrichedLog netcoreapp3.1 3.9μs 3.95ns 15.3ns 0.0216 0 0 1.65 KB
#6578 EnrichedLog net472 4.34μs 3.15ns 12.2ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6578

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.127 452.77 401.75
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.121 535.98 478.22

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 452ns 0.614ns 2.38ns 0.00813 0 0 576 B
master StartFinishSpan netcoreapp3.1 564ns 0.835ns 3.01ns 0.00773 0 0 576 B
master StartFinishSpan net472 600ns 1.25ns 4.84ns 0.0918 0 0 578 B
master StartFinishScope net6.0 536ns 0.73ns 2.83ns 0.00984 0 0 696 B
master StartFinishScope netcoreapp3.1 687ns 1.67ns 6.48ns 0.00963 0 0 696 B
master StartFinishScope net472 868ns 1.77ns 6.84ns 0.104 0 0 658 B
#6578 StartFinishSpan net6.0 402ns 0.418ns 1.62ns 0.00814 0 0 576 B
#6578 StartFinishSpan netcoreapp3.1 571ns 0.949ns 3.68ns 0.0078 0 0 576 B
#6578 StartFinishSpan net472 658ns 1.28ns 4.94ns 0.0917 0 0 578 B
#6578 StartFinishScope net6.0 477ns 0.844ns 3.27ns 0.00966 0 0 696 B
#6578 StartFinishScope netcoreapp3.1 719ns 0.967ns 3.75ns 0.00939 0 0 696 B
#6578 StartFinishScope net472 826ns 1.5ns 5.8ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6578

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.248 851.90 1,063.08

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 626ns 0.918ns 3.56ns 0.00978 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 853ns 1.3ns 5.02ns 0.00942 0 0 696 B
master RunOnMethodBegin net472 1.02μs 2ns 7.73ns 0.104 0 0 658 B
#6578 RunOnMethodBegin net6.0 611ns 1.02ns 3.95ns 0.00985 0 0 696 B
#6578 RunOnMethodBegin netcoreapp3.1 1.06μs 2.56ns 9.91ns 0.00946 0 0 696 B
#6578 RunOnMethodBegin net472 1.11μs 2.24ns 8.67ns 0.105 0 0 658 B

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 21, 2025 •
edited
Loading

Datadog Report

Branch report: dudik/symdb-empty-symbols
Commit report: 150e4b3
Test service: dd-trace-dotnet

✅ 0 Failed, 247280 Passed, 2824 Skipped, 32h 20m 30.55s Total Time

@dudikeleti dudikeleti force-pushed the dudik/symdb-empty-symbols branch from 9200c1b to 150e4b3 Compare January 22, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shurivich shurivich Awaiting requested review from shurivich

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudikeleti @andrewlock