Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Package Versions Bump] Updating package versions #6558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Updates the package versions for integration tests.

@github-actions github-actions bot requested review from a team as code owners January 15, 2025 16:56
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 15, 2025

Datadog Report

Branch report: bot/test-package-versions-bump
Commit report: bc930d4
Test service: dd-trace-dotnet

❌ 100 Failed (0 Known Flaky), 242634 Passed, 1967 Skipped, 18h 49m 33.66s Total Time
⌛ 1 Performance Regression

❌ Failed Tests (100)

This report shows up to 5 failed tests.

  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     application not found: /project/artifacts/publish/Samples.DataStreams.RabbitMQ/release_netcoreapp3.1_6.8.1/Samples.DataStreams.RabbitMQ.dll
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     application not found: /project/artifacts/publish/Samples.DataStreams.RabbitMQ/release_netcoreapp3.1_3.6.9/Samples.DataStreams.RabbitMQ.dll
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     application not found: /project/artifacts/publish/Samples.DataStreams.RabbitMQ/release_netcoreapp3.1_5.2.0/Samples.DataStreams.RabbitMQ.dll
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     application not found: /project/artifacts/publish/Samples.DataStreams.RabbitMQ/release_netcoreapp3.1_4.1.3/Samples.DataStreams.RabbitMQ.dll
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     application not found: /project/artifacts/publish/Samples.DataStreams.RabbitMQ/release_netcoreapp3.1_7.0.0/Samples.DataStreams.RabbitMQ.dll
    

⌛ Performance Regressions vs Default Branch (1)

  • Profiler_allocation - scenarios 2.24s (+96.35ms, +4%) - Details

@andrewlock
Copy link
Member

andrewlock commented Jan 15, 2025

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6558) - mean (70ms)  : 64, 75
     .   : milestone, 70,
    master - mean (69ms)  : 64, 75
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6558) - mean (985ms)  : 962, 1007
     .   : milestone, 985,
    master - mean (982ms)  : 955, 1009
     .   : milestone, 982,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6558) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6558) - mean (684ms)  : 670, 698
     .   : milestone, 684,
    master - mean (679ms)  : 661, 698
     .   : milestone, 679,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6558) - mean (92ms)  : 90, 93
     .   : milestone, 92,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6558) - mean (638ms)  : 625, 651
     .   : milestone, 638,
    master - mean (635ms)  : 620, 650
     .   : milestone, 635,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6558) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (189ms)  : 184, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6558) - mean (1,092ms)  : 1055, 1129
     .   : milestone, 1092,
    master - mean (1,084ms)  : 1053, 1115
     .   : milestone, 1084,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6558) - mean (276ms)  : 270, 282
     .   : milestone, 276,
    master - mean (275ms)  : 270, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (6558) - mean (870ms)  : 844, 897
     .   : milestone, 870,
    master - mean (873ms)  : 836, 910
     .   : milestone, 873,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6558) - mean (265ms)  : 258, 271
     .   : milestone, 265,
    master - mean (263ms)  : 259, 267
     .   : milestone, 263,

    section CallTarget+Inlining+NGEN
    This PR (6558) - mean (850ms)  : 812, 887
     .   : milestone, 850,
    master - mean (849ms)  : 814, 885
     .   : milestone, 849,

Loading

@andrewlock
Copy link
Member

andrewlock commented Jan 16, 2025

Benchmarks Report for tracer 🐌

Benchmarks for #6558 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.125
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.17μs 46ns 312ns 0.0159 0.00397 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.2μs 56.5ns 348ns 0.0197 0.00986 0 5.8 KB
master StartStopWithChild net472 16μs 43ns 161ns 1.05 0.322 0.0967 6.22 KB
#6558 StartStopWithChild net6.0 7.96μs 35.5ns 123ns 0.0152 0.0076 0 5.61 KB
#6558 StartStopWithChild netcoreapp3.1 10.1μs 55.4ns 337ns 0.02 0.00499 0 5.8 KB
#6558 StartStopWithChild net472 16.3μs 41.4ns 160ns 1.04 0.315 0.108 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 526μs 1.46μs 5.65μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 652μs 189ns 653ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 837μs 406ns 1.57μs 0.417 0 0 3.3 KB
#6558 WriteAndFlushEnrichedTraces net6.0 483μs 193ns 722ns 0 0 0 2.7 KB
#6558 WriteAndFlushEnrichedTraces netcoreapp3.1 675μs 491ns 1.9μs 0 0 0 2.7 KB
#6558 WriteAndFlushEnrichedTraces net472 852μs 588ns 2.28μs 0.425 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 133μs 506ns 1.96μs 0.186 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 333ns 1.29μs 0.218 0 0 17.27 KB
master SendRequest net472 0.00622ns 0.00194ns 0.00751ns 0 0 0 0 b
#6558 SendRequest net6.0 129μs 455ns 1.76μs 0.129 0 0 14.47 KB
#6558 SendRequest netcoreapp3.1 144μs 384ns 1.49μs 0.215 0 0 17.27 KB
#6558 SendRequest net472 0.00284ns 0.00182ns 0.00705ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 550μs 2.07μs 7.76μs 0.534 0 0 41.66 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 683μs 3.81μs 29.7μs 0.322 0 0 41.73 KB
master WriteAndFlushEnrichedTraces net472 839μs 3.82μs 14.8μs 8.45 2.53 0.422 53.29 KB
#6558 WriteAndFlushEnrichedTraces net6.0 564μs 2.89μs 17.8μs 0.587 0 0 41.58 KB
#6558 WriteAndFlushEnrichedTraces netcoreapp3.1 684μs 3.91μs 28.7μs 0.326 0 0 41.81 KB
#6558 WriteAndFlushEnrichedTraces net472 845μs 3.63μs 14.1μs 8.12 2.44 0.406 53.29 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.32μs 0.563ns 2.03ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.77μs 1.87ns 7.23ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.07μs 2.57ns 9.95ns 0.157 0.00104 0 987 B
#6558 ExecuteNonQuery net6.0 1.26μs 1.56ns 6.04ns 0.0145 0 0 1.02 KB
#6558 ExecuteNonQuery netcoreapp3.1 1.77μs 2.41ns 9.34ns 0.0138 0 0 1.02 KB
#6558 ExecuteNonQuery net472 2.07μs 1.95ns 7.56ns 0.156 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6558

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0 1.114 1,268.95 1,413.77

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.872ns 3.38ns 0.0135 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.5μs 0.619ns 2.32ns 0.0135 0 0 976 B
master CallElasticsearch net472 2.55μs 1.56ns 5.82ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.27μs 0.712ns 2.66ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 1.04ns 4.03ns 0.0144 0 0 1.02 KB
master CallElasticsearchAsync net472 2.59μs 1.31ns 4.9ns 0.167 0 0 1.05 KB
#6558 CallElasticsearch net6.0 1.25μs 0.301ns 1.13ns 0.0137 0 0 976 B
#6558 CallElasticsearch netcoreapp3.1 1.53μs 0.996ns 3.73ns 0.013 0 0 976 B
#6558 CallElasticsearch net472 2.53μs 1.69ns 6.55ns 0.158 0 0 995 B
#6558 CallElasticsearchAsync net6.0 1.41μs 0.568ns 2.2ns 0.0135 0 0 952 B
#6558 CallElasticsearchAsync netcoreapp3.1 1.74μs 0.655ns 2.36ns 0.0133 0 0 1.02 KB
#6558 CallElasticsearchAsync net472 2.67μs 1.4ns 5.41ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.21μs 0.593ns 2.22ns 0.013 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.77μs 1.17ns 4.4ns 0.0131 0 0 952 B
master ExecuteAsync net472 1.89μs 0.508ns 1.97ns 0.145 0 0 915 B
#6558 ExecuteAsync net6.0 1.29μs 0.633ns 2.45ns 0.0129 0 0 952 B
#6558 ExecuteAsync netcoreapp3.1 1.62μs 4.27ns 16.6ns 0.0126 0 0 952 B
#6558 ExecuteAsync net472 1.88μs 0.481ns 1.73ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.52μs 1.39ns 5.21ns 0.0315 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.3μs 4.79ns 18.5ns 0.0368 0 0 2.85 KB
master SendAsync net472 7.4μs 1.43ns 5.35ns 0.495 0 0 3.12 KB
#6558 SendAsync net6.0 4.47μs 1.6ns 5.99ns 0.0314 0 0 2.31 KB
#6558 SendAsync netcoreapp3.1 5.15μs 1.97ns 7.65ns 0.0385 0 0 2.85 KB
#6558 SendAsync net472 7.37μs 1.16ns 4.51ns 0.496 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.98ns 3.67ns 0.0231 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.12μs 1.62ns 6.07ns 0.0222 0 0 1.64 KB
master EnrichedLog net472 2.74μs 1.5ns 5.8ns 0.25 0 0 1.57 KB
#6558 EnrichedLog net6.0 1.54μs 0.808ns 3.13ns 0.023 0 0 1.64 KB
#6558 EnrichedLog netcoreapp3.1 2.19μs 2.51ns 9.4ns 0.0219 0 0 1.64 KB
#6558 EnrichedLog net472 2.55μs 2.11ns 8.18ns 0.25 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 189ns 732ns 0.0569 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 206ns 798ns 0 0 0 4.28 KB
master EnrichedLog net472 149μs 72.5ns 271ns 0.668 0.223 0 4.46 KB
#6558 EnrichedLog net6.0 116μs 208ns 805ns 0.0586 0 0 4.28 KB
#6558 EnrichedLog netcoreapp3.1 120μs 182ns 680ns 0 0 0 4.28 KB
#6558 EnrichedLog net472 150μs 83ns 299ns 0.677 0.226 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.01μs 1.07ns 4.13ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.23μs 1.89ns 7.32ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.84μs 0.408ns 1.47ns 0.32 0 0 2.02 KB
#6558 EnrichedLog net6.0 3.01μs 0.67ns 2.6ns 0.0317 0 0 2.2 KB
#6558 EnrichedLog netcoreapp3.1 4.31μs 1.86ns 7.21ns 0.03 0 0 2.2 KB
#6558 EnrichedLog net472 4.99μs 0.786ns 2.83ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 1.18ns 4.41ns 0.0159 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.75μs 5.92ns 22.9ns 0.0158 0 0 1.14 KB
master SendReceive net472 2.12μs 0.722ns 2.8ns 0.183 0 0 1.16 KB
#6558 SendReceive net6.0 1.39μs 0.818ns 3.17ns 0.016 0 0 1.14 KB
#6558 SendReceive netcoreapp3.1 1.8μs 1.59ns 6.16ns 0.0154 0 0 1.14 KB
#6558 SendReceive net472 2.1μs 1.91ns 7.4ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.71μs 0.648ns 2.34ns 0.0216 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.85μs 1.65ns 5.94ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.43μs 3.58ns 13.8ns 0.324 0 0 2.04 KB
#6558 EnrichedLog net6.0 2.73μs 1.04ns 4.04ns 0.0221 0 0 1.6 KB
#6558 EnrichedLog netcoreapp3.1 3.92μs 2.31ns 8.93ns 0.0216 0 0 1.65 KB
#6558 EnrichedLog net472 4.4μs 11.9ns 46.2ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6558

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472 1.136 604.50 686.58

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.496ns 1.92ns 0.00815 0 0 576 B
master StartFinishSpan netcoreapp3.1 568ns 1.8ns 6.98ns 0.00775 0 0 576 B
master StartFinishSpan net472 604ns 0.974ns 3.77ns 0.0918 0 0 578 B
master StartFinishScope net6.0 477ns 0.702ns 2.72ns 0.00967 0 0 696 B
master StartFinishScope netcoreapp3.1 665ns 1.03ns 3.97ns 0.00935 0 0 696 B
master StartFinishScope net472 874ns 1.41ns 5.47ns 0.104 0 0 658 B
#6558 StartFinishSpan net6.0 398ns 0.469ns 1.82ns 0.00805 0 0 576 B
#6558 StartFinishSpan netcoreapp3.1 541ns 0.708ns 2.74ns 0.00784 0 0 576 B
#6558 StartFinishSpan net472 687ns 1.26ns 4.88ns 0.0915 0 0 578 B
#6558 StartFinishScope net6.0 532ns 0.803ns 3.11ns 0.00965 0 0 696 B
#6558 StartFinishScope netcoreapp3.1 720ns 1.25ns 4.84ns 0.00932 0 0 696 B
#6558 StartFinishScope net472 926ns 1.39ns 5.4ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 646ns 0.639ns 2.48ns 0.00962 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 905ns 1.14ns 4.43ns 0.00912 0 0 696 B
master RunOnMethodBegin net472 1.11μs 2.23ns 8.64ns 0.104 0 0 658 B
#6558 RunOnMethodBegin net6.0 619ns 1.03ns 4ns 0.0096 0 0 696 B
#6558 RunOnMethodBegin netcoreapp3.1 938ns 1.08ns 4.2ns 0.00929 0 0 696 B
#6558 RunOnMethodBegin net472 1.04μs 1.21ns 4.7ns 0.104 0 0 658 B

Comment on lines +158 to +159
<!-- Latest package https://www.nuget.org/packages/Microsoft.AspNetCore.StaticFiles/2.3.0 -->
<PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.3.0" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urgh, oh yeah, the .NET Core 2.1 rename to 2.3... fun... I wonder how we should go about testing this...

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch 2 times, most recently from 3a79b25 to be3af72 Compare January 19, 2025 00:24
Comment on lines +51 to 52
<!-- Latest package https://www.nuget.org/packages/Azure.Messaging.ServiceBus/7.18.3 -->
<PackageReference Include="Azure.Messaging.ServiceBus" Version="7.17.5" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs manual testing

@github-actions github-actions bot force-pushed the bot/test-package-versions-bump branch from be3af72 to bc930d4 Compare January 20, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant