Update libddwaf to v1.24.1 #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasShabi
reviewed
Apr 24, 2025
IlyasShabi
reviewed
Apr 24, 2025
IlyasShabi
reviewed
Apr 25, 2025
| it('should throw a type error when updating a WAF instance with invalid arguments', () => { | ||
| const waf = new DDWAF(rules) | ||
| assert.throws(() => waf.update('string'), new TypeError('First argument must be an object')) | ||
| describe('Remove config', () => { |
There was a problem hiding this comment.
IMO it's also good to check waf.configPaths value after each remove
IlyasShabi
reviewed
Apr 25, 2025
| waf.dispose() | ||
| assert.throws(() => waf.update(rules), new Error('Could not update a disposed WAF instance')) | ||
| }) | ||
| describe('Update config', () => { |
There was a problem hiding this comment.
Could we have to check that the old handle still alive when an new empty config (wrong) is applied ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
libddwafto v1.24.1Motivation
libddwafchanged its interface in v1.23.0 with breaking changes in order to move the configuration update management from the tracer to the library.Additional Notes
Upgrading guide