Share common types between Autoscaler versions #1663
+1,362
−1,929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 218 218
Lines 21244 21244
=======================================
Hits 10515 10515
Misses 10182 10182
Partials 547 547
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
vboulineau
force-pushed
the
vboulineau/dpa-common
branch
3 times, most recently
from
1f18c4b to
bcee78a
Compare
vboulineau
force-pushed
the
vboulineau/dpa-common
branch
3 times, most recently
from
ceeeba6 to
1c6451e
Compare
vboulineau
force-pushed
the
vboulineau/dpa-common
branch
from
1c6451e to
380fff1
Compare
fisherevans
approved these changes
Feb 11, 2025
tbavelier
approved these changes
Feb 12, 2025
Comment on lines
+16
to
+20
| // NewPointer returns a pointer to a new value instance | ||
| func NewPointer[T any](v T) *T { | ||
| return &v | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| // NewPointer returns a pointer to a new value instance | |
| func NewPointer[T any](v T) *T { | |
| return &v | |
| } | |
| // NewUInt64Pointer returns pointer on a new uint64 value instance | |
| func NewUInt64Pointer(i uint64) *uint64 { | |
| return &i | |
| } |
This NewPointer is solely used for uint64 as a new "case", while all other uses can be replaced with existing NewInt32Pointer, NewBoolPointer, but no strong opinion
| APIVersion: "apps/v1", | ||
| }, | ||
| Owner: "test-owner", | ||
| RemoteVersion: utils.NewPointer[uint64](10), |
There was a problem hiding this comment.
Suggested change
| RemoteVersion: utils.NewPointer[uint64](10), | |
| RemoteVersion: utils.NewUInt64Pointer(10), |
See comment on utils.go file
| Name: v1.ResourceCPU, | ||
| Value: common.DatadogPodAutoscalerTargetValue{ | ||
| Type: common.DatadogPodAutoscalerUtilizationTargetValueType, | ||
| Utilization: utils.NewPointer[int32](80), |
There was a problem hiding this comment.
Suggested change
| Utilization: utils.NewPointer[int32](80), | |
| Utilization: utils.NewInt32Pointer(80), |
Ditto
celenechang
approved these changes
Feb 12, 2025
| return nil | ||
| } | ||
|
|
||
| // As many type are shared, we'll assign the deep copied value to the new object |
There was a problem hiding this comment.
Suggested change
| // As many type are shared, we'll assign the deep copied value to the new object | |
| // As many types are shared, we'll assign the deep copied value to the new object |
| return nil | ||
| } | ||
|
|
||
| // As many type are shared, we'll assign the deep copied value to the new object |
There was a problem hiding this comment.
Suggested change
| // As many type are shared, we'll assign the deep copied value to the new object | |
| // As many types are shared, we'll assign the deep copied value to the new object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Share common types between Autoscaler versions to avoid useless conversions.
Motivation
Additional Notes
Minimum Agent Versions
Describe your test plan
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel