Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CECO-1860][DatadogGenericResource](refactor 2) Add monitor support #1641

Open
wants to merge 2 commits into
base: tbavelier/generic_resource_re_refactor
Choose a base branch
from

Conversation

tbavelier
Copy link
Member

What does this PR do?

Same as #1635 but for the "refactor" part 2 #1640

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@tbavelier tbavelier added the enhancement New feature or request label Jan 24, 2025
@tbavelier tbavelier added this to the v1.13.0 milestone Jan 24, 2025
@tbavelier tbavelier requested a review from a team as a code owner January 24, 2025 16:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.

Project coverage is 49.15%. Comparing base (fc444c5) to head (618a5df).

Files with missing lines Patch % Lines
...rnal/controller/datadoggenericresource/monitors.go 0.00% 55 Missing ⚠️
pkg/datadogclient/client.go 0.00% 7 Missing ⚠️
...nternal/controller/datadoggenericresource/utils.go 0.00% 6 Missing ⚠️
...al/controller/datadoggenericresource/controller.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                             @@
##           tbavelier/generic_resource_re_refactor    #1641      +/-   ##
==========================================================================
- Coverage                                   49.53%   49.15%   -0.39%     
==========================================================================
  Files                                         218      219       +1     
  Lines                                       21320    21248      -72     
==========================================================================
- Hits                                        10561    10444     -117     
- Misses                                      10209    10259      +50     
+ Partials                                      550      545       -5     
Flag Coverage Δ
unittests 49.15% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...al/controller/datadoggenericresource/controller.go 39.25% <0.00%> (+0.28%) ⬆️
...nternal/controller/datadoggenericresource/utils.go 50.45% <0.00%> (-2.94%) ⬇️
pkg/datadogclient/client.go 0.00% <0.00%> (ø)
...rnal/controller/datadoggenericresource/monitors.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc444c5...618a5df. Read the comment docs.

@tbavelier tbavelier changed the title [CECO-1860][DatadogGenericResource] Add monitor support [CECO-1860][DatadogGenericResource](refactor 2) Add monitor support Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants