Skip to content

fix: skip unnecessary API key retrieval when Datadog extension is present #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: skip unnecessary API key retrieval when Datadog extension is present #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/metrics/listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,6 @@ export class MetricsListener {
}

public async onStartInvocation(_: any, context?: Context) {
// We get the API key in onStartInvocation rather than in the constructor because in busy functions,
// initialization may occur more than 5 minutes before the first invocation (due to proactive initialization),
// resulting in AWS errors: https://github.com/aws/aws-sdk-js-v3/issues/5192#issuecomment-2073243617
if (!this.apiKey) {
this.apiKey = this.getAPIKey(this.config);
}

if (this.isExtensionRunning === undefined) {
this.isExtensionRunning = await isExtensionRunning();
logDebug(`Extension present: ${this.isExtensionRunning}`);
Expand All @@ -98,6 +91,12 @@ export class MetricsListener {
return;
}

// We get the API key in onStartInvocation rather than in the constructor because in busy functions,
// initialization may occur more than 5 minutes before the first invocation (due to proactive initialization),
// resulting in AWS errors: https://github.com/aws/aws-sdk-js-v3/issues/5192#issuecomment-2073243617
if (!this.apiKey) {
this.apiKey = this.getAPIKey(this.config);
}
this.currentProcessor = this.createProcessor(this.config, this.apiKey);
}

Expand Down