fix: read full response body and close connections to avoid file desc… #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,7 @@ import ( | |||
| "encoding/base64" | |||
| "encoding/json" | |||
| "fmt" | |||
| "io" | |||
| "net/http" | |||
There was a problem hiding this comment.
There are 4 places in this file where we call Client.Do. We should be sure to fix all of them. Esp start/end invocation and flush.
There was a problem hiding this comment.
Flush is a local test thing only, I don't actually think it works anymore
There was a problem hiding this comment.
That's not what I'm seeing at
datadog-lambda-go/internal/trace/listener.go
Line 128 in 39ee88f
We call Flush every time.
There was a problem hiding this comment.
Probably the better thing to do is what you are saying, ensure the Flush call only happens when local testing.
There was a problem hiding this comment.
That's the tracer flush, not calling the flush endpoint on the extension
purple4reina
approved these changes
Aug 20, 2025
purple4reina
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…riptor leakage
What does this PR do?
Reads the full response and closes the connection to prevent the server from holding the connection open
Motivation
Testing Guidelines
Additional Notes
Types of changes
Checklist