Skip to content

feat [METEXP-2034]: update metrics.yaml for ListMetricAssets #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .generator/schemas/v2/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21830,8 +21830,19 @@ components:
readOnly: true
type: object
MetricAssetAttributes:
description: Assets related to the object, including title and url.
description: Assets related to the object, including title, url, and tags.
properties:
tags:
description: List of tag keys used across all assets containing this metric.
example:
- env
- service
- host
- datacenter
items:
description: Tag key used in assets.
type: string
type: array
title:
description: Title of the asset.
type: string
Expand Down
10 changes: 9 additions & 1 deletion services/metrics/src/v2/models/MetricAssetAttributes.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import { AttributeTypeMap } from "@datadog/datadog-api-client";

/**
* Assets related to the object, including title and url.
* Assets related to the object, including title, url, and tags.
*/
export class MetricAssetAttributes {
/**
* List of tag keys used across all assets containing this metric.
*/
"tags"?: Array<string>;
/**
* Title of the asset.
*/
Expand All @@ -27,6 +31,10 @@ export class MetricAssetAttributes {
* @ignore
*/
static readonly attributeTypeMap: AttributeTypeMap = {
tags: {
baseName: "tags",
type: "Array<string>",
},
title: {
baseName: "title",
type: "string",
Expand Down
2 changes: 1 addition & 1 deletion services/metrics/src/v2/models/MetricMonitorAsset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { MetricMonitorType } from "./MetricMonitorType";
*/
export class MetricMonitorAsset {
/**
* Assets related to the object, including title and url.
* Assets related to the object, including title, url, and tags.
*/
"attributes"?: MetricAssetAttributes;
/**
Expand Down
2 changes: 1 addition & 1 deletion services/metrics/src/v2/models/MetricNotebookAsset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { MetricNotebookType } from "./MetricNotebookType";
*/
export class MetricNotebookAsset {
/**
* Assets related to the object, including title and url.
* Assets related to the object, including title, url, and tags.
*/
"attributes"?: MetricAssetAttributes;
/**
Expand Down
2 changes: 1 addition & 1 deletion services/metrics/src/v2/models/MetricSLOAsset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { MetricSLOType } from "./MetricSLOType";
*/
export class MetricSLOAsset {
/**
* Assets related to the object, including title and url.
* Assets related to the object, including title, url, and tags.
*/
"attributes"?: MetricAssetAttributes;
/**
Expand Down