Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to disable cache hit miss metrics #33201

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Jan 21, 2025

What does this PR do?

This PR adds config option apm_config.obfuscation.cache.metrics to enable or disable obfuscation cache hit miss metrics. This option is enabled by default.

Motivation

Enabling cache statistics metrics comes with performance overhead. The option allows user to disable the cache hit/miss metrics.
From a simple performance comparison, metrics on vs. off has small CPU difference. RSS memory usage is almost identical.
image
image

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-apm trace-agent medium review PR review might take time labels Jan 21, 2025
@lu-zhengda lu-zhengda added the qa/done QA done before merge and regressions are covered by tests label Jan 21, 2025
@lu-zhengda lu-zhengda marked this pull request as ready for review January 21, 2025 19:06
@lu-zhengda lu-zhengda requested review from a team as code owners January 21, 2025 19:06
@lu-zhengda lu-zhengda requested a review from ogaca-dd January 21, 2025 19:06
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor edd9ae272a4ea05c1f9d6941b11b73d159b67cae

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-arm64-deb 0.00MB 56.44MB 56.44MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 59.01MB 59.01MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 59.01MB 59.01MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 94.07MB 94.07MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 94.06MB 94.06MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 90.11MB 90.11MB 0.50MB
datadog-agent-amd64-deb 0.00MB 929.14MB 929.14MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 938.80MB 938.80MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 938.80MB 938.80MB 0.50MB
datadog-agent-arm64-deb 0.00MB 915.81MB 915.81MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 925.45MB 925.45MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.93MB 58.93MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 477.44MB 477.44MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 94.00MB 94.00MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 90.04MB 90.04MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53598320 --os-family=ubuntu

Note: This applies to commit 2b5323a

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 50d36b71-83cb-4253-b13a-f93e19cf25d3

Baseline: 58bc7e4
Comparison: 2b5323a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.12 [-1.09, +5.34] 1 Logs
quality_gate_idle memory utilization +0.45 [+0.41, +0.49] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.33 [-0.38, +1.03] 1 Logs
quality_gate_idle_all_features memory utilization +0.22 [+0.13, +0.30] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.68, +0.90] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.83, +0.94] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.77, +0.79] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.94, +0.94] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.09] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.04 [-0.96, +0.88] 1 Logs
file_tree memory utilization -0.07 [-0.22, +0.08] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.24 [-0.70, +0.22] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.28 [-1.06, +0.50] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.42 [-0.49, -0.36] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@jeremy-hanna jeremy-hanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for ASC owned files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-apm trace-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants