Skip to content

Conversation

@aymericDD
Copy link
Contributor

@aymericDD aymericDD commented Nov 26, 2025

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

Pod replacement operates at the pod level and should not require container information. The feature was failing because the injector expected target containers to be specified, but pod replacement works directly with pods identified by their IP address.

This fix adds logic to detect when running the pod-replacement command and ignore the containers.

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

Pod replacement operates at the pod level and should
not require container information. The feature was
failing because the injector expected target containers
to be specified, but pod replacement works directly
with pods identified by their IP address.

This fix adds logic to detect when running the
pod-replacement command and skips the container
validation, creating a single config without container
dependencies instead.

Jira: CHAOSPLT-1330
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 26, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d470ce9 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@aymericDD aymericDD changed the title fix(pod-replacement): exclude container requirement [CHAOSPLT-1330][FIX] Exclude container requirement Dec 3, 2025
@aymericDD aymericDD marked this pull request as ready for review December 3, 2025 15:55
@aymericDD aymericDD requested a review from a team as a code owner December 3, 2025 15:55
@aymericDD aymericDD changed the title [CHAOSPLT-1330][FIX] Exclude container requirement [CHAOSPLT-1330][FIX] PodReplacement: Ignore container requirement Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants