[PF-691] Add Location column in Cloud Environments page #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdcanas
approved these changes
Apr 20, 2021
kyuksel
approved these changes
Apr 20, 2021
src/pages/Environments.js
Outdated
| headerRenderer: () => 'Location', | ||
| cellRenderer: ({ rowIndex }) => { | ||
| const { runtimeConfig: { zone, region } } = filteredRuntimes[rowIndex] | ||
| return zone ? zone : region |
There was a problem hiding this comment.
Nit:
Suggested change
| return zone ? zone : region | |
| return zone || region |
looks a bit more readable to me.
yonghaoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DataBiosphere/leonardo#1933, zone and region parameters were added to createRuntime so Leo can now create instances outside of us-central1. In #2441, the Terra UI will allow use those new parameters.
This PR will updates the cloud enviroments page to show you the region/zone your environments are in.
Tested with a GCE instance and Dataproc cluster on both the default location (us-central1) and non-default locations.
Discussion of UI changes related to locality have been happening in this doc, including comments from UI team.