-
Notifications
You must be signed in to change notification settings - Fork 4
[DT-2381] Migrate remaining study components to new architecture. #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
otchet-broad
wants to merge
17
commits into
develop
Choose a base branch
from
otchet-dt-2381-s4r-study-to-new-form-architecture
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DT-2381] Migrate remaining study components to new architecture. #3130
otchet-broad
wants to merge
17
commits into
develop
from
otchet-dt-2381-s4r-study-to-new-form-architecture
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d and I think I'm liking the structure it's bringing.
…e used in other business logic.
otchet-broad
commented
Oct 29, 2025
| export type OrganizationType = 'For-Profit' | 'Nonprofit' | ||
|
|
||
| export interface Institution { | ||
| export interface InstitutionInterface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name collision with the library that interacts with our service endpoint for Institution
… options in select list.
…. TODO: Study AlternativeDataSharingPlan file management.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Addresses
https://broadworkbench.atlassian.net/browse/DT-2381
Summary
Work in progress for remaining study components for Data Submission V2.
TODO:
Migrate NIHDataManagement.jsx
Tests
Refactor study property classes so
keyis static readonly constant inside each classConsider migrating all form components to elements generated by functions
Have you read Terra's Contributing Guide lately? If not, do that first.