Fix/pre commit on fork prs - #844
Merged
Merged
Conversation
Irozuku
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI changes.
Pre-commit checksonly listened topush, which covers branches that live in this repository but not pull requests from forks. PR #828 came from a fork,so the hooks never ran on it and its lint errors surfaced on
developafter the merge instead of on the PR (fixed in b3b7296). Addingpull_requestcloses that gap.
The
Code Reviewworkflow is removed. It ran an on-demand Claude review triggered by a/reviewcomment, and it has not completed a review since the dayit was set up.
Type of Change
Check all that apply like this [x]:
Changes (by file)
.github/workflows/pre-commit.yaml: add thepull_requesttrigger next topush, so the hooks also run on pull requests opened from forks. Internalbranches keep firing once, GitHub deduplicates the two events. A comment records why, since the reason is not visible from the file itself.
.github/workflows/code-review.yaml: deleted.Testing
This PR is its own check for the first change: the
pre-commitcheck should appear in its list, which is what PR #828 was missing. That only proves theworkflow still runs on an internal branch, since this branch lives in the repository. The real verification is the next pull request opened from a fork.
For reference, the check lists as they stood:
PR #838 (internal branch): alembic translations pre-commit pytest react-build
PR #828 (fork): alembic translations pytest react-build
Notes
Run history for the removed workflow, 55 runs in total:
42 skipped 8 success 4 failure 1 startup_failure
The 8 successful runs are all from 2026-04-16, the day the workflow was added and iterated on. It has not produced a review since. The 42 skipped runs come
from the trigger being a bare
issue_comment, so every comment on any issue or pull request starts a runner that evaluates theif, finds no/reviewand stops.
The
ANTHROPIC_API_KEYrepository secret is now unused, since this was the only workflow that read it. Revoking it is a separate step in Settings and isnot part of this PR.