Added metrics step and visualization to models - #414
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request enhances the model management and visualization features by introducing metric split selection (train, validation, test) across session creation, comparison, and visualization components. The changes also standardize terminology from "Run Name" to "Model Name" for improved clarity.
Key Changes:
- Added metric split selection with automatic fallback when selected split is unavailable
- Introduced a new "Select Metrics" step in the session creation workflow
- Enhanced model comparison table with dynamic metric column generation based on selected split
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| SessionVisualization.jsx | Added metric split state, toggle button UI, and automatic split selection logic |
| ModelComparisonTable.jsx | Implemented dynamic metric column generation, removed Status column, updated naming to "Model Name" |
| CreateSessionSteps.jsx | Added metrics selection step and state fields for train/validation/test metrics |
| AddModelDialog.jsx | Updated labels from "Run Name" to "Model Name" for consistency |
| RunCard.jsx | Restructured UI to display run name more prominently with status chip |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Felipedino
marked this pull request as draft
January 6, 2026 13:09
Felipedino
marked this pull request as ready for review
January 11, 2026 01:04
Collaborator
Author
|
Ya no tiene el step de seleccionar metrics |
cristian-tamblay
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the model management and visualization features in the frontend, focusing on enhanced metric selection, clearer naming conventions, and improved user interface for comparing models. The most significant changes include the addition of metric split selection (train, validation, test) throughout the session and comparison views, updates to model/run naming for clarity, and UI enhancements for model comparison.
Metric Selection & Handling:
Naming & Label Updates:
Model Comparison Table Enhancements:
ModelComparisonTableto dynamically generate metric columns based on the selected split, improved metric value formatting, and added a prop for selecting the metric split. Removed the redundant "Status" column for a cleaner UI. [1] [2] [3] [4]Session Creation Workflow:
Run Card UI Improvements:
RunCardcomponent to display the run name and status more prominently, improving readability and aligning with the new naming conventions.These changes collectively improve the user experience when creating, comparing, and visualizing models, especially regarding metric handling and clarity in naming.