Skip to content

Added metrics step and visualization to models - #414

Merged
cristian-tamblay merged 6 commits into
developfrom
feat/metrics-step
Jan 12, 2026
Merged

cristian-tamblay merged 6 commits into
developfrom
feat/metrics-step

Conversation

@Felipedino

Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements to the model management and visualization features in the frontend, focusing on enhanced metric selection, clearer naming conventions, and improved user interface for comparing models. The most significant changes include the addition of metric split selection (train, validation, test) throughout the session and comparison views, updates to model/run naming for clarity, and UI enhancements for model comparison.

Metric Selection & Handling:

  • Added support for selecting and displaying metrics by split (train, validation, test) in session creation, model comparison, and visualization components. This includes new state variables, logic to handle available splits, and UI controls for toggling between metric splits. [1] [2] [3] [4] [5] [6]

Naming & Label Updates:

  • Updated labels and placeholders from "Run Name" to "Model Name" throughout the model creation dialog and model comparison table for consistency and clarity. [1] [2] [3]

Model Comparison Table Enhancements:

  • Refactored the ModelComparisonTable to dynamically generate metric columns based on the selected split, improved metric value formatting, and added a prop for selecting the metric split. Removed the redundant "Status" column for a cleaner UI. [1] [2] [3] [4]
image

Session Creation Workflow:

  • Added a new step for metric selection in the session creation workflow, ensuring that metrics are properly set and passed when creating a new session. [1] [2] [3] [4] [5]
image

Run Card UI Improvements:

  • Updated the RunCard component to display the run name and status more prominently, improving readability and aligning with the new naming conventions.

These changes collectively improve the user experience when creating, comparing, and visualizing models, especially regarding metric handling and clarity in naming.

Copilot AI review requested due to automatic review settings January 6, 2026 12:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the model management and visualization features by introducing metric split selection (train, validation, test) across session creation, comparison, and visualization components. The changes also standardize terminology from "Run Name" to "Model Name" for improved clarity.

Key Changes:

  • Added metric split selection with automatic fallback when selected split is unavailable
  • Introduced a new "Select Metrics" step in the session creation workflow
  • Enhanced model comparison table with dynamic metric column generation based on selected split

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
SessionVisualization.jsx Added metric split state, toggle button UI, and automatic split selection logic
ModelComparisonTable.jsx Implemented dynamic metric column generation, removed Status column, updated naming to "Model Name"
CreateSessionSteps.jsx Added metrics selection step and state fields for train/validation/test metrics
AddModelDialog.jsx Updated labels from "Run Name" to "Model Name" for consistency
RunCard.jsx Restructured UI to display run name more prominently with status chip

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread DashAI/front/src/components/models/ModelComparisonTable.jsx Outdated
Comment thread DashAI/front/src/components/models/SessionVisualization.jsx
Comment thread DashAI/front/src/components/models/SessionVisualization.jsx Outdated
Comment thread DashAI/front/src/components/models/ModelComparisonTable.jsx
Comment thread DashAI/front/src/components/models/ModelComparisonTable.jsx Outdated
Comment thread DashAI/front/src/components/models/ModelComparisonTable.jsx Outdated
@Felipedino
Felipedino marked this pull request as draft January 6, 2026 13:09
Base automatically changed from feat/explainers-to-models to develop January 8, 2026 00:35
@Felipedino
Felipedino marked this pull request as ready for review January 11, 2026 01:04
@Felipedino

Copy link
Copy Markdown
Collaborator Author

Ya no tiene el step de seleccionar metrics

@cristian-tamblay
cristian-tamblay merged commit 60b3111 into develop Jan 12, 2026
18 checks passed
@cristian-tamblay
cristian-tamblay deleted the feat/metrics-step branch January 12, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants