Fix client lag by removing unnecessary soil & crop validation#423
Open
MUYUTwilighter wants to merge 1 commit intoDarkhax-Minecraft:1.20.1from
Open
Fix client lag by removing unnecessary soil & crop validation#423MUYUTwilighter wants to merge 1 commit intoDarkhax-Minecraft:1.20.1from
MUYUTwilighter wants to merge 1 commit intoDarkhax-Minecraft:1.20.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why lag?
In issue #421 , a detailed information is provided.
To say simply, the server keeps sending
ClientboundBlockEntityDataPacketat intervals, even though nothing has changed about the soil & crop stacks.And client will always validate the crops & soils in the packet, this would cause serious lag on client especially when there are a lot of pots or pot recipes, as the validation invoked by every single pot will iterate all the recipes.
How did I fix it?
In
BlockEntityBotanyPot#load, I add a check before invoking inventory syncing.Now only if there are changes on crop & soil stacks, the client would try load super and validate crops & soils.