ClickHouseDecimal: wrong conversion to integral types (#460)

DarkWanderer · Apr 7, 2024 · 8cece7d · 8cece7d
1 parent 39fcbc0
commit 8cece7d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/ClickHouse.Client.Tests/Numerics/ClickHouseDecimalTests.cs b/ClickHouse.Client.Tests/Numerics/ClickHouseDecimalTests.cs
@@ -226,8 +226,8 @@ public void ShouldRoundtripIntoDouble(double @double)
     [TestCase(typeof(string))]
     public void ShouldConvertToType(Type type)
     {
-        var expected = Convert.ChangeType(5m, type);
-        var actual = Convert.ChangeType(new ClickHouseDecimal(5m), type);
+        var expected = Convert.ChangeType(5.00m, type);
+        var actual = Convert.ChangeType(new ClickHouseDecimal(5.00m), type);
         Assert.AreEqual(expected, actual);
     }
 

diff --git a/ClickHouse.Client/Numerics/ClickHouseDecimal.cs b/ClickHouse.Client/Numerics/ClickHouseDecimal.cs
@@ -181,22 +181,22 @@ public static explicit operator decimal(ClickHouseDecimal value)
 
     public static explicit operator int(ClickHouseDecimal value)
     {
-        return (int)(value.Mantissa * BigInteger.Pow(10, value.Scale));
+        return (int)(value.Mantissa / BigInteger.Pow(10, value.Scale));
     }
 
     public static explicit operator uint(ClickHouseDecimal value)
     {
-        return (uint)(value.Mantissa * BigInteger.Pow(10, value.Scale));
+        return (uint)(value.Mantissa / BigInteger.Pow(10, value.Scale));
     }
 
     public static explicit operator long(ClickHouseDecimal value)
     {
-        return (long)(value.Mantissa * BigInteger.Pow(10, value.Scale));
+        return (long)(value.Mantissa / BigInteger.Pow(10, value.Scale));
     }
 
     public static explicit operator ulong(ClickHouseDecimal value)
     {
-        return (ulong)(value.Mantissa * BigInteger.Pow(10, value.Scale));
+        return (ulong)(value.Mantissa / BigInteger.Pow(10, value.Scale));
     }
 
     public static ClickHouseDecimal operator +(ClickHouseDecimal left, ClickHouseDecimal right)