Fix: MSBuild BaseIntermediateOutputPath and unity files exclude#186
Open
kapitanmliko wants to merge 11 commits into
Open
Fix: MSBuild BaseIntermediateOutputPath and unity files exclude#186kapitanmliko wants to merge 11 commits into
kapitanmliko wants to merge 11 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have merged two branches into a single branch as both were closely related and it might be easier to handle a single PR in current circumstances.
So this PR now contains following:
Fix: MSbuild - incorrect set of BaseIntermediateOutputPath #182
I have removed .props import, BaseOutputPath and BaseIntermediateOutputPath from each csproj. It was all moved to Directory.Build.props. BaseIntermediateOutputPath is now set to more appropriate value. (Also gets rid of the build warning)
DefaultItemExcludes modified to exclude unity .meta files from all projects #183
I have just modified DefaultItemExcludes - now excludes unity .meta files and unity asmdef files. Both do not need to be part of the project build. Those files are not present in unity generated projects so we can follow same path and have a prettier and more usable and pleasing solution.