Skip to content

All disc rolls use applicable stats for better behavoir#1097

Open
FalloutFalcon wants to merge 6 commits into
DarkPack13:masterfrom
FalloutFalcon:fix-some-storyteller-rolls
Open

All disc rolls use applicable stats for better behavoir#1097
FalloutFalcon wants to merge 6 commits into
DarkPack13:masterfrom
FalloutFalcon:fix-some-storyteller-rolls

Conversation

@FalloutFalcon
Copy link
Copy Markdown
Member

@FalloutFalcon FalloutFalcon commented Jun 2, 2026

About The Pull Request

Converts and fully removes the old version of rolling where we pass in a number for passing in a list of stats we want to use and letting the roll use that instead for more logic.

I was making datums for every roll at first but i realized that most of them dont super need the subtypes outside maybe giving them all bumper_text so i just chose not to for rn.

Why It's Good For The Game

All discs will now show what stats your rolling with instead of being hit with a useless number.

Changelog

🆑
qol: All discs should now display what stats they rolled with
fix: scorpions touch poison will properly consider fortitude
refactor: replaces SSroll.storyteller_roll completly with SSroll.storyteller_roll_datum
/:cl:

would rather make the change after a pull has time to adjust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant