QDEL define for area text#1073
Open
FalloutFalcon wants to merge 1 commit into
Open
Conversation
Contributor
|
we actually recently removed the qdels from area texts on TFN writ large so that the deletion subsystem doesnt get overloaded with a huge destroy cost |
Contributor
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~7 days. Please address any outstanding review items and ensure your PR is finished - if both are true, and you have auto-staled anyway, you need to actively ask maintainers (by pinging them in the /tg/station Discord) to (re)review or merge your PR. If no maintainer responds to your request, you may wish to close this PR yourself while you seek maintainer comment, as you will later be able to reopen the PR yourself. |
FalloutFalcon
pushed a commit
that referenced
this pull request
Jun 1, 2026
## About The Pull Request #1073 alternative which removes the use of the deletion subsystem entirely cutting out the concern for deletion cost just invisible-izes the text instead of deleting also adds some music ## Why It's Good For The Game pretty essential fix to reduce lag ## Changelog :cl: code: removes hard deletes on area texts by cutting out the qdeletion method for making the text disappear, just setting the text to be invisible instead /:cl:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
like 50% sure this will fix a reported harddel as well as make the code nicer.
Changelog
🆑
code: Swap callback for a define (which still calls a callback) for area text
/:cl: