Conversation
…er-aware selection
Editor:
- Mark the document modified on align/distribute/nudge, image transforms,
attach/detach, and during drag-move/handle-drag so unsaved-work prompts fire.
- Add Ctrl+G shortcut to open the circuit-code ("Define") dialog.
Background image:
- Keep the .fcd as pure text (geometry only via FJC IMG) and re-attach the
image bytes from localStorage on load via a pendingRestore flag and an
async whenReady() bridge; zoom-to-fit once the image is ready.
- Drop the localStorage cache on detach so removed images don't return.
Selection / parser:
- Centralize layer-visibility checks (isVisibleForSelection) and handle
multi-layer macros via containsLayer.
- Drop unrecognized macro keys instead of leaving an empty placeholder.
- Make macro-expansion depth process-wide to bound nested parsing.
Tests / tooling:
- Memoize the stubbed 2D canvas context and record putImageData calls.
- Ratchet coverage thresholds to 65/65/60/79.
- Add docs:tests generator script and broaden unit/e2e coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles the current
devwork ontomain. Two commits: an editor/feature commit plus the earlier FidoCad format notes.Editor
Background image
.fcdstays pure text (geometry only viaFJC IMG x y scale alpha); image bytes are re-attached fromlocalStorageon load through apendingRestoreflag and an asyncwhenReady()bridge, with zoom-to-fit once ready.localStoragecache so it doesn't reappear on reload.Selection / parser
isVisibleForSelection), correctly handling multi-layer macros viacontainsLayer.Tests / tooling
getContext('2d')identity) and recordedputImageDatacalls for assertions.docs:testsgenerator script and broadened unit/e2e coverage.Test plan
npm run typecheckpasses.