[107] ISSUE-080: Add Offline Transaction Preparation Workflow Example - #141
Merged
Dantama022 merged 3 commits intoJul 29, 2026
Conversation
- Add 80-offline-transaction-workflow.ts: build unsigned tx, export XDR, simulate an offline signing hop, sign, and gracefully handle corrupted/invalid XDR before reconstructing and submitting. - Add tests/offline-transaction-workflow.test.ts covering reconstruction, offline signing, corrupted XDR handling, and runner/README registration. - Register the example in the runner catalog and document it in README.md. - Fix a pre-existing JSON syntax error in validation.config.json (missing closing brace between the 67 and 50 exclusion entries) that was breaking the test suite, and add an exclusion entry for the new example.
|
@esthertitilayo-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/examples/80-offline-transaction-workflow.ts: build an unsigned tx, export unsigned XDR, simulate an air-gapped transfer to an offline signer, sign offline, and gracefully handle corrupted/invalid XDR before reconstructing and submitting the signed tx.tests/offline-transaction-workflow.test.tscovering XDR reconstruction (valid, truncated, garbage, and fee-bump inputs), offline signing,describeTransaction,isLikelyCorruptedXDR, and runner/README registration.src/runner/catalog.ts(with an optionalamountparam) and documents it inREADME.md(roadmap list + Direct Run section).src/validation/validation.config.json(missing},\n{between the67-soroban-contract-eventsand50-asset-issuer-discoveryexclusion entries) — needed for the test suite to parse the config and pass, and adds an exclusion entry for the new example.Test plan
npx eslintandnpx tsc --noEmiton changed files (pre-existing unrelated errors in72-contract-interface-inspection.ts/73-complex-data-types.ts/75-deploy-precompiled-wasm.tsleft untouched)npx jest tests/offline-transaction-workflow.test.ts tests/ledger-effects.test.ts tests/runner.test.tsnpm test— full suite green (22 suites, 257 tests passing)Closes #107