fix FocusActiveChat support in tabs#84
Open
deeptoaster wants to merge 1 commit intoDanBradbury:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FocusActiveChatis currently broken when a user tries to call it from a tab other than the one the active Copilot Chat window is in.This is because window IDs are global (with respect to tabs), while window numbers are local. The existing code would attempt to search for the Copilot Chat window by ID (globally), convert it to a window number (local, losing tab information), convert it back to ID (global, now possibly on the wrong tab), and switch to it. If the Copilot Chat window is on a different tab, this means that you end up either
Fundamentally, this is because this function entirely ignores the concept of tabs. We can resolve this in one of two ways:
Option 2 feels more intuitive, so I went for that.
This PR also removes an unnecessary loop through all the windows in the user's entire Vim session.
win_findbuf()(for option 1) orbufwinnr()(for option 2) gets you the same information much more efficiently.