Skip to content

ci: Remove unused ilammy/setup-nasm#802

Open
stweil wants to merge 1 commit into
DanBloomberg:masterfrom
stweil:master
Open

ci: Remove unused ilammy/setup-nasm#802
stweil wants to merge 1 commit into
DanBloomberg:masterfrom
stweil:master

Conversation

@stweil

@stweil stweil commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

A positive side effect of this removal is that it not only simplifies the CI rules, but also fixes this CI warning:

Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: ilammy/setup-nasm@v1.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil stweil requested a review from zdenop June 30, 2026 12:27
@zdenop

zdenop commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

AFAIR nasm is needed for building libjpeg

@stweil

stweil commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Building libjpeg works without nasm (see build log). It only reports a warning:

-- Looking for a ASM_NASM compiler - NOTFOUND
CMake Warning at simd/CMakeLists.txt:5 (message):
  SIMD extensions disabled: could not find NASM compiler.  Performance will
  suffer.
Call Stack (most recent call first):
  simd/CMakeLists.txt:57 (simd_fail)

Is this relevant? We don't want to test builds of libjpeg-turbo, but it is part of the created artifact archive file. I think it would be acceptable to have a libjpeg-turbo without SIMD optimizations there.

@DanBloomberg

Copy link
Copy Markdown
Owner

seems ok to me not to require using the SIMD compiler. with libjpeg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants