Conversation
Handling ascii85flag like a boolean value makes it easier for Coverity Scan to track the possible code branches. Signed-off-by: Stefan Weil <sw@weilnetz.de>
This fixes two issues reported by Coverity Scan. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Owner
|
Not sure what C.S. was complaining about with the values of ascii85flag. And it's used several other times in the file, in apparently the same way, so why didn't C.S. complain in those places? |
Owner
|
(I guess C.S. was trying to protect against values other than 0 or 1 being used, which makes sense. But again, why only in lines 958 and 969?) |
Owner
|
Stefan, did you want to check this in, or make any modifications? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.