Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[재호] WEEK 13 Solutions #588

Closed
wants to merge 0 commits into from
Closed

[재호] WEEK 13 Solutions #588

wants to merge 0 commits into from

Conversation

wogha95
Copy link
Contributor

@wogha95 wogha95 commented Nov 10, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@wogha95 wogha95 added the js label Nov 10, 2024
@wogha95 wogha95 self-assigned this Nov 10, 2024
@wogha95 wogha95 requested a review from a team as a code owner November 10, 2024 04:11
@wogha95 wogha95 requested a review from EgonD3V November 10, 2024 04:11
@EgonD3V
Copy link
Contributor

EgonD3V commented Nov 10, 2024

좋은 풀이 감사합니다. 한 주도 수고 많으셨습니다.

}
}

return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null을 return하지 않는 방법은 없을까요

Copy link
Contributor Author

@wogha95 wogha95 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제에 의하면 공통 조상은 무조건 있기 때문에 line 32~33을 작성하지 않아도 됨으로 제거하도록 하겠습니다.

Comment on lines 18 to 20
let prevprevprev = nums[0];
let prevprev = nums[1];
let prev = nums[0] + nums[2];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명이 재미있네요

@SamTheKorean
Copy link
Contributor

FYI 자금 error가 뜨는데 확인 부탁드립니다!
Screenshot 2024-11-10 at 3 00 01 PM

@bky373
Copy link
Contributor

bky373 commented Nov 11, 2024

FYI 자금 error가 뜨는데 확인 부탁드립니다! Screenshot 2024-11-10 at 3 00 01 PM

요거는 찾아보니 권한 문제가 있네요 대안을 찾기 전까지 일단 revert 해두는 게 좋을 것 같아 PR 하나 올리겠습니다 -> 여기에 올렸어용

@wogha95
Copy link
Contributor Author

wogha95 commented Nov 14, 2024

13주차가 병합되기 전에 14주차 푼 문제들이 같이 반영되었습니다.
그래서 다시 되돌려 놓는 과정에서 force-pushed를 사용하였고 PR이 close로 변경되었습니다.

@wogha95 wogha95 mentioned this pull request Nov 14, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

4 participants