[gitsunmin] Week 09 Solutions #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgonD3V
approved these changes
Oct 12, 2024
| let right = nums.length - 1; | ||
|
|
||
| while (left < right) { | ||
| const mid = Math.floor((left + right) / 2); |
There was a problem hiding this comment.
굳이 floor은 안사용하셔도 괜찮을 것 같습니다. 이분탐색에서 while문에 등호를 넣거나 if나 else에서 등호를 넣거나 테스트 해보시면 좋을 것 같습니다.
Comment on lines
+16
to
+30
| function hasCycle(head: ListNode | null): boolean { | ||
| if (!head || !head.next) { | ||
| return false; | ||
| } | ||
|
|
||
| let slow: ListNode | null = head; | ||
| let fast: ListNode | null = head.next; | ||
|
|
||
| while (slow !== fast) { | ||
| if (!fast || !fast.next) return false; | ||
| slow = slow!.next; | ||
| fast = fast.next.next; | ||
| } | ||
|
|
||
| return true; |
There was a problem hiding this comment.
코드 리뷰를 하면서 드는 생각인데 union-find로도 풀어볼 걸 그랬네요
| const directions = [[1, 0], [-1, 0], [0, 1], [0, -1]]; | ||
|
|
||
| function dfs(r: number, c: number, visited: boolean[][], prevHeight: number) { | ||
| if (r < 0 || c < 0 || r >= m || c >= n || visited[r][c] || heights[r][c] < prevHeight) { |
There was a problem hiding this comment.
저도 귀찮아서 한 줄로 쓰기는 하는데, 리뷰어의 입장에서 코드 스멜이나 단축 평가를 고려하면 적절한 조건들로 나누는 게 좋을 것 같습니다. 이 경우는 index error가 일어나지 않을 r, c를 한정하기 위해 순서가 어쩔 수 없지만...
There was a problem hiding this comment.
@lymchgmk
이야기 감사합니다! 코드 스멜도 신경써볼게요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.