Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EGON] Week7 Solutions #496

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[EGON] Week7 Solutions #496

merged 1 commit into from
Sep 27, 2024

Conversation

EgonD3V
Copy link
Contributor

@EgonD3V EgonD3V commented Sep 24, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@EgonD3V EgonD3V requested a review from gitsunmin September 24, 2024 19:50
@EgonD3V EgonD3V self-assigned this Sep 24, 2024
@github-actions github-actions bot added the py label Sep 24, 2024
@EgonD3V EgonD3V marked this pull request as ready for review September 24, 2024 19:51
@EgonD3V EgonD3V requested a review from a team as a code owner September 24, 2024 19:51
Comment on lines +58 to +67
while left < len(s) and right < len(s):
while right < len(s) and s[right] not in checker:
checker.add(s[right])
right += 1

max_length = max(max_length, len(checker))

while left < len(s) and (right < len(s) and s[right] in checker):
checker.remove(s[left])
left += 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오, while 문 안에 두 개의 while 문이 대칭을 이루니 뭔가 코드가 아름답게 느껴지네요! 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pseudo code스러운 파이썬의 장점 덕분인 것 같습니다. 감사합니다.

Comment on lines +58 to +66
def reverse(prev: Optional[ListNode], curr: Optional[ListNode]) -> Optional[ListNode]:
if not curr:
return prev

post = curr.next
curr.next = prev
return reverse(curr, post)

return reverse(None, head)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두 개의 인자를 받는 재귀 구현 배워갑니다 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dale님 덕분에 즐겁게 문제 풀고 있습니다. 늘 감사드립니다.

Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

self.post = None


class Deque(Generic[T]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deque을 직접 구현까지 하시고 무료하셨나 봅니다 ㅋ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기회있을 때마다 자료구조 구현하기...

@EgonD3V EgonD3V merged commit ae84911 into DaleStudy:main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants