[선재] WEEK07 문제풀이 #493
Merged
[선재] WEEK07 문제풀이 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bky373
approved these changes
Sep 24, 2024
DaleSeo
reviewed
Sep 25, 2024
HC-kang
approved these changes
Sep 25, 2024
| */ | ||
| var setZeroes = function (matrix) { | ||
| const stack = []; | ||
| const memo = { row: new Set(), column: new Set() }; |
There was a problem hiding this comment.
stack이나 memo중 하나만 사용하셨어도 되지 않았을까요? 최적화를 위해 두 가지를 모두 사용하신걸까요?
There was a problem hiding this comment.
맞아요. 동일한 크기인 matrix를 만들어서 memo를 활용하는 방법도 가능하나, stack이나 queue와 같이 0인지점을 저장하고 모두 소모하는 방식이 조금이라도 공간을 덜 사용하지 않을까 싶어서 선택했어요.
reverse-linked-list/sunjae95.js
Outdated
| var reverseList = function (head) { | ||
| let answer = null; | ||
|
|
||
| const search = (target) => { |
There was a problem hiding this comment.
search라는 함수 네이밍은 추후 오해의 소지가 있지 않을까 싶어요.
buildReverseList 등이 좀 더 명확하게 내부 구현을 표현하지 않을까요?
There was a problem hiding this comment.
오 reverseList 단어가 들어가니 더 명시적이네요! 변수명이 제일어렵네요 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.