Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[환미니니] WEEK 2 Solution #360

Merged
merged 4 commits into from
Aug 25, 2024
Merged

[환미니니] WEEK 2 Solution #360

merged 4 commits into from
Aug 25, 2024

Conversation

JEONGHWANMIN
Copy link
Contributor

@JEONGHWANMIN JEONGHWANMIN commented Aug 23, 2024 •
edited
Loading

@JEONGHWANMIN JEONGHWANMIN self-assigned this Aug 23, 2024
@JEONGHWANMIN JEONGHWANMIN marked this pull request as draft August 23, 2024 15:02
@JEONGHWANMIN JEONGHWANMIN marked this pull request as ready for review August 24, 2024 17:39
DaleSeo
DaleSeo approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다! 질문 2개 남겼지만 PR 병합하시는데는 문제되지 않을 것 같습니다.

construct-binary-tree-from-preorder-and-inorder-traversal/hwanmini.js
@@ -0,0 +1,14 @@
// 시간복잡도: O(n2)
// 공간복잡도: O(n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 배열을 슬라이싱하는데 들어가는 메모리를 고려하셨을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 헷갈려서 다른 분 시간복잡도를 참고했습니다.

valid-anagram/hwanmini.js
@@ -0,0 +1,28 @@
// 시간복잡도: O(n)
// 공간복잡도: O(k)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k가 무엇을 의미하나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저장되는 문자열 개수를 뜻했는데 어처피 문자는 정해져있으니 O(1)이 될 수도 있겠네요..!

@JEONGHWANMIN JEONGHWANMIN merged commit d9b42e7 into DaleStudy:main Aug 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaleSeo DaleSeo DaleSeo approved these changes

Assignees

@JEONGHWANMIN JEONGHWANMIN

Labels
js
Projects
No open projects
리트코드 스터디 2기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JEONGHWANMIN @DaleSeo