Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kayden] Week 02 Solutions #355

Merged
merged 5 commits into from
Aug 25, 2024
Merged

[kayden] Week 02 Solutions #355

merged 5 commits into from
Aug 25, 2024

Conversation

kjb512
Copy link
Contributor

@kjb512 kjb512 commented Aug 21, 2024 •
edited
Loading

@kjb512 kjb512 added the py label Aug 21, 2024
@kjb512 kjb512 requested review from DaleSeo and leokim0922 August 21, 2024 11:19
@kjb512 kjb512 self-assigned this Aug 21, 2024
@kjb512 kjb512 marked this pull request as ready for review August 24, 2024 05:12
@DaleSeo DaleSeo requested a review from taekwon-dev August 24, 2024 19:03
DaleSeo
DaleSeo approved these changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encode and Decode Strings 문제에 대한 솔루션이 좀 이상한 것 같은데, 일단 마감 시간이 다 되서 PR은 승인해드려요. 제 코멘트에 대해서 생각해보시고 다음 주 PR에 반영해주시면 좋을 것 같습니다.

encode-and-decode-strings/kayden.py
res = ""
for str in strs:
size = len(str)
res += str(size)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str이 문자열인데 어떻게 호출하죠?

encode-and-decode-strings/kayden.py
while idx < limit:
num = str[idx]
text = ""
for _ in range(num):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

range() 함수에 문자열을 넘길 수도 있나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오류가 많았네요.. 다음주에 수정해서 같이 올리겠습니다!

@kjb512 kjb512 merged commit 63b996b into DaleStudy:main Aug 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaleSeo DaleSeo DaleSeo approved these changes

@leokim0922 leokim0922 Awaiting requested review from leokim0922

@taekwon-dev taekwon-dev Awaiting requested review from taekwon-dev

Assignees

@kjb512 kjb512

Labels
py
Projects
No open projects
리트코드 스터디 2기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjb512 @DaleSeo