Implement buff bars from commented out Unhalted implementation.#75
Implement buff bars from commented out Unhalted implementation.#75emilthaudal wants to merge 1 commit intoDaleHuntGB:mainfrom
Conversation
- A few changes from bugs i encountered while testing the bars. Tried to add comments explaining the changes i made and stuff i added
f841703 to
d63b034
Compare
|
So, the main issue with this implementation before the PR was the resizing / re-anchoring of the bars (usually during combat). It failed to respect the |
It mostly works, i just found an issue yesterday in M+ content where it lost the width matching and couldn't get it back again until during after the key. I haven't had time to investigate a fix for that yet and it doesn't seem to happen every time so I'm not sure of the root cause. Tbh i'm also not very happy with how many buffbar specific handling cases i ended up adding trying to make them position and stay positioned correctly |
I mostly did this for my personal use since i was really missing the buff bar skinning, but i thought might as well put a PR here so you have the changes if want/need them.
I've done some changes to fix bugs i encountered during my testing, i've tried to add comments on why in the code.
Feel free to DM me on discord username jetskis if there is anything.