Add Docker image#183
Draft
Neraste wants to merge 43 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #183 +/- ##
===========================================
- Coverage 98.69% 98.52% -0.18%
===========================================
Files 83 83
Lines 1994 1965 -29
===========================================
- Hits 1968 1936 -32
- Misses 26 29 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In our deployment in kubernetes[1] we usually use the standard output of the service which is captured by k8s, so the logs can be read from any tool in the k8s ecosystem. Setting LOG_FILE_PATH to /dev/stdout doesn’t work as RotatingFileHandler needs a seekable file to work correctly (needs to tell the current file position to rotate the logs when it writes to the file). So this allows to use the standard output for logs when LOG_TO_CONSOLE is set to True. The way it’s done the logfile is still defined and therefore initialised when the server starts. In practice creating an empty file on startup is not a concern and can be avoided by setting LOG_FILE_PATH to /dev/null (in this case it wouldn’t write to the file and so it won’t try to rotate it). This could also be changed trivially to allow to use both the logfile and console for server logs. [1]: https://github.com/Japan7/nanak8s
was testing that before committing and forgot about it
Member
Author
|
I’m wondering if the supervisord approach is the good one, even if it’s the most advised one when you search for Docker with Django and Daphne... |
Member
Author
|
I eventually moved from supervisor to having several containers from the same image. It’s cleaner as it removes one level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Dockerfile and deployment files to run the server and the front in production within a Docker image.