Skip to content

Display full song lyrics#233

Merged
Neraste merged 7 commits into
developfrom
feature/232-lyrics
Apr 5, 2026
Merged

Display full song lyrics#233
Neraste merged 7 commits into
developfrom
feature/232-lyrics

Conversation

@Neraste
Copy link
Copy Markdown
Member

@Neraste Neraste commented Mar 8, 2026

Fixes #232.

Counterpart of DakaraProject/dakara-server#186.

  • Add action/reducer for full lyrics;
  • Make DetailsLongText to request full lyrics on expand;
  • Adjust visuals;
  • Add notification if fetch failed.

Side effect: refactor the library reducer and default state to be more reusable.

@Neraste Neraste self-assigned this Mar 8, 2026
@Neraste Neraste added enhancement New feature or request refactor Make things more beautiful inside, but same outside labels Mar 8, 2026
@Neraste Neraste merged commit 34bb5a7 into develop Apr 5, 2026
2 checks passed
@Neraste Neraste deleted the feature/232-lyrics branch April 5, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Make things more beautiful inside, but same outside

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display full lyrics

1 participant