Fix looping sounds #1756
Open
Fix looping sounds #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sgame/Cgame-side pr: Unvanquished/Unvanquished#3406
Fixes the magical quantum looping sound emitters that change their state when you stop observing them.
The effect can be very easily heard on the map spacetracks where the elevator music restarts whenever the speaker goes out of view without this fix. I noticed there was a
trap_S_AddRealLoopingSound(), but it was just callingtrap_S_AddLoopingSound()with no changes, so I implemented that functionality. Since a whole other function seems excessive for this I just made it a function parameter.Also removed a layer of useless functions in the surrounding code.
Added an
SVF_BROADCAST_ONCEso the speakers aren't magically paused until they come into view (this also fixes the elevator music on the different floors ofspacetracksbeing desynced).