refactor: 페이지연동, 정규식 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimEuiSoo
requested changes
Sep 17, 2024
Collaborator
KimEuiSoo
left a comment
KimEuiSoo
left a comment
There was a problem hiding this comment.
부족한 점도 많았지만 수고많으셨습니다.
나머지 부분도 화이팅해주세요^^
app/src/main/java/com/example/daejangjung2/feature/auth/login/LoginFirstActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/example/daejangjung2/feature/auth/login/LoginFirstActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/example/daejangjung2/feature/auth/login/LoginFourthActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/daejangjung2/feature/auth/login/LoginFourthActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/example/daejangjung2/feature/auth/signup/SignupFirstActivity.kt
Show resolved
Hide resolved
| <Button | ||
| android:id="@+id/btn_kakao_login" | ||
| android:layout_width="355dp" | ||
| android:layout_width="match_parent" |
Collaborator
There was a problem hiding this comment.
match_parent를 쓰게되면 부모의 규격에 따라 크기가 최대 크기로 정해지기 때문에
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintEnd_toEndOf="parent"
해당 xml들이 적용이 되지 않아 맞춰지지 않기 때문에 match보다는 wrap이나 0dp를 씁시다.
* refactor: 코드 분리 * refactor: 코드 분리 * feature: 로그인 연동 성공
# Conflicts: # app/src/main/java/com/example/daejangjung2/feature/auth/login/LoginActivity.kt
* feature: 지도 경로 분할 및 지도 그리기 * feature: 뉴스 연동 완료 * docs: ignore 추가
* feature: 날씨 연동 * feature: 날씨 연동
* feat : 커뮤니티 수정 * feat : 커뮤니티 수정 * feat : 커뮤니티 수정 * feat : 커뮤니티 수정 * feat : 커뮤니티 수정 * feat : 커뮤니티 수정 * feat : 커뮤니티 수정
# Conflicts: # app/src/main/java/com/example/daejangjung2/app/DaejangjungApplication.kt # build.gradle.kts # settings.gradle.kts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.