Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mroda/opmon #142

Merged
merged 14 commits into from
Sep 10, 2024
Merged

Mroda/opmon #142

merged 14 commits into from
Sep 10, 2024

Conversation

mroda88
Copy link
Contributor

@mroda88 mroda88 commented Sep 3, 2024 •
edited
Loading

This PR re-implements the previous metrics in the new system.

@mroda88 mroda88 marked this pull request as ready for review September 5, 2024 10:27
@mroda88
Copy link
Contributor Author

mroda88 commented Sep 5, 2024

The PR is ready to merge, but we still miss one information which is the processed_frames from the Sources.
The information is not available anymore in the Source model, but I know the information was there at some point because we had the plot. Advise on what is best to do here is required.

@mroda88 mroda88 self-assigned this Sep 5, 2024
@mroda88 mroda88 added enhancement New feature or request good first issue Good for newcomers miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable labels Sep 5, 2024
roland-sipos
roland-sipos approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@roland-sipos roland-sipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me. Thank you!

@mroda88 mroda88 merged commit b2bb405 into develop Sep 10, 2024
1 check passed
@mroda88 mroda88 deleted the mroda/opmon branch September 10, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roland-sipos roland-sipos roland-sipos approved these changes

@alessandrothea alessandrothea Awaiting requested review from alessandrothea

Assignees

@mroda88 mroda88

Labels
enhancement New feature or request good first issue Good for newcomers miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroda88 @roland-sipos