Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional NICReader monitorables #104

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Additional NICReader monitorables #104

merged 10 commits into from
Dec 18, 2023

Conversation

alessandrothea
Copy link
Contributor

@alessandrothea alessandrothea commented Dec 15, 2023 •
edited
Loading

This PR introduces the monitoring of several important NICReader quantities

  • NIC RX Queue
    • Received Packets
    • Received bytes
    • Number of full rx burts
    • Max burst size
  • Stream Stats
    • Number of dropped frames

roland-sipos
roland-sipos approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@roland-sipos roland-sipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roland-sipos roland-sipos merged commit 741b14e into develop Dec 18, 2023
2 checks passed
@roland-sipos roland-sipos deleted the thea/nicreader_monitorables branch December 18, 2023 12:37
@bieryAtFnal bieryAtFnal added the miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable label Dec 26, 2023
jcfreeman2 added a commit that referenced this pull request Jan 8, 2024
@jcfreeman2
syncing ; previous commit: Merge: c753cba 5cd9780
425bc60 
Author: Roland Sipos <[email protected]>
Date:   Mon Dec 18 13:37:11 2023 +0100

    Merge pull request #104 from DUNE-DAQ/thea/nicreader_monitorables

    Additional NICReader monitorables
jcfreeman2 added a commit that referenced this pull request Jan 9, 2024
@jcfreeman2
syncing dunedaq-develop-cpp-ci.yml; previous commit: Author: John Fre…
03c6476 
…eman <[email protected]>

Date:   Mon Jan 8 17:41:05 2024 -0600

    syncing ; previous commit: Merge: c753cba 5cd9780
    Author: Roland Sipos <[email protected]>
    Date:   Mon Dec 18 13:37:11 2023 +0100

        Merge pull request #104 from DUNE-DAQ/thea/nicreader_monitorables

        Additional NICReader monitorables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roland-sipos roland-sipos roland-sipos approved these changes

Assignees
No one assigned
Labels
miscellaneous deliverable A change that is/will be part of a release but is not substantial enough to be a daq-deliverable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessandrothea @roland-sipos @bieryAtFnal