Improvements to the tpstream_writing_test #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that support different fragment size and fragment count ranges for different trigger types and different record ordinal numbers
…of size tweaks based on testing
…by_X data_file_check parameters, removed stale commented-out lines
eflumerf
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to take advantage of new features that were recently added to the integrationtest data quality check functions.
The changes in this PR depend on ones in integrationtest (PR 94) and hdf5libs (PR 111).
With these changes, we should no longer see problems in daqsystemtest regression tests with TA fragment size of 360 or complaints about 1 or 2 TP Stream fragments when 3 were expected.
In some cases, allowed ranges were reduced, and hopefully this will provide improved data quality checking.