Checkout feature branch (if provided) to DUNE_DAQ_RELEASE_SOURCE #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, and confirmed the feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #408. I ran a test nightly, tagged as
NFDT_DEV_241111_A9, in which I had it check out the branchamogan/test_feature_branch_for_dunedaq_release_sourcewhere it existed. In this case, that branch only exists indaqconfand all it does is add some extra, blank lines toCMakeLists.txt. I created a local area based onNFDT_DEV_241111_A9and compared the CMakeLists found in$DUNE_DAQ_RELEASE_SOURCE/daqconf/with the one on thedevelopbranch and found that the feature branch changes were correctly stored inDUNE_DAQ_RELEASE_SOURCE.