-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up GitHub CI scripts #395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o amogan/cleanup-github-ci-scripts
jcfreeman2
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge improvement over the current state of the continuous integration tools currently in the scripts/github-ci
directory. I especially like all the checking for bad arguments, helpful error messages, etc.
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #392 and, incidentally, #383. Summary of the major changes:
Consolidated Workflows
run-workflow-action.sh
disable-ci.sh
andtrigger-ci-workflow-all.sh
intotrigger-or-disable-ci-all.sh
Removals
sync-ci-track-pr-workflow-to-template.sh
because it didn't conform to the relatively newDEVLINE
split. The same functionality is now possible withrun-workflow-action.sh
.create_patch_pr.sh
and its associatedpatch.sh
because they were hard-coded for the fddaq-v3(!) era and required manually editing a list of repos to submit patch PRs for.check-ci-status.sh
because a) it assumed an obsolete release manifest format and b) we now have the workflow badges in thedaq-release
READMEOther Updates
check_if_patch_branch_exists.sh
into the modern era (i.e., works withDEVLINE
)sync-ci-workflow-to-template.sh
andtrigger-or-disable-ci-all.sh
are not executable on their own, but are meant to be sourced byrun-workflow-action.sh
develop
branchesyou're about to do X, proceed?
line as an additional checkI tested these updates by replacing actual git commands with
echo
statements. Confirmed that error checking behaves as expected.